From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0775FC021AA for ; Wed, 19 Feb 2025 03:17:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F58E2801D9; Tue, 18 Feb 2025 22:17:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A5EA2801D7; Tue, 18 Feb 2025 22:17:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66D652801D9; Tue, 18 Feb 2025 22:17:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 49AE52801D7 for ; Tue, 18 Feb 2025 22:17:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C2BAF120C7D for ; Wed, 19 Feb 2025 03:17:19 +0000 (UTC) X-FDA: 83135233398.30.FE620C8 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf08.hostedemail.com (Postfix) with ESMTP id 6A6B9160003 for ; Wed, 19 Feb 2025 03:17:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739935037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SqDF5QYpzxxtQIMC27qaoyl3xHS/LtvU5i8IA1RwxAA=; b=LPpySR/3ZBih8+pS8NAJCM6HOGuf1T3bKKmn1Xyp0PEcCrtqMtqIoXguHYTg1RrIZ89hHV z2DgEtlN2RfLDzMzqatn+f/TgrL27D1pFI9PiNCS82RKy/qqzqq2mtC7tPhTnsPlYP2Ggn N9qswLCVP4BZ6bODayHZVKfgdcalMck= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739935037; a=rsa-sha256; cv=none; b=vrEp5ql5tVykp1HnElEe9cl8BmiZeCItj8PdACgGx82pCQ1fqR+sZsLCQ7iVhdbdBef5Y8 MosQ0EG4nxyWyx3xRa0ThxaJkxHOOJCkuB1H9auUynv4Dt0jukQNlUKeyw9u9Elj35YyHF mjZgnD4cF4J/e36UWjqHfRo+kZ+04EY= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4YyM0Z2Gs2z1wn68; Wed, 19 Feb 2025 11:13:18 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 4B1A11401F0; Wed, 19 Feb 2025 11:17:13 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 19 Feb 2025 11:17:12 +0800 Subject: Re: [PATCH v3 3/3] hwpoison, memory_hotplug: lock folio before unmap hwpoisoned folio To: Wupeng Ma CC: , , , , , , References: <20250217014329.3610326-1-mawupeng1@huawei.com> <20250217014329.3610326-4-mawupeng1@huawei.com> From: Miaohe Lin Message-ID: <30404cb1-d95a-1396-e4c1-dc511b29e01b@huawei.com> Date: Wed, 19 Feb 2025 11:17:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20250217014329.3610326-4-mawupeng1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6A6B9160003 X-Stat-Signature: ystswpt7rammapwd1xutdzejsi445g64 X-HE-Tag: 1739935037-25763 X-HE-Meta: U2FsdGVkX199oi6pKmz5s/4oWWirL1MmIl5KTK30F29d8iG0/SiCKaKt8/UlJhJ3ddziGRUjB50Un579LH7HT8HCdF0LYNOoLjg63TiL/fmSEJKxBsXJC40nueGKO+p4UaD8cQdAnExDsVW69qAyKwFCdhotFxvLInKqiEy1YYXAu9bgTkCaO1BOkIK8jPz8cEqPSHXBTD/vcfRS37X8WrNWsqi9zvRFgLfguBzmX93YOBTMqo2ZrNZe/Ha+RVgJKB/E5fbmq1f+c9NDg1cqpEZ6DrVOSk11QdYrFOK4ZJD3Gnu92WFkFypgBx+OW3vzTDVGk/XrW8vTtPvf0oRPTGp7QJcPKx56MOgybPJBYI56Qp3JOmgjPpSNwpbk+1OIEmzw7WyHumGXSnY2PBX2A7qCn9o5HFU04bdByj5yMCjVS2S1nhsYQiVpJX/FO1i5YCM68U6jNzAUWng9YzrBQZ0n6RhhYt7b8ZZOhu2V3f5zAf4+jvNl2HK9CNHSMkcVs+KBC2CpmJ9JFZ+B+mbfee44mfxKHEoHnliEinhbXknobgGwgWhT4fYcQO1YwPwO6QEzk5jnx/noyGwm+wfjPUxcHmOfaKImLIGf8iLa/jCWJzdaO6UY1bWgNP2fWyqZsoogNx9TcCnVoIKv5iynX6fv4cE+O0YXdDpY10zX56LgFB87lVQYFYngYeTLfVPYRyoS/r9xqQHvlbRcikGZeGXYN1YaTzUwpyZ7kFda2qZLiMJ4UOGi3sf/7iosHqnAq2HiB9eOnRIPLfDoPOHr7GOZ5d8UCRarD/zxRONOhu9vZSTOes+qsNTxPBbIhUKsZbt8gP27NMdDwBAZDqWLLnohbe0ABSy+pQn1RwkDswbqTw/G+EgnRpg+oh+NBAqyxRfOBT5cp3MsDBbIpmvPLk1iC7kYGwqZjQEqcdf5cMEF20XzQ8ub0QsP4YVSUrZUKqajPeUaIhJ4AlfOUVz ngRj9ARz d5b0ryWL54RVqA+Oha1YsOBPeQIVnN5IJkszWagZc8MnETpT3d0HueXYQiwydPbNqzflGhLLMOhmb6BJB3mLHEyQ0JAFyWn+vO6nz4++QvWt1gv6jzF3b27XipLhsfnNkGHbTBORLB7DX0uzQs4u4SPbvi4YNk9KmY737B7Oq5w3tbZOWdSoTysyIXOE1ODUcYGnlu84hJH/VTywIQU0VuOzjfYNRfow6uG8n6gC70PcYzxh2vk8mOjyGYLzrqLFLFE1DMQR/HWqAMyxeOm3266iIj2PqkUMJdO/X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/17 9:43, Wupeng Ma wrote: > From: Ma Wupeng > > Commit b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned pages to > be offlined) add page poison checks in do_migrate_range in order to make > offline hwpoisoned page possible by introducing isolate_lru_page and > try_to_unmap for hwpoisoned page. However folio lock must be held before > calling try_to_unmap. Add it to fix this problem. > > Warning will be produced if folio is not locked during unmap: > > ------------[ cut here ]------------ > kernel BUG at ./include/linux/swapops.h:400! > Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMPT SMP > Modules linked in: > CPU: 4 UID: 0 PID: 411 Comm: bash Tainted: G W 6.13.0-rc1-00016-g3c434c7ee82a-dirty #41 > Tainted: [W]=WARN > Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015 > pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : try_to_unmap_one+0xb08/0xd3c > lr : try_to_unmap_one+0x3dc/0xd3c > Call trace: > try_to_unmap_one+0xb08/0xd3c (P) > try_to_unmap_one+0x3dc/0xd3c (L) > rmap_walk_anon+0xdc/0x1f8 > rmap_walk+0x3c/0x58 > try_to_unmap+0x88/0x90 > unmap_poisoned_folio+0x30/0xa8 > do_migrate_range+0x4a0/0x568 > offline_pages+0x5a4/0x670 > memory_block_action+0x17c/0x374 > memory_subsys_offline+0x3c/0x78 > device_offline+0xa4/0xd0 > state_store+0x8c/0xf0 > dev_attr_store+0x18/0x2c > sysfs_kf_write+0x44/0x54 > kernfs_fop_write_iter+0x118/0x1a8 > vfs_write+0x3a8/0x4bc > ksys_write+0x6c/0xf8 > __arm64_sys_write+0x1c/0x28 > invoke_syscall+0x44/0x100 > el0_svc_common.constprop.0+0x40/0xe0 > do_el0_svc+0x1c/0x28 > el0_svc+0x30/0xd0 > el0t_64_sync_handler+0xc8/0xcc > el0t_64_sync+0x198/0x19c > Code: f9407be0 b5fff320 d4210000 17ffff97 (d4210000) > ---[ end trace 0000000000000000 ]--- > > Fixes: b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined") > Signed-off-by: Ma Wupeng > Acked-by: David Hildenbrand Acked-by: Miaohe Lin Thanks. .