From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132D3C2BA16 for ; Fri, 3 Apr 2020 03:52:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BDF842078C for ; Fri, 3 Apr 2020 03:52:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=d-silva.org header.i=@d-silva.org header.b="Up9Nr+Gr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDF842078C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=d-silva.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CAF38E0008; Thu, 2 Apr 2020 23:52:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67A518E0007; Thu, 2 Apr 2020 23:52:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 568B68E0008; Thu, 2 Apr 2020 23:52:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 3FC4E8E0007 for ; Thu, 2 Apr 2020 23:52:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 032DD824556B for ; Fri, 3 Apr 2020 03:52:51 +0000 (UTC) X-FDA: 76665172542.27.news73_8d2e6e8a0e334 X-HE-Tag: news73_8d2e6e8a0e334 X-Filterd-Recvd-Size: 7456 Received: from ushosting.nmnhosting.com (ushosting.nmnhosting.com [66.55.73.32]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 03:52:50 +0000 (UTC) Received: from mail2.nmnhosting.com (unknown [202.169.106.97]) by ushosting.nmnhosting.com (Postfix) with ESMTPS id EB1792DC3D2F; Fri, 3 Apr 2020 14:52:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-silva.org; s=201810a; t=1585885969; bh=/qbrUZJLw49Px53fHH61XOP2eWqn8wkHBEx+KDSvrvU=; h=From:To:Cc:References:In-Reply-To:Subject:Date:From; b=Up9Nr+GrEKkMUmYftzGW5Z/K773hVH2gCzSh13cEdpBqugKJMdGjipoexqX61BLky ayKBdVIkDJ3AWvztbbnCAMuWghuRpEFqwjwO7ZCBySBD1og/S2moYgXWRLdsSxX+/a KJgQMUpBu1dvVGv3RzD7CKJW6Ql/YjGtVRIEdQhmeVNyq1ucOVrbsqPcxHsZ+5jnri Uv3gZ/TiZUFYse5Ms95Z1Isf9lqt5FiL5KglNeH/kJ9Lgfiemfl0uqNeXdpg5ODP5o u6tP8fDctVbvByp+bOWemuDuloxT4MdnLoEHoVlKW+W9vSHWIHNQXZ20e1h7GgTyf7 Up1xIESuRDLpJxy9TskeAI2MQyLG89eASMl4ymxz8xf3P8kJzlpEdTImYRU3qypGCP vghn0zggG+R2Y8UxG2Kx7ibgXj6dwDdOJWPptZ0Sk1ktQRdv5asJnawbE1/uJnBT9/ m5GTdMJ5I51IJ95FMhLNN61RTqmrzxxb+realllSuHBu5Bjn+Nc1OCOOHGq7OPg5Vf O1E57PRzyRKY5TIWerTom3GmJfKugyUp+sax+i4x7dqJt/gevtV73WHliEnb/jCfAa VXnRR+uAepbur0PMxUSeNhrd8VYWuGsIiSzvW4k9HoPd6oeU1HKABrDdyxr7r8tDrB qLLBCAUjvg7BTg/sH/3ifbfg= Received: from Hawking (ntp.lan [10.0.1.1]) (authenticated bits=0) by mail2.nmnhosting.com (8.15.2/8.15.2) with ESMTPSA id 0333qhBP097301 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Apr 2020 14:52:43 +1100 (AEDT) (envelope-from alastair@d-silva.org) From: "Alastair D'Silva" To: "'Dan Williams'" Cc: "'Aneesh Kumar K . V'" , "'Oliver O'Halloran'" , "'Benjamin Herrenschmidt'" , "'Paul Mackerras'" , "'Michael Ellerman'" , "'Frederic Barrat'" , "'Andrew Donnellan'" , "'Arnd Bergmann'" , "'Greg Kroah-Hartman'" , "'Vishal Verma'" , "'Dave Jiang'" , "'Ira Weiny'" , "'Andrew Morton'" , "'Mauro Carvalho Chehab'" , "'David S. Miller'" , "'Rob Herring'" , "'Anton Blanchard'" , "'Krzysztof Kozlowski'" , "'Mahesh Salgaonkar'" , "'Madhavan Srinivasan'" , "=?utf-8?Q?'C=C3=A9dric_Le_Goater'?=" , "'Anju T Sudhakar'" , "'Hari Bathini'" , "'Thomas Gleixner'" , "'Greg Kurz'" , "'Nicholas Piggin'" , "'Masahiro Yamada'" , "'Alexey Kardashevskiy'" , "'Linux Kernel Mailing List'" , "'linuxppc-dev'" , "'linux-nvdimm'" , "'Linux MM'" References: <20200327071202.2159885-1-alastair@d-silva.org> <20200327071202.2159885-9-alastair@d-silva.org> In-Reply-To: Subject: RE: [PATCH v4 08/25] ocxl: Emit a log message showing how much LPC memory was detected Date: Fri, 3 Apr 2020 14:52:42 +1100 Message-ID: <303c01d6096b$541f33d0$fc5d9b70$@d-silva.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-au Thread-Index: AQJ5L4Hn/mp5p0p1jYAFWLJ+xmWSbgKkO1ZLATOc+DmnAbiIwA== X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail2.nmnhosting.com [10.0.1.20]); Fri, 03 Apr 2020 14:52:44 +1100 (AEDT) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Dan Williams > Sent: Wednesday, 1 April 2020 7:49 PM > To: Alastair D'Silva > Cc: Aneesh Kumar K . V ; Oliver O'Halloran > ; Benjamin Herrenschmidt > ; Paul Mackerras ; Michael > Ellerman ; Frederic Barrat = ; > Andrew Donnellan ; Arnd Bergmann > ; Greg Kroah-Hartman ; > Vishal Verma ; Dave Jiang > ; Ira Weiny ; Andrew Morton > ; Mauro Carvalho Chehab > ; David S. Miller ; > Rob Herring ; Anton Blanchard ; > Krzysztof Kozlowski ; Mahesh Salgaonkar > ; Madhavan Srinivasan > ; C=C3=A9dric Le Goater ; Anju = T > Sudhakar ; Hari Bathini > ; Thomas Gleixner ; Greg > Kurz ; Nicholas Piggin ; Masahiro > Yamada ; Alexey Kardashevskiy > ; Linux Kernel Mailing List = ; > linuxppc-dev ; linux-nvdimm nvdimm@lists.01.org>; Linux MM > Subject: Re: [PATCH v4 08/25] ocxl: Emit a log message showing how = much > LPC memory was detected >=20 > On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva = > wrote: > > > > This patch emits a message showing how much LPC memory & special > > purpose memory was detected on an OCXL device. > > > > Signed-off-by: Alastair D'Silva > > Acked-by: Frederic Barrat > > Acked-by: Andrew Donnellan > > --- > > drivers/misc/ocxl/config.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > > index a62e3d7db2bf..69cca341d446 100644 > > --- a/drivers/misc/ocxl/config.c > > +++ b/drivers/misc/ocxl/config.c > > @@ -568,6 +568,10 @@ static int read_afu_lpc_memory_info(struct > pci_dev *dev, > > afu->special_purpose_mem_size =3D > > total_mem_size - lpc_mem_size; > > } > > + > > + dev_info(&dev->dev, "Probed LPC memory of %#llx bytes and = special > purpose memory of %#llx bytes\n", > > + afu->lpc_mem_size, afu->special_purpose_mem_size); >=20 > A patch for a single log message is too fine grained for my taste, = let's squash > this into another patch in the series. >=20 I'm not sure there's a great place for it. At a pinch, it could with the = previous patch, but they are really different layers. > > + > > return 0; > > } > > > > -- > > 2.24.1 > > >=20 >=20 > -- > This email has been checked for viruses by AVG. > https://www.avg.com