From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479C4D41C04 for ; Wed, 13 Nov 2024 12:28:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B6626B00BC; Wed, 13 Nov 2024 07:28:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 915CC6B00BE; Wed, 13 Nov 2024 07:28:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78EEF6B00CA; Wed, 13 Nov 2024 07:28:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 576A16B00BC for ; Wed, 13 Nov 2024 07:28:25 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 605B940905 for ; Wed, 13 Nov 2024 12:20:14 +0000 (UTC) X-FDA: 82780976964.13.4AC2A5E Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf03.hostedemail.com (Postfix) with ESMTP id 9A4C72000F for ; Wed, 13 Nov 2024 12:19:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=P9IGnTMX; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731500177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=44idHlU+avyOzhoCNle7NKo00WtYnFE29wGtuv5rhUg=; b=UuGieB0LVUORcwBW1fH2/NChJSMbcTj+rWwFTxMD7YmZ23HMfIGLyH4S1A/yR+YTBZBkBu AL2vpW4WjLqC7jYL4ACpZJllaSEHXb55fZHqetV5oTBgdEUXjTpdIpX3ev58BHEMyYQLlC LJPyYqxiydSUgXu66jztbxLsriSRwBk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=P9IGnTMX; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731500177; a=rsa-sha256; cv=none; b=vhVeSUweMzjR0BrczVVGWtme9NqxM/dyKtZN9w1jkFesuz/3HPwrioI8yr9S4gSWTBwQLB xhEYUIHxuJOmncGRNvMNQLmLV6w2OPl3+2IZvIG8FBZTSdU+BSmg/YY//LhxmH8hFw9QWG tZ7wHtF62X1eTAYcHLeh3QaxOacrFoY= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-72061bfec2dso6175600b3a.2 for ; Wed, 13 Nov 2024 04:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1731500409; x=1732105209; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=44idHlU+avyOzhoCNle7NKo00WtYnFE29wGtuv5rhUg=; b=P9IGnTMX1nRG3tIVhGxusUsgOUMoCUHKxJscVIeHer+D2wBaD9hfj9QJsIvJWIDgZc z43rrDpa9YBnjiYiP+z77J7edCLSGX2u6EfYWH3WOeMbtC/94utUzGu+qa7/vBlVTrpt fbbFntITslUwUY8UTw3Do/3XIL5S9JjpIrAMN4v6gnq6tET+DkSDAPG+3i1YvLKLtZtj s1rQZ/sGOBblxHCRn/X125VdIPQT3A5t7BOg/BAE3rfC7jy3WzyzZkCKKy8BEOpnRLLo i4ZNcrM4DOEMb+yZldBiVlmHKHAa5LBeNrJvjfo6EAkMVltAOpWQ5pP/W639lo2osRk1 Cwmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731500409; x=1732105209; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=44idHlU+avyOzhoCNle7NKo00WtYnFE29wGtuv5rhUg=; b=Jv1Hjs7KfHnPcDFe48ro2TLXDVYU7eF9okoLFA2SuqKzjUM1FBZxCMS8E3J/JJ6ag+ J7qfgOFkePxmt1VvAjBpjV2P1I6nZLxHs/u7EE9M7npmXE8GGROU3vYTm9pFC0tovh1K xkvc6XnlOC0YZhnVnX9qR3BCROjkyvuJuOnKO5i0Bv1uVVmE8k4Ek9LGUEaAAChZso6C nOxtBSe9qaIvlWFYfOG1NOSCA4gp8ha9mKgP9o1kPRhw2E7LEHM8V+gYaH2Lov7CyWjd 663/pO28dPvTsRLfEMoFlsIXFQ/EsRZpg7wyGgGwJfNKBiSwfb0D31zBzW6wefUGUYO/ Yz3g== X-Forwarded-Encrypted: i=1; AJvYcCWsn5M//oryaPvMEz7LUU62a1nVG1NgvUbyOhlLEoal5jzZTVWO1nccOrTVl2A1O8anvDkqkVNHVQ==@kvack.org X-Gm-Message-State: AOJu0YzPfTOd7cMxhF+b9GvREzR3Hs3qE1oCA1iu84P42pxSBwPA8ugW Z7/OdrLBthcOcnR2bAzYli7GBIeuO/PyhIWuQ6spmYnt2oCLDL1afIsons4lLhI= X-Google-Smtp-Source: AGHT+IGU1/C3z5Xuj00yzrIJjZiSkzODeiRfgtWw0s+UCt4n5GgEqa5Ttt6Z10SB7L8TXSqB78Fpng== X-Received: by 2002:a05:6a00:23c4:b0:71d:fb29:9f07 with SMTP id d2e1a72fcca58-724132cd842mr26883002b3a.15.1731500408789; Wed, 13 Nov 2024 04:20:08 -0800 (PST) Received: from [10.84.149.95] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7245fe8e286sm678323b3a.16.2024.11.13.04.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Nov 2024 04:20:08 -0800 (PST) Message-ID: <303bff80-b535-48a2-bc38-d305cc3fc5c6@bytedance.com> Date: Wed, 13 Nov 2024 20:19:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] mm: introduce do_zap_pte_range() Content-Language: en-US To: David Hildenbrand Cc: jannh@google.com, hughd@google.com, willy@infradead.org, mgorman@suse.de, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, zokeefe@google.com, rientjes@google.com, peterx@redhat.com, catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org References: <1639ac32194f2b2590852f410fd3ce3595eb730b.1730360798.git.zhengqi.arch@bytedance.com> <2fd11f54-8c0c-401d-8635-e54ebf7facc2@bytedance.com> <6e9c649f-5fc9-4fcc-928c-c4f46a74ca66@redhat.com> From: Qi Zheng In-Reply-To: <6e9c649f-5fc9-4fcc-928c-c4f46a74ca66@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9A4C72000F X-Stat-Signature: r1aak4r6upbmh41nb4pamtqsncn6fe6e X-Rspam-User: X-HE-Tag: 1731500390-677451 X-HE-Meta: U2FsdGVkX1+xf9kbPKGM8pXBSw6q1vtTsySzNWOfk/i6FlyYlWMF6JaL20Mya3du1/CL/Fh+rqemkpQeOLRCqtnI7N2wNvKp4mB7W2YQJv5tA9tnGsT2I2dVxf9ju3/k43ZCZxg7F2FWQZFbN6Ww/ewOw2fqOC7OXg/YOS3DI2JuY6InSlyTeuhnXgSmMccN/xOA+t4wc4rHJJ7HAsd5LFRIv2GYF4l9KMLuE4+IkCzZLEMtd7mI2Umd8m0SQ3nMc/mvTzMMt/12DfNYsmX7upF5LdB+PYrkasGB/5wtyywiG3neHxdufBd+GENbUIFgOseGMNAq7x6b2f+75m9QDKkh9gb+VCbB+eNjFPNmOnfE55PwNAJmoBEhfxf4GNcdjC/WSbs6TeKM2/rJzpgjtBhu2oQs1zrgBlb306TFLC0m2w7+uSjWYuReLhoR9kTLNapVFtFKz/+0GpJ+0fDcF8JVAVNucuox5z1u6qN0vmVzCZzjwmpMTl8lIrz7ggEpnlU0LxmRIH8VsXpYRBzCMmDzDSOHJgNY2uQ38YQSQ0wv0mtbcn+UEIOF8umcPl9DCTqRr2cgkrbxV+PXO1+2V7MraCrh04hFZRKk9S9bxrtgpkn4hiEpLk/7nzIsL34lRhQ6XeIkKXNNx6UuRKpbHnTJJY0n67f/yRIeESyYZmU1CR0hd9UJUvss6jKlgeGVR0ypgSaNC/3cj0sYoo3+XU3GtIzrYN1fg4QIZZMNmsUc8JtGTJMQebA2S4fYqGkDvOUCAZ535XkbWEtx1JWirCqIWbfYF5iJ/g1Jm7e8JUm33tHh1d8yWQush1F/UNrIVr/h/XDkXWrZ7pFoqXKtNEnOtaA6m+DlyWMHzj6nBS0Y0A4s8H1CNO+vPy8+cXj8JwNXENRYRxBdZJqjxS61eP4Fqf3WNZFAP9xFtT5hhY0TxK0O6En9pX5DrK+300QOOjNUa7k3hsLU4KQgKkd UWZLGv5u 7SmYs/P9CVQD3O0+bnyxi/DptLGfPMmVLJWVRWUCidxWwOA2jV+sPTajf1160idxsRmcNGPHtqbeyjOo/6D6WU3fV2HM2GIIBvz8Ahz6NB6+bs4kLUR8WhUWfIPnU25QI2ygSs9dgjji4Tm7Ld61Pa26dCGIBiZxEfkcwv6WgDbSlYQu3WQfovhvpSv4IErWWUxyrvDV3/byhAxgQoL6KBhFZn6IjGMOgCyoBO2Gf55LKyZz8EsHKlepKfD5fAC5djowj0dlFEoWts2LaOZbK36Wd2ctDkPlnH4xuZJs8sHKOFzSp962zmGJdgoLOKuvoYFMHmKjltWb0fYErGrXp33r9keRz+tTo4P0WsI6Cscg5MlvtXcG80/AcjerJUZqSMM/5Yvl3sEX+hh8XGLmfVL4RrfWZWADqC4T4KhphW5oDO9H6AHJdM3O0zA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/13 19:43, David Hildenbrand wrote: > On 13.11.24 03:40, Qi Zheng wrote: >> >> >> On 2024/11/13 01:00, David Hildenbrand wrote: >>> On 31.10.24 09:13, Qi Zheng wrote: >>>> This commit introduces do_zap_pte_range() to actually zap the PTEs, >>>> which >>>> will help improve code readability and facilitate secondary checking of >>>> the processed PTEs in the future. >>>> >>>> No functional change. >>>> >>>> Signed-off-by: Qi Zheng >>>> --- >>>>    mm/memory.c | 45 ++++++++++++++++++++++++++------------------- >>>>    1 file changed, 26 insertions(+), 19 deletions(-) >>>> >>>> diff --git a/mm/memory.c b/mm/memory.c >>>> index bd9ebe0f4471f..c1150e62dd073 100644 >>>> --- a/mm/memory.c >>>> +++ b/mm/memory.c >>>> @@ -1657,6 +1657,27 @@ static inline int zap_nonpresent_ptes(struct >>>> mmu_gather *tlb, >>>>        return nr; >>>>    } >>>> +static inline int do_zap_pte_range(struct mmu_gather *tlb, >>>> +                   struct vm_area_struct *vma, pte_t *pte, >>>> +                   unsigned long addr, unsigned long end, >>>> +                   struct zap_details *details, int *rss, >>>> +                   bool *force_flush, bool *force_break) >>>> +{ >>>> +    pte_t ptent = ptep_get(pte); >>>> +    int max_nr = (end - addr) / PAGE_SIZE; >>>> + >>>> +    if (pte_none(ptent)) >>>> +        return 1; >>> >>> Maybe we should just skip all applicable pte_none() here directly. >> >> Do you mean we should keep pte_none() case in zap_pte_range()? Like >> below: >> > > No rather an addon patch that will simply skip over all > consecutive pte_none, like: > > if (pte_none(ptent)) { >     int nr; > >     for (nr = 1; nr < max_nr; nr++) { >         ptent = ptep_get(pte + nr); >         if (pte_none(ptent)) >             continue; >     } > >     max_nr -= nr; >     if (!max_nr) >         return nr; >     addr += nr * PAGE_SIZE; >     pte += nr; > } > > Assuming that it's likely more common to have larger pte_none() holes > that single ones, optimizing out the > need_resched()+force_break+incremental pte/addr increments etc. Ah, got it. And I agree with you, will change to it in the next version. Thanks! >