From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B47CBC61DA4 for ; Wed, 15 Mar 2023 13:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26E9B6B0072; Wed, 15 Mar 2023 09:53:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21EE96B0074; Wed, 15 Mar 2023 09:53:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C0BE6B007E; Wed, 15 Mar 2023 09:53:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F0AE96B0072 for ; Wed, 15 Mar 2023 09:53:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C65A2AA9EE for ; Wed, 15 Mar 2023 13:53:19 +0000 (UTC) X-FDA: 80571274518.12.D4B6738 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id BE54A100016 for ; Wed, 15 Mar 2023 13:53:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QKY7ReI4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hfK1YuSX; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678888397; a=rsa-sha256; cv=none; b=uIeNiqRf1LGpqerOpnoEtbthWUbmsRyV6FH1IV4QqGKVD5dkOtg/eOpZnLJGd9oPUn2u5f 64pXm9X+yIJN8a8Hx/EkAwYCwE7BP/kWimEKtUlmExP1CKbNN5IYJymWw8mDpBCYxzcNn7 ne62klLs6sI/di0ClESKocHTROMufQM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QKY7ReI4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hfK1YuSX; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678888397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MOPh0muXJMBra7JZNI3t/z2XlH5ZqBP5RrIbmuie1yI=; b=MFd2xh5DoirnF+YvqLngU7+CXy8xEvnx1lC+BDRyt5VtmQYdVzwvV/DN0rGekgHXuwW6JF HDEHIWGGNPoskth3sqz8NEno9z9HSzHreozN7vqovlRiNFnm4ZusvCx7Yz8Ol7Gk/DKdL6 ZzowDdVU+npBgR87AE70BBDS/d0m6qQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6F9EB1FD79; Wed, 15 Mar 2023 13:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678888395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOPh0muXJMBra7JZNI3t/z2XlH5ZqBP5RrIbmuie1yI=; b=QKY7ReI4YqUdmQ7e0+BHWBqf9m7ixDyOjxCoGENb2xA+1wj7zrm7TjjNGEiobjrXHUVxKf v53hJZpSJX+rpnCBg7mAaf3z3f8Yim7fGJd9aL8fVK4WoJCxBzWUTw1Dsl/FN/k5G2FEEw E4xb1+MFU0eMEOGLtwSgV0hC1IMmwFE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678888395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOPh0muXJMBra7JZNI3t/z2XlH5ZqBP5RrIbmuie1yI=; b=hfK1YuSXzjNyczsp8N+D3Am3mFL+dYrF8UhS3D3/wzfYSwo9B843Z8eGEzC2/Le+8zOIq+ 7n6wutSBx1+NMzAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0B86A13A2F; Wed, 15 Mar 2023 13:53:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qcwkAsvNEWSPNgAAMHmgww (envelope-from ); Wed, 15 Mar 2023 13:53:15 +0000 Message-ID: <3018fb77-68d0-fb67-2595-7c58c6cf7a76@suse.cz> Date: Wed, 15 Mar 2023 14:53:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/7] remove SLOB and allow kfree() with kmem_cache_alloc() Content-Language: en-US To: Steven Rostedt , Mike Rapoport Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org, "David S. Miller" , Eric Dumazet , Frederic Weisbecker , Jakub Kicinski , Joel Fernandes , Jonathan Corbet , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Mike Rapoport , Neeraj Upadhyay , Paolo Abeni , "Paul E. McKenney" References: <20230310103210.22372-1-vbabka@suse.cz> <20230313123147.6d28c47e@gandalf.local.home> From: Vlastimil Babka In-Reply-To: <20230313123147.6d28c47e@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: BE54A100016 X-Rspamd-Server: rspam01 X-Stat-Signature: w4s976i4mmn6cgyfz9royffechzdd6mx X-HE-Tag: 1678888396-109870 X-HE-Meta: U2FsdGVkX18siQAipZdrG6fxMUhzBpnROPn2TbJ+mQ1d4kRmuxBdhRAiYzjLWYmNNo8/pf+4ISyi/75hm+dgOc7/C95478BpBBvHujE76TXpmpMD6doeWOfuo2jnghKuMaFh9waQlHxcbbNsJYPNSBPaBn12hKi0jh+iwHhK7B+Atnz4S5dls0qTpzbUZ6Xu/8Qxi04kxTPtdaKJFb/KWIl23JRHE8QKRlK+H5vFdjJvDWDhPDZ9cF/o8kj1/4PGW7TeuWnp+G+xNQP0fltmxnMphScb/spNvprbjhjBAL53n9ZjldoHI1k46f0LEZG3D5ffQI5y5ORnPDt6UvKhGIyIjorQUXWC+fw/sW62m4cPpCsiRNTwa8ZyZysAQ2CBtnCXiK6joHmyBpqqgfifIuBz3cY0oz0U7Nn0cR7y3lTEXFIkRD3arKv2YSYxax3TePWDU8xHkJOoMFEoJA0G81SsKxJXxc2mKCDbyUH3F01KLVD70uRBOsw/FKg+oCN5cbpFfyq115XAksX+9sb0AEufyO17g/Mc4GSUON969HQxiSbZy5s3+pmHrNsOZSAHW+UeOo/67iXCsErBqqzDKblPCuUje9ispMMokQtIj8hm68GM6GJKTVpcS6I6M3rSozwdr7x5wdB4+t/BmKGoGJzjAc4tqDOLSG7sArKLWa8N2g9If+ih/jFukT/eNg7khScisRZnj+IGX1NUWn0blElWI0IOFxUAi+zwgixkk2fhLTftzZZNX9KX+cy72OFMcG+RaM6/G6pqRAU/A2riowkkCtzJWntC7osxBAaRhGEiZ89CGbLb+d4f13tyun2Pk1VpIRKdD+HbYVAMl+qHZg8me+j+qhpxxf/OwQDsANX+vz3GTrwOQa2oVh5N3wyamk8ba9eu/l49iV4IY/ylXYRzeG4+jR9H7T7Ib/NdeZfrtgoEsqpmR89Ywuu4bUvbdpKWlLjYsy7GWSc5klx faaTR+FZ vvVx6K4Wq8UM1tTPsEunx9bnN6RIhG2k+KVzYoLYhnARlIAacvGzRqlX5ce51KcFfbaCzpRN5+saX0XQyQiIkqjjYjAipx3tr359bAZj82Q6tQkRJy6aCaAoXEkFuROZhtKcwQsqfeW9EE0SjaL1v1SKFArbFRNpKfY6QTRjYvwGy75uJ+Bcw3BP5R8r/LCs0irAq1fZSZywac92qmSleynRPhhql/tsdlmQDs9p0S9vFGYnT/azd5atTg4ffkx8A6s0QcEoy20nCxcopLavluBQU/ILdttOicZ39YkJyRyLpm8xtGTD1u1znDwYsrUI4d0Z+Y5f84Sxf6gxsWdvs9IcANveq/26rn/N3p06nqBcvEeSkKDsKa0xWqOoSQNxDY6PvGuwiukd/DL67bEsbBYIwzdW8xxAX0lyM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/13/23 17:31, Steven Rostedt wrote: > Just remove that comment. And you could even add: > > Suggested-by: Steven Rostedt (Google) > Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer") Thanks for the analysis. Want to take the following patch to your tree or should I make it part of the series? ----8<---- >From 297a8c8fda98dc5499cfe0eac6ffabfb19d1b70f Mon Sep 17 00:00:00 2001 From: Vlastimil Babka Date: Wed, 15 Mar 2023 14:45:15 +0100 Subject: [PATCH] ring-buffer: remove obsolete comment for free_buffer_page() The comment refers to mm/slob.o which is being removed. It comes from commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and according to Steven the borrowed code was a page mapcount and mapping reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer"). Thus the comment is not accurate anyway, remove it. Reported-by: Mike Rapoport Suggested-by: Steven Rostedt (Google) Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer") Signed-off-by: Vlastimil Babka --- kernel/trace/ring_buffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index af50d931b020..c6f47b6cfd5f 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage) local_set(&bpage->commit, 0); } -/* - * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing - * this issue out. - */ static void free_buffer_page(struct buffer_page *bpage) { free_page((unsigned long)bpage->page); -- 2.39.2