From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD3CE7716D for ; Wed, 4 Dec 2024 10:41:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E3BF6B007B; Wed, 4 Dec 2024 05:41:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4935E6B0085; Wed, 4 Dec 2024 05:41:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 334356B0088; Wed, 4 Dec 2024 05:41:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 152596B0085 for ; Wed, 4 Dec 2024 05:41:06 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 952621607E5 for ; Wed, 4 Dec 2024 10:41:05 +0000 (UTC) X-FDA: 82856933460.01.934D4AB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id C24CE18000C for ; Wed, 4 Dec 2024 10:40:48 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EK5Pd0G5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=F4Jfeb8w; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GQFG8pTe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yox855CU; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733308857; a=rsa-sha256; cv=none; b=FdZlXGvtuTldakjbjxQdWPCjz9U/hLfVkJZ6n9EYsdwhs+A7TdSqbB0IO8CH9kRT+xlYR+ Txuqutla3b6PdhZqh303qQ7X9iADyTcPYtA9ZPwG2uVTT6cUJuaoy3nGOImojnjztKMd9C ASbP4klIY8wyWqNumoSVl/TP2mjPcNk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EK5Pd0G5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=F4Jfeb8w; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GQFG8pTe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yox855CU; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733308856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H6621CW7IoFmy0F7APkks74xf34jPswg86fRJw93q9A=; b=jeYb6flXn06jtVRyldk2bK7A9nXbc1kh/QS3WukkeiGh+GOluDYPnsZoTzEVcrShGN8JsC 04eUvpIVq06gd32jrDB1+LD4NTP86HB9caGgTlAFKkrVrIiSI2xL8vGOKeY3p9awSmzUDr wxuVWRhg4v0QTZ9WfLMhNSq58DM1y84= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D432B210F5; Wed, 4 Dec 2024 10:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H6621CW7IoFmy0F7APkks74xf34jPswg86fRJw93q9A=; b=EK5Pd0G59ejePPspCFX7GHoisczrLgJRhbhK6Tvll9neQP9MTwR9Gd2n7V1wOHSGufvSry 3JsDM6Gjd1pDFTCx0M/J7Yd0WntPpcH8TsQbSaowIN9CzQdr4XbBJmLRy+PIv8Hrchibr2 +S9c6FIYLOM1WdDdk6J7uI+fT/fZ3tQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H6621CW7IoFmy0F7APkks74xf34jPswg86fRJw93q9A=; b=F4Jfeb8waenD41lJQXLBcMG1udBVDZH8kfg8YboIuVIk0dhz9nWngpnPcDmKqvwjx/tpoH pfpNESNOUHLLIOCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H6621CW7IoFmy0F7APkks74xf34jPswg86fRJw93q9A=; b=GQFG8pTe7dsAqlC5Bb+fVE85oWFvAjLdL8ThunfAblSpTEtLZkuN58Z/wW76jJQvGXALIQ WY9yxFFuVeAk5qYfeHRvCmxzcKyy8DWu6c0Orcx6ohgnNhBd63IbAqSXDqy+hAPLMc/iGl Wm+hQ3o4oMu2j0HMPTQ9WmorIs/caeE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H6621CW7IoFmy0F7APkks74xf34jPswg86fRJw93q9A=; b=yox855CUqQIm8LyxugVJRRb/O9igtV0Z0zKq4imby78uzG/3phf0IW/KkmF/sSBacfslje eeLUoKfKWkOptKDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C4FA413AD4; Wed, 4 Dec 2024 10:41:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JR+/L70xUGevBAAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 10:41:01 +0000 Message-ID: <30182df7-e9e5-4c26-80d6-46bc145e0762@suse.cz> Date: Wed, 4 Dec 2024 11:41:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/15] mm/page_alloc: Move set_page_refcounted() to callers of __alloc_pages_direct_reclaim() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-11-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-11-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C24CE18000C X-Stat-Signature: gsbe3b1ku8f9capakphryjzcbjzdsc8x X-HE-Tag: 1733308848-483646 X-HE-Meta: U2FsdGVkX18cxEusla+8HeU6rFSFFp4VQ4jbI+nG/k0wcRuGKyr8Zj/QPHzVaKz9OAW56ajI0UFUquRF+WUYpXupxqI9zq2mXoWeZgUVSdXZeQOVQO6zR3s1mpSIUuAQJoa020NqgZe+3GH5/gvOvjepqx/vWVRbvlKhYuoPGHcpcRK2ordg8lD1KGts4ihrWD4DOcX0hKKEiA63AiSSnX6j8ZlupfIwaYcwX5FlIo2nmFrn8rIQ1NAD3MgkZD3RZOnXUIt664lvOwfegYArG4Gev2kbVtOIaw+FMwFKjzMGhb4VsipWN/p4Ymh+tVcRVtQpu6ktBS5gXPg3YB+rb08jcerW92aFEAG5Roru1aTMxBRfpgT3xoxXgaYDaGh4dZrvcVA5IZmqtQ/a/8LJyucnx0dxiafHK98x6eZpObkEozuPO+E6RTX23UjoV3cAvoRRT4IKZix6mIYcnprpEQYkSJbdMBQ6VDP2w6OiTog6xqMWlDWljjUTAnFBrDycBNSfrsZzdIHcJpenTUJWO8f3RIgdvzpYHoZO1/2fybb3n7m9jjWFUncNEsUD568ckuCYAeP7v57ljjQkaOQkLK/jKOotjNQWQEBdeVmjQsNJ2V1KRuYNZ864A2EEZoxmk3+aNi5Am1shL7cDzCx5tGe6XLBtkMK4Opm7IW7TuYxJm49PoYUcGGxxLy1F3oac411fnSGrUmg5vcfMKEIdXM1SgsECYVPrzLX7Pv+/2Ap6LeGJkGldI0+zA+RT/RNqrAkL1gCJGhjjtmAI4NcfXnMHqzaKWz/Q9je1A8eN69b4DTKYSHrCioh3un+jgPml3vdr18+Iwd/gx1ArE7zXg6SBosyjP9cLHL0th+i2gPLZ5zsoVte59yP0GqQlc3+TMgSAXpx3MjnZGZuwkrWtMI7YOuWQRVGVoFbwP2sehN/3u7Q/H5jcZ0AwbMykcPlGgU9pIbl3cx6l6Dylvvb u2XldqqO vW8TNbwig1C2fyZI/UkAeqJEXvR1e8HNLgHGD+I1/mlE8+iryaMydSXKL5ukw1ytbhNcAglnuYYQAwv3XYxHCR/PwCe33/dFgzB13cdea4jBf/NCydLG5MJadBw6X0Jrt09zdB3nFA6er6LPd+l/czVG+VT/OgffOcviCZPVobLGX2WNKq+jkWLgsbnDDqZFIgkv+5or/3ptkmRmNF4MSWkj6f3khWtAGXvktMpGoNRfQnNw3k9KoagnSaOMkZL70IAzGMCUqCZRwdOJpSs01E7wL2JO4N8FkwnBDdaUbI1SS83MA3i5nI/lFjfGN22qK8QYalYeDNz3lZtUpXDanTTacSzXVplzmqgG4UCpJcwpzjScjhRAQRpsiLtAqBHgkOSvncGfAHzf9yg4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > In preparation for allocating frozen pages, stop initialising the page > refcount in __alloc_pages_direct_reclaim(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0f02cb253bf5..7acc32902fc9 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3998,7 +3998,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, > drained = true; > goto retry; > } > - set_page_refcounted(page); > out: > psi_memstall_leave(&pflags); > > @@ -4420,8 +4419,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > /* Try direct reclaim and then allocating */ > page = __alloc_pages_direct_reclaim(gfp_mask, order, alloc_flags, ac, > &did_some_progress); > - if (page) > + if (page) { > + set_page_refcounted(page); > goto got_pg; > + } > > /* Try direct compaction and then allocating */ > page = __alloc_pages_direct_compact(gfp_mask, order, alloc_flags, ac,