From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A194CC3ABB2 for ; Wed, 28 May 2025 08:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA7826B0089; Wed, 28 May 2025 04:43:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E58B36B008A; Wed, 28 May 2025 04:43:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D20DF6B008C; Wed, 28 May 2025 04:43:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B2BB46B0089 for ; Wed, 28 May 2025 04:43:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 11C1D1D15BA for ; Wed, 28 May 2025 08:43:52 +0000 (UTC) X-FDA: 83491678704.06.2CF3B1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 8375B40007 for ; Wed, 28 May 2025 08:43:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QamR9q95; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748421829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kk80hAomBWzM19/Su1s9eDfNrr/Un8h9+65H/+QhjOk=; b=tNl1SOtoN+0kvVzjwhVozwWCAjuoZNqM1eZt5ANXxGWDlJHPXKFlMPjwp/H8mS7OHuPKHU OXUzrOQVKFy3vml5b8YUxswZ8lIPMYxcDFrpyQZBjEV9omNipYtdAWEjeGdVqGXYE/Phyt CyNElDzWSGYxeJqeaxBSXNiou+GqK8w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748421829; a=rsa-sha256; cv=none; b=aV3uskBeNu3Z5UVcStw8kubnS9cXDgtQn4K6vpq+z7ZbOUrbSHMmt6I1EUzkM4Sb967e0z d1iFKf+xnQBsd7fzukm8Rk/VQABi+h8zwTRAmSepWyHO+/Kq0OmUjBOAm3c33dKWSvB3u2 q0ldtW4AUtYIWusLIyPP9Igj+/ccTSQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QamR9q95; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748421828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Kk80hAomBWzM19/Su1s9eDfNrr/Un8h9+65H/+QhjOk=; b=QamR9q95k689EWcYA1nLW8xW5Pb5yjITjctCLI8gVyAv5uIFOG0MIbixcxBLKSdvh1aXm6 VFe7Sm4NnUG3XB2YzahtrHNHMb7GTN6NRmvZt/XF5sjWdIfZ+yPRMFjOPV/vi1idP1BUVO gMKl/Khx5zK4jOgVas9jNZOjdpNoHHk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-oMuHI94yMVSoe4mDQEa1Sw-1; Wed, 28 May 2025 04:43:47 -0400 X-MC-Unique: oMuHI94yMVSoe4mDQEa1Sw-1 X-Mimecast-MFC-AGG-ID: oMuHI94yMVSoe4mDQEa1Sw_1748421826 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4c8a4963fso2612470f8f.1 for ; Wed, 28 May 2025 01:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748421826; x=1749026626; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Kk80hAomBWzM19/Su1s9eDfNrr/Un8h9+65H/+QhjOk=; b=O2zBoWqjF9DMAw3Lplb9/RTN3hs12yGugkWyhQR0fB9IJK4OMpYQuDXQ2utUu/WgX5 1d9lBKBs1+hfU8kLzKS6Zy+EkhiAMwoVkzzz1KH0x35y6XICOodrHjODL7o4NKocEE7R EVK4D/EoC7TFdDxXdqFjJvKt/50aE3/ZDGzgMi0QOKmXtMqJkWHylhwyL3dUqM32E/Va IUd2ZUzKwMN3cWyui5ZmVQsOPt/TTfYBEFN259M9AG+cv0R0wkFfDXtrs0pifesTvR2q sRRLfkzV7L7iZFOnVpHeayhP45tfUZ1dhp7zSps7kvQ/pi7tWaynmLRtneoQXjxyz5K7 AOJg== X-Forwarded-Encrypted: i=1; AJvYcCUtHCViQgR6vrH5r3FkwuKCILLFfN9pFSMb5S9b3TO93jSVAHE+UUyWm1nN7I+U4ZAN7n3xb2R5TA==@kvack.org X-Gm-Message-State: AOJu0YzFXs9sYWyIzNImv+a4Sq7HSBi/xCgLWhUyMyRmK9iaMase8PUV rMCENHhHlQIidilbyeveD15OrfdFJEPFr9naJVYG9n9b7U7D9AhN8GecnScN+BFfGB+RMIYaz2k +zVfvxCUW6+kq2hYq6Uiy26UlJ0ZfFVOWGXqjVSFILdeUtLwqJ3bf X-Gm-Gg: ASbGncu19BZdfy/YwKl8fRzGWQqEs35ClPCIsZS+2kDfRqBcsX7dU5ZBPAYWwGWOq9q IeovqqvyIvRcj0iF+wPiCTIJrOfrfy1jSvcOlgPQSwbuTmKMd0PHW6LxbJIWPTnNSdImjVCdzmp kn4u+jZUQUo66tJ0zif12bri2/qmeHrJnG/SFncEt3nZ4Sny/MuBighweTwDQ9x0EyeZdagbtRn pGmSDxwK0W1bWFRvz7T6iVvmS0JCKVRV/LF0YC4ZhvdUz/dAJjNKzQh/uLHmIuvAc3MQAvS33b5 +tQGBbUkqnUq/4Qpuv1rlJpCKhPZjrP2oo6okiDLbC3hXDbgOIUylFTLHzChk3udmdc7AbfDcvP R/4CshQeWnO4jN16XUa3mFe9YgFATi+0gw9FxTGY= X-Received: by 2002:a05:6000:1448:b0:3a3:7115:5e7a with SMTP id ffacd0b85a97d-3a4cb4835a8mr11371979f8f.42.1748421826093; Wed, 28 May 2025 01:43:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHW8fgePprjWQ0SikFa0/kkHRhuTBh5M5voJblZk/AKTkR/vAV3gBwh3Cco4fQgXFPQf7qyQ== X-Received: by 2002:a05:6000:1448:b0:3a3:7115:5e7a with SMTP id ffacd0b85a97d-3a4cb4835a8mr11371959f8f.42.1748421825708; Wed, 28 May 2025 01:43:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36? (p200300d82f30ec008f7e58a4ebf06a36.dip0.t-ipconnect.de. [2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4507253bebdsm10618585e9.4.2025.05.28.01.43.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 01:43:44 -0700 (PDT) Message-ID: <3016b046-c76f-4e58-9503-33606613e2f5@redhat.com> Date: Wed, 28 May 2025 10:43:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/contig_alloc: fix alloc_contig_range when __GFP_COMP and order < MAX_ORDER To: Andrew Morton , Jinjiang Tu Cc: Zi Yan , yuzhao@google.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250421013620.459740-1-tujinjiang@huawei.com> <0a6fa00f-0e48-4101-b2ad-23c9a964b740@redhat.com> <5CD028AA-64B7-4A93-8679-AAC5869B8C15@nvidia.com> <0b4308e5-97ed-4a82-ac8c-a9061cb4d5f0@redhat.com> <4023fc44-aafb-1895-e6db-b27f11ddc7cc@huawei.com> <20250527191948.2ffdc5d432dbacedeb473965@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250527191948.2ffdc5d432dbacedeb473965@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QyV-tiTtyWfDW8YRjkNI9vC6xpbIULEjs6lQXlfDSpM_1748421826 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8375B40007 X-Stat-Signature: dcfubc3p6bs7siepmpas1c1ejxyxnhet X-Rspam-User: X-HE-Tag: 1748421829-320964 X-HE-Meta: U2FsdGVkX1+SBTAeyPCKfDjCCd11tjZQFD+m1N67t8EoSvel9Ua4OOAB9xJrHyh7CAajTXEmaqTuC6cC1J65wUCh+M88p6whCsytu1GzgOLScLwj920AlMrk2wtg9F/K9Z43MJurDdkyC7ECVykza0OdTHBKeZKfY7vCRBy94YmoSgKqUInHjL1uULXxA8bKvIvpEZBwaTmRB2vQnLqRfOgY+yFBmR8gANRp/BmQp2kJBlRs3OJcY3P4rznwjZwY4U5BbwfMvV/2KUUDzudMLY06MrxkeSR4dfKwdnfhc2e+myhBIQ4imfq57kWysIW7WVxVj1hBqUXnd0E5jK65v3cRk78iCbpA951y1d9N6GcYccNKrp18CyBxrYPY0iNCsmkbn/uOCiP2j0THQWl1/HCNaTSu272uE8xnHkJ+ZgJ0Jpi3qbSOxhube000yy88AYkVf6HLf68eY6XwmIOjcKExG49dSNSDkXCtvuuQ6nKQSbJme8I2sECeKkPokJjUVB37vBdYbX/AMZY6gwMXmzp3AMO9tWZGr+c433bcaT8FYLsMhNILxMLXJxHHHNxIEzv5EpugDJraZkCyTDRId0qqkBapgyYL7bcKCAlj5JccGFgcW41qi89xwihnn5/tDqDYKs3/wjBzz1vKQcR67XXewJlCbtCnEsdClGCVoNAvevjFvF8mcyLHv1W0XyczjH3DPtu1SciPl+BFmcSJwOUFRBvJGCMny0Yyzk8IsQ30GLrnuUZRQtDUmzkpRGmV0Nr7UdETr4pSfs1YNzxXcL9oCgOOPLy1g442wHDv1KdU6HAglRWs2G2MCpKUcoU6l2suFTowLzvDI0DE8zAMwvTz3lyfa4HeTBiXU4gt+svwTzI9/dw+RjJk9PHhOWhd5VicYu7uPnJ8xeAriIxmMiJiiYhEzMwlGKm/qr6hvOaFxrliYMgIL9ZA9Re7o39eYcuIyjVPvSP7rWLSoRt Bnguj67f LvCr5cbopLVqt4R0ijWJgRX1em3w7BuA1pI7cQtzbyOaB7MNmmoxeDQuFxYBU/pOG8PG8g/owameuZZPOIe2M+ieMB1JOrKj/+Ly83y5sXpQEvFPrUFI19l5JqE8NDpYUcDeXC97Qer8rmV1uV8Edm+tfGYv6+udYrjGW7VVpHAunVXFKQa6SedElIGdfA6K8xaMGHHcbLL+m9H8GGCJ/T0RooUvCBBFllFRurimO1DzI+DaxdiEsjnbyZa32GOWqfOgMijlC1gQSyTMG+K6ujHIjczIG9FSp/mGSMIwGsegHoA9NI/7GWdTqrHfh4a4qpHa+6Gcy0IMthWuKl4p3jmTSy0+b11hNu7tXL5PQt93VC+6Hei6pvEPuQdVL7GLsoSGTTzYzxPmYABMmhRvzsBvY18dvfqWPdMD1iHjwmu8Dq9YDCOrZ+efaFLAfmVFmxN20brwzXZFw8O2dyCEHkWHFfBEBWSPybReFdFJmyLc7UfSSaSFY0J4ZBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.05.25 04:19, Andrew Morton wrote: > On Mon, 12 May 2025 09:13:31 +0800 Jinjiang Tu wrote: > >> >>>> >>>> The change below makes the code cleaner. Acked-by: Zi Yan >>>> >>> >>> Jinjiang, can you integrate that into your patch and resend? >> >> Sorry for late reply. I will do it today. >> > > As far as I know, this is still pending. The patch does address a > WARN() and it's cc:stable, so it's rather important. > > I'll move the v2 patch back into mm-new and shall keep it there to > remind me to bug people about it ;) > > > David (and everyone!), please don't be afraid to grab someone else's > patch, apply changes and send it in. Stuff happens, and doing this is well > within accepted processes. I would usually do that if (a) there would be a reproducer that I can test with and (b) I would find some spare time. Given that I don't consider this urgent (no in-tree user ...), I would hope that the original submitter can just ... send a properly tested patch that includes review feedback. Maybe best to drop this patch for now completely. In that case, I might just send a patch to fail any non-aligned / too small GFP_COMP allocation early, instead of adding support for it. -- Cheers, David / dhildenb