From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639E1C433E1 for ; Mon, 24 Aug 2020 23:16:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B6B5720656 for ; Mon, 24 Aug 2020 23:16:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6B5720656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 225626B0074; Mon, 24 Aug 2020 19:16:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D77B900005; Mon, 24 Aug 2020 19:16:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EC808D0003; Mon, 24 Aug 2020 19:16:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id EA3156B0074 for ; Mon, 24 Aug 2020 19:16:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1084181AEF1D for ; Mon, 24 Aug 2020 23:16:17 +0000 (UTC) X-FDA: 77187022794.09.swing28_1c00c5727057 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 909A5180AD817 for ; Mon, 24 Aug 2020 23:16:17 +0000 (UTC) X-HE-Tag: swing28_1c00c5727057 X-Filterd-Recvd-Size: 2705 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Aug 2020 23:16:16 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01355;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0U6mPOyb_1598310966; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U6mPOyb_1598310966) by smtp.aliyun-inc.com(127.0.0.1); Tue, 25 Aug 2020 07:16:11 +0800 Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged To: Stephen Rothwell , Michal Hocko Cc: Qian Cai , akpm@linux-foundation.org, Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org References: <1597144232-11370-1-git-send-email-alex.shi@linux.alibaba.com> <20200820145850.GA4622@lca.pw> <20200824145201.GB4337@lca.pw> <20200824151045.GC3415@dhcp22.suse.cz> <20200825090054.3c5dd68a@canb.auug.org.au> From: Alex Shi Message-ID: <3003ffb6-f527-ae33-60f2-50cd25316fdd@linux.alibaba.com> Date: Tue, 25 Aug 2020 07:14:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200825090054.3c5dd68a@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: 909A5180AD817 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/8/25 =E4=B8=8A=E5=8D=887:00, Stephen Rothwell =E5=86=99=E9= =81=93: >>>> This will trigger, =20 >>> Andrew, Stephen, can you drop this series for now? I did manage to tr= igger this >>> warning on all arches, powerpc, x86 and arm64 (below). =20 >> Yes, I do agree. See http://lkml.kernel.org/r/20200824151013.GB3415@dh= cp22.suse.cz > OK, I have removed the following from linux-next for today: >=20 > c443db77c9f3 ("mm/thp: narrow lru locking") > 18bafefba73d ("mm/thp: remove code path which never got into") > 5fb6c0683017 ("mm/thp: clean up lru_add_page_tail") > 9d1d568727a8 ("mm/thp: move lru_add_page_tail func to huge_memory.c") > 47eb331560ff ("mm/memcg: bail out early from swap accounting when mem= cg is disabled") > 4b0d99a64d78 ("mm/memcg: warning on !memcg after readahead page charg= ed") The first patch 4b0d99a64d78 ("mm/memcg: warning on !memcg after readahea= d page charged") reveals the hugetlb out of lru on some unexpected path. At least comments= are helpful. All other are good and functional. Thanks Alex