From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9AEFCD1284 for ; Tue, 2 Apr 2024 08:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70F2A6B0092; Tue, 2 Apr 2024 04:32:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BEBA6B0093; Tue, 2 Apr 2024 04:32:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 586736B0095; Tue, 2 Apr 2024 04:32:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 401DC6B0092 for ; Tue, 2 Apr 2024 04:32:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F041C120516 for ; Tue, 2 Apr 2024 08:32:53 +0000 (UTC) X-FDA: 81963926226.04.E136764 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 13F8E1A000D for ; Tue, 2 Apr 2024 08:32:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FzsIc/2t"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712046772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+sMESiDiEk7NQ7Fx8r6KwgieS1M3kfYVE+bjq9Liog=; b=N92CcZbIFV4ht1MqGcoakD1KsAMNhrrSsEJiiOHky301lZfAkzaRUxvSMoruWYDYgkOR3H eYM4KuuQdfhGnd+esHMLnqyEMG0AsiGk33MA1JyBom/AXj+g5RI3RMasj2SJzdOYWPOh7v DLiL18qqvrlbVKbMkbUrQvAUWTbMaik= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FzsIc/2t"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712046772; a=rsa-sha256; cv=none; b=6LLAFQAHIQ5J/2H2Uz34OrnSWUpxgwTvmrM46sKeA5T/RGRZRRJB2bC7PNLw15VbM/K4bS 4CiQ0WXAx16dzKNXCe+0dWi4j0nDoc1jJO+9VYK6tAjeGNOmdi5YLZaBqwljOJe+WPKDGg 3HSd5j0/9JEqwglH2sJNH7JJCj25lRU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712046771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y+sMESiDiEk7NQ7Fx8r6KwgieS1M3kfYVE+bjq9Liog=; b=FzsIc/2tj8j5mb1ls42Lh9l6ewaBsQVJFLtRoA0eQzyI580YRtDInN+sRF+pUIu4ljRPH0 UxQygn8nMcpiFsk57OlDtlPHPTnkwh4nKffxn5uyas7PM37m7Qs6/ruD6tU1ohhPwFYKa7 WD/8iRWjD3KVLKunpXwx4Tto6dDnQvY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-5i1cRV1HP_OxdCzQ3Kdzqw-1; Tue, 02 Apr 2024 04:32:47 -0400 X-MC-Unique: 5i1cRV1HP_OxdCzQ3Kdzqw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F188879844; Tue, 2 Apr 2024 08:32:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66B2CC1576F; Tue, 2 Apr 2024 08:32:42 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240401135351.GD26556@kernel.org> References: <20240401135351.GD26556@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-27-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/26] netfs, afs: Use writeback retry to deal with alternate keys MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3002685.1712046757.1@warthog.procyon.org.uk> Date: Tue, 02 Apr 2024 09:32:37 +0100 Message-ID: <3002686.1712046757@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 13F8E1A000D X-Stat-Signature: k5pgtxy16dz8otckrrfac67cegpgrr7b X-Rspam-User: X-HE-Tag: 1712046771-137884 X-HE-Meta: U2FsdGVkX1/RsWghUU8TVmNENx/zXf5L/gYga3Exxlw69AOLJfQd2c8UwhwFkQK/Ww8wx7oEUrwH4tzkw/AKm0xgpZbDcvxJIa+Tp2nN9+KCmLaH0PfNZVvCLm+JVzA/+JQ8fL2+3iC2oFcOxfn2L1LQ2oS2/vOmoIhNupTGaW4Mb/yJo7OLd+Yq9GgWyoMReGBDtZ2A6lD+4F2UiRsoMNh1Caw2SB34tEZi2Fm6kscZWA0gag6figeBUjPZlAuft4CQZGR8o9VNt2/pQJ2D7Fj5mNQ8n0MkZc08eIby7hNEx9yAVxte4/Uk66BqfzksDbSensgqxZ/Lh2o2cikr+d+QsW9YZiTPJP484kKh0MujA76aog/iWIY6WZZOvFeJVsG6WAWOenczPXvX2YYU1fdJDPZh55QqXXMcqEMmZICwYb+a53HbCGRhiKqfY1N4mK2pTpxkFsW1qrSSvCII4SiT8VwOcRyK81C2aiJIG8GNzoOtJ/Sb0ESYCHc7rH1m19VYPf9zJaGNpFZ8EJz1zV2u2PdHGSsyeTHWcfYptXGw+pm5oT/uU2ZsYxLV3EFqmyks2t4+YR7SYNNowGdClqFuy6e8FtVemo4CHDBYseEyz13tdkmVIADYB9/N/Wtye/5Xu6F2Eaf3fdIDPk/NFGBcAzFP4LKjxlT86R8kC00v0GfNT3K78kh/xOVirreToTsO+QDln4SLKPZc11cPwwx02zki7NExLcKB6hWcy3LtaWc5JYK8Xs1e/W9zXI5y45FTBNJDtl1zuKh2QRKkPQWhKppt3nBRmMPTeccdes98P2Ic+RJxjsG6AuqQchL2meHhiWxSz66ZPbrIWTmoJJfIWAAnKgdYUfCbz3my84AyAYS7NbysTtSyKrk1GU6xIZn8UkIslSzsNIMKdHCbso7egETVoEn6VDQnIb6z5fVPozpAj7bsnku9vwr43s5tFL06XuhRF2pgR8yHtS+ ozujlhXQ z2kovbzVDUdGl1l2TwyUZFRrgM9EUNhnYfy3OOxZdva+1nOUoFNb63kCr9zruIQ80tBWoNLitHB9EcasAy080qfJYgZn0nFsgLVYolDbRdtmLK9XWbzooVZZoWLgCitOdixUnExFbaZx7kzxlsB8UWaNpcB4Dr2Y/uUyWAYwqiuJIT1ugr23dxg8cUe8AUh8MFtAqw4vgYxHUa9gKCS8NgAWx0p7Bn6M2T8OqniFztcR2CzRjk9jTEe8Wyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Simon Horman wrote: > > + op->store.size = len, > > nit: this is probably more intuitively written using len; I'm not sure it makes a difference, but switching 'size' to 'len' in kafs is a separate thing that doesn't need to be part of this patchset. David