From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: lorenzo.stoakes@oracle.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/testing/vma: add missing function stub
Date: Wed, 28 May 2025 10:40:34 -0400 [thread overview]
Message-ID: <2zr7b6mawiqiwczuyfolwdqw662binsxjnwv7ou25reqvbmhqv@5ije6q7b4mom> (raw)
In-Reply-To: <20250528-fix-vma-test-v1-1-c8a5f533b38f@oracle.com>
* Lorenzo Stoakes via B4 Relay <devnull+lorenzo.stoakes.oracle.com@kernel.org> [250528 10:16]:
> From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> The hugetlb fix introduced in commit ee40c9920ac2 ("mm: fix copy_vma()
> error handling for hugetlb mappings") mistakenly did not provide a stub for
> the VMA userland testing, which results in a compile error when trying to
> build this.
>
> Provide this stub to resolve the issue.
I need to be more careful in reviews for these things in the future.
LGTM.
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>
> ---
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> tools/testing/vma/vma_internal.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/testing/vma/vma_internal.h b/tools/testing/vma/vma_internal.h
> index f6e45e62da3a6ee007b7431573f27ef5c2533865..441feb21aa5a92b7edddb07258c7f368171de15b 100644
> --- a/tools/testing/vma/vma_internal.h
> +++ b/tools/testing/vma/vma_internal.h
> @@ -1461,4 +1461,9 @@ static inline int __call_mmap_prepare(struct file *file,
> return file->f_op->mmap_prepare(desc);
> }
>
> +static inline void fixup_hugetlb_reservations(struct vm_area_struct *vma)
> +{
> + (void)vma;
> +}
> +
> #endif /* __MM_VMA_INTERNAL_H */
>
> ---
> base-commit: 1637eadc7fdf2fa4069a149b1e836656a3b64150
> change-id: 20250528-fix-vma-test-57b138f28f46
>
> Best regards,
> --
> Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
>
next prev parent reply other threads:[~2025-05-28 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 14:15 Lorenzo Stoakes via B4 Relay
2025-05-28 14:40 ` Liam R. Howlett [this message]
2025-05-28 22:52 ` Andrew Morton
2025-05-29 5:39 ` Lorenzo Stoakes
2025-05-29 15:23 ` Andrew Morton
2025-05-29 8:39 ` Pedro Falcato
2025-05-30 5:15 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2zr7b6mawiqiwczuyfolwdqw662binsxjnwv7ou25reqvbmhqv@5ije6q7b4mom \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox