From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DE4C54749 for ; Wed, 28 Aug 2024 02:23:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0B16B0082; Tue, 27 Aug 2024 22:23:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B70B36B0083; Tue, 27 Aug 2024 22:23:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A383A6B0085; Tue, 27 Aug 2024 22:23:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84A0A6B0082 for ; Tue, 27 Aug 2024 22:23:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DD08C81C40 for ; Wed, 28 Aug 2024 02:23:21 +0000 (UTC) X-FDA: 82500057402.13.AA69532 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf20.hostedemail.com (Postfix) with ESMTP id ED3D81C000F for ; Wed, 28 Aug 2024 02:23:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MspHzbro; spf=pass (imf20.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724811714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xSbZj6mcZdBMGgsaki7D1+Lg/Lo1Q5717z2hfLufPhY=; b=7xXVTe1Lxjjvw7uwdPwgn2amhQRcqtDzSjy7FC5jQ1bnpo9RGgmC/DCmEhtiKNb99yscx/ fPD9eW5QOXLm6B8yRjxK+VUr1myX9fNHcHhGxzw1dce0yOVCngSUPZWc99mdWRyaAB0Z4B 1ySoxmAJfKzjd6z8Aq1vaKniYKIjPS0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724811714; a=rsa-sha256; cv=none; b=zArOo1O3t9/rns8hv1PjHhTXSXh8SAj226DeqFTYrkt0S899gzqwNDIard2Y0ixixW/P3Z Ig3b3fAGlklKqofwV+dhaPmfN5wuLcWJYcdjFFad6OrjS52VRdpCZsGtjpoJC0oxRWzSli vK2De5vRAHmqJlbZ4LQHwZ95UsDEsMI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MspHzbro; spf=pass (imf20.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 27 Aug 2024 22:23:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724811797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xSbZj6mcZdBMGgsaki7D1+Lg/Lo1Q5717z2hfLufPhY=; b=MspHzbroBjMVubn+/ib4e7AdGpv+8zuK+BOMmea9bbfBijnD0bQtFPYUBcmIHqmOAhlH4s LwC3FH/YryIf06cWHPKT4UTrhbPUX+tmcirTmcrsCTQ8y2WU0ijzH2kb4/+1fBoC33Brbs cN3LltJ/9kK5c91r++S7uBPyx615VaY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/10] shrinker debugging, .to_text() report (resend) Message-ID: <2zd3yfcglv3wf6vgjl4dxaeajrovoxeaca3gkyl6o6aj24syyd@5ghiokumyv4s> References: <20240824191020.3170516-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: ED3D81C000F X-Stat-Signature: s6bizddeowki1x88n1k8s7emsgpzhr7o X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724811799-898904 X-HE-Meta: U2FsdGVkX1+Wtqk+2Jv70g+ul2b49kZpPjB6jNZRYLWLzhuJSIxhzPp3VvHPBE7veUYIblIRsHZ+hLss6/PeCNBxYegcmr29KcaKlgFXRMAWLnqdUGL2NHg9UvSA/u2BYWMViPPLeQ2rjByPaX8zamN20AAbQRGOSMIQbkgqmldZg/e1k4qcIbeMSg4xzBGehEqouVeyaM0Nym/aXor4cdVtT4VJKG0tL3ZBUZCz8pmD02JQCaaU87mvR6d92WBwWuv79SfyeIuYieC4trlpVoKMyXzn68wnfzBvQGTs0IsK2m7NUBIY0ftnfcNv3fFNkGEJ2CQwCvrO1J13DJPFNJmnGnz8o8H+yIaWXec4A0OvsNvYHPFIzdHVD4wyJqQNbrTh9nDwffutlEZFvhjfksFPVfwt1aedWsdBBQqIHq9IVKHwXu18BJ9Ka4LE6n9GSyWlR4KXr4LaL5Q3fvL5K2NrCV1UL1q2tjV+UNm0lNaRuFkbu+jXRe3PmXv4iXTV1LgK70us6j0BWZKE1bhuHq3DF4JsggqN7IKq/7aToakMJy4a7BPH7fyTidFEhWkTIMyzd/YHZtHuXhr0Ah8c0m9sdT4gIDIGOXrxl3hzolXR017mp6cuE5+Y4ElgN6VuwjysiyLXEUm/8A8s9LeUcQxsQde8s3q9Iugm4cZZtv/LX4WQxqKe4/3cFVfieoCeCGo1tKTjFjgJGAzf6GJbp3dPAXLOt+A7u3+sLfrPyt0JSzarDpujCMvuWtH/XQ/fAch/Q1akvQurGcjZAKSCMkLhoyY1ERGKP98Dj+yktE9UQp1JJrRbYe5ZEmgHLVDIRgdi6tDhqbva5ywAzCBRPAP4A7IrmhsKPPyIETEYsAaJMmXl6Gvl98xRZT7CavyXn9NAXv8/3MuZwzKkzvLnvdEM5qvZ/ap2lq0p46gMDoRVlSZyYo1i8r54Y9PKeGTRWB5TcTYR2JBifBLjHkZ Emg9PTWR GSX1yydv63btvoMG05u0XlfZ7250zGkXL/0eCB49fTx3crElulUeobm2fTfi11Wz1USIJW3mfXUrXo8yCuQoXKFSJ5Rb4LQhFU6bZ9N3iCb/03igurEg32YNKMLQHsa84sN4pdU9a3CQLOaJIUsAPou3e74XGxxeNFMWWRrJgze0f9/H1fD2DrfKhI+KBru6SA0Yg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 11:51:34AM GMT, Dave Chinner wrote: > On Sat, Aug 24, 2024 at 03:10:07PM -0400, Kent Overstreet wrote: > > recently new OOMs have been cropping up, and reclaim is implicated, so > > I've had to dust off these patches. > > > > nothing significant has changed since the last time I posted, and they > > have been valuable - Dave, think we can get them in? > > You need to describe what this does. What does the output look like? > Where does it go (console, dmesg, etc). When is it called, etc. > Links to previous review threads so people can get back up to speed > on what was discussed last time and determine whether issues raised > were solved. A changelog since the last posting is helpful, too... Not much has changed since last posting, besides tweaking/improving counters... objects, requested to free, objects freed: so we can tell if a shrinker isn't freeing as requested last scanned and last freed are new - so we can tell if a shrinker's gotten stuck (perhaps it requires a lock that it isn't able to get) bcachefs shrinkers additionally have counters for every distinct reason an object wasn't freed - this has been quite useful in the past: BTW - the next thing I want to get done is adding an interface for shrinkers to report the amount of memory they own in bytes. This will greatly aid the show_mem report, so it can skip reporting on shrinkers entirely if they don't control much memory or pick a number to show more intelligently. It'll also let us finally fix the free command. root@moria-kvm:/sys/kernel/debug/shrinker$ cat 05baba83-05ef-4d71-be0e-121bdabfee36-btree_key_cache-43/report 05baba83-05ef-4d71-be0e-121bdabfee36-btree_key_cache objects: 122411 requested to free: 63 objects freed: 0 last scanned: 198 sec ago last freed: 42949578 sec ago ns per object freed: 0 keys: 129119 dirty: 6580 table size: 262144 shrinker: requested_to_free: 0 freed: 0 skipped_dirty: 21 skipped_accessed: 42 skipped_lock_fail: 0 pending: 114727 root@moria-kvm:/sys/kernel/debug/shrinker# cat sb-bcachefs-44/report sb-bcachefs objects: 1 requested to free: 0 objects freed: 0 last scanned: 42949693 sec ago last freed: 42949693 sec ago ns per object freed: 0 inodes: total 2 shrinkable 0 dentries: toal 2 shrinkbale 1