Re: [PATCH 6/6] kho/abi: add memblock ABI header

[Pratyush Yadav <pratyush@kernel.org>]

On Mon, Jan 05 2026, Mike Rapoport wrote:

> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> Introduce KHO ABI header describing preservation ABI for memblock's
> reserve_mem regions and link the relevant documentation to KHO docs.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
[...]
> + *	/ {
> + *		compatible = "memblock-v1";
> + *
> + *		n1 {
> + *			compatible = "reserve-mem-v1";
> + *			start = <0xc06b 0x4000000>;
> + *			size = <0x04 0x00>;
> + *		};
> + *	};
> + *
> + * Main memblock node (/):
> + *
> + *   - compatible: "memblock-v1"
> +
> + *     Identifies the overall memblock ABI version.
> + *
> + * reserved_mem node:
> + *   These nodes describe all reserve_mem regions.
> + *
> + *   - compatible: "reserve-mem-v1"
> + *
> + *     Identifies the ABI version of reserve_mem descriptions
> + *
> + *   - start: u64
> + *
> + *     Physical address of the reserved memory region.
> + *
> + *   - size: u64
> + *
> + *     size in bytes of the reserved memory region.

I think you should also mention that the name of the node is the name of
the map.

Other than this,

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

> + */
> +
> +/* Top level memblock FDT node name. */
> +#define MEMBLOCK_KHO_FDT "memblock"
> +
> +/* The compatible string for the memblock FDT root node. */
> +#define MEMBLOCK_KHO_NODE_COMPATIBLE "memblock-v1"
> +
> +/* The compatible string for the reserve_mem FDT nodes. */
> +#define RESERVE_MEM_KHO_NODE_COMPATIBLE "reserve-mem-v1"
> +
> +#endif /* _LINUX_KHO_ABI_MEMBLOCK_H */
[...]

-- 
Regards,
Pratyush Yadav