From: Pratyush Yadav <pratyush@kernel.org>
To: DaeMyung Kang <charsyam@gmail.com>
Cc: pasha.tatashin@soleen.com, rppt@kernel.org,
akpm@linux-foundation.org, pratyush@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memfd_luo: fix PFN conversion in retrieve cleanup
Date: Tue, 14 Apr 2026 10:49:56 +0000 [thread overview]
Message-ID: <2vxzeckh95pn.fsf@kernel.org> (raw)
In-Reply-To: <20260413162929.156163-1-charsyam@gmail.com> (DaeMyung Kang's message of "Tue, 14 Apr 2026 01:29:29 +0900")
Hi DaeMyung,
On Tue, Apr 14 2026, DaeMyung Kang wrote:
> memfd_luo_retrieve_folios()'s error-path cleanup loop passes the raw
> PFN to kho_restore_folio(), but the function expects a physical
> address. The two other call sites in the same file (the discard path
> and the main retrieve loop) correctly convert with PFN_PHYS() before
> calling. Without the conversion the cleanup operates on the wrong
> address and fails to release the folios that were preserved but not
> yet inserted into the address space, leaking them across the live
> update.
>
> Apply PFN_PHYS() to match the other call sites.
>
> Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd")
> Signed-off-by: DaeMyung Kang <charsyam@gmail.com>
Thanks, but this bug is also already fixed, by this patch [0].
[0] https://lore.kernel.org/linux-mm/20260326084727.118437-6-duanchenghao@kylinos.cn/
[...]
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2026-04-14 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 16:29 DaeMyung Kang
2026-04-14 10:49 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzeckh95pn.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=charsyam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox