From: Pratyush Yadav <pratyush@kernel.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] liveupdate: luo_file: remember retrieve() status
Date: Tue, 10 Feb 2026 14:31:34 +0100 [thread overview]
Message-ID: <2vxzbjhwu3m1.fsf@kernel.org> (raw)
In-Reply-To: <CA+CK2bC9WBdYoQfJXZs+K6DQjDkrGmppbevL18mJ=DhO0TkG1g@mail.gmail.com> (Pasha Tatashin's message of "Sat, 31 Jan 2026 10:31:38 -0500")
On Sat, Jan 31 2026, Pasha Tatashin wrote:
> On Mon, Jan 26, 2026 at 6:03 PM Pratyush Yadav <pratyush@kernel.org> wrote:
[...]
>> diff --git a/include/linux/liveupdate.h b/include/linux/liveupdate.h
>> index a7f6ee5b6771..a543a3a8e837 100644
>> --- a/include/linux/liveupdate.h
>> +++ b/include/linux/liveupdate.h
>> @@ -21,7 +21,10 @@ struct file;
>> * struct liveupdate_file_op_args - Arguments for file operation callbacks.
>> * @handler: The file handler being called.
>> * @retrieved: The retrieve status for the 'can_finish / finish'
>
> Rename retrieved to retrieve_sts
Will fix. Thanks.
>
>> - * operation.
>> + * operation. A value of 0 means the retrieve has not been
>> + * attempted, a positive value means the retrieve was
>> + * successful, and a negative value means the retrieve failed,
>> + * and the value is the error code of the call.
>> * @file: The file object. For retrieve: [OUT] The callback sets
>> * this to the new file. For other ops: [IN] The caller sets
>> * this to the file being operated on.
>> @@ -37,7 +40,7 @@ struct file;
>> */
>> struct liveupdate_file_op_args {
>> struct liveupdate_file_handler *handler;
>> - bool retrieved;
>> + bool retrieve_sts;
>> struct file *file;
>> u64 serialized_data;
>> void *private_data;
[...]
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2026-02-10 13:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 23:02 [PATCH 0/2] liveupdate: fixes in error handling Pratyush Yadav
2026-01-26 23:02 ` [PATCH 1/2] liveupdate: luo_file: do not clear serialized_data on unfreeze Pratyush Yadav
2026-01-28 11:19 ` Mike Rapoport
2026-01-30 18:56 ` Pratyush Yadav
2026-01-30 19:50 ` Andrew Morton
2026-02-02 11:14 ` Pratyush Yadav
2026-01-26 23:02 ` [PATCH 2/2] liveupdate: luo_file: remember retrieve() status Pratyush Yadav
2026-01-28 11:37 ` Mike Rapoport
2026-02-10 13:30 ` Pratyush Yadav
2026-01-31 15:31 ` Pasha Tatashin
2026-02-10 13:31 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzbjhwu3m1.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox