From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D35C369CB for ; Wed, 23 Apr 2025 21:10:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FD7C6B0005; Wed, 23 Apr 2025 17:10:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AC1E6B0007; Wed, 23 Apr 2025 17:10:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59AE66B0008; Wed, 23 Apr 2025 17:10:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3C7F26B0005 for ; Wed, 23 Apr 2025 17:10:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E2977C02FA for ; Wed, 23 Apr 2025 21:10:23 +0000 (UTC) X-FDA: 83366551926.20.A58403F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id 2118F40012 for ; Wed, 23 Apr 2025 21:10:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ik9JqqbE; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of alx@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745442622; a=rsa-sha256; cv=none; b=F2DHF8jTACuoom7tJfN78ZK7OxYr19W/c6a/c2EQA6Wz/dL5sZ6Ux6nyj0alSBtoco+VEO dpwoDdzkKAqq4FwCC++XXp65DcwQdYh3hzNDGqxoz4PNp6WB+LvXV8uB6jWaJNwKJ79WVx otZcZXZW6mC64kq1F01OdLHy7RXreR8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ik9JqqbE; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of alx@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745442622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K9C35tvL+dWu9roWsv0J/nH1VfLyu1KlSh16GkUZCyI=; b=aoL/Q/AShnMXfOy7xeZbYBSLUuQQhg/uOtwAvnKbqG7VBIFApeGWBFRKOK0eFUvzkMmjFz rWZM7svroKxC/Ss9uKGQCb2baqeMj+g7yG8Bkj8D4Z7PDIbuHIvMORKC+SSDedCynSPrnr 5fWdB6dnPp3nGZsMtv5KS4STeCz77cw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 711C74A36A; Wed, 23 Apr 2025 21:10:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1884C4CEEE; Wed, 23 Apr 2025 21:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745442620; bh=pdcKP2ZdNEo5goD00owMfeeneCDr1jDd3nY5bZmNhZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ik9JqqbEuNJiyD7CHdH7ItE3EEYhxMuJnq7vM3/UGOY/V9Tn+4wVYBkAmX2vUKBcq 6pSgDB6EpJLK6BFFZcyZ58XqzYELjsRahUD6HQBz8YvEUDdlstzLKGUvvcUK5k5BbU rcLjwgRN1U7O7gkHFCgwk4zFeTMat4tpbWkmznJmlN099hDYg3n8mO/zPV+DZ85XTw mr2D557TjZMF1KBnYN5wTTAthEOeec+38XiuhTcCDKhd9CEAf9ZcmgNzdtKRPcQCWO xCkPBl64ZwvQjM/cytA04nyXVw47BHygzHTo/foV7SqM9/fKL5BqX/+yt66wxTfK+c 659ZMZglfWJ+g== Date: Wed, 23 Apr 2025 23:10:15 +0200 From: Alejandro Colomar To: Suren Baghdasaryan Cc: aarcange@redhat.com, lorenzo.stoakes@oracle.com, david@redhat.com, peterx@redhat.com, lokeshgidra@google.com, linux-man@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/1] man/man2/ioctl_userfaultfd.2, UFFDIO_MOVE.2const: Add UFFDIO_MOVE page Message-ID: <2uffhjsbzq2hmgx5o5ac6u6ifi25nxhqy75irf7atjd6shctwg@eo7whozxpmqb> References: <20250423011203.2559210-1-surenb@google.com> <4xxeauieht3kdepkgsc73xroo42zkltepxpzce6yir2zouzr7w@tjp5t43tr7pk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6o674d26cf7mrwfa" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2118F40012 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: wy6qj1yjqr9shcn8wp843zc4fwkpcagu X-HE-Tag: 1745442621-107784 X-HE-Meta: U2FsdGVkX1/27NednmfFocjyfoYblisP8oDtfx1tIi1miSNiubyr1IFQ5ulC61nUQjPG7MRd1/Yd7jFYQEgKEV0REQkjVLmgxFzKG0c2nVSBpbji6mo07M6CSR73zfpAZBizxJ6PKDUQOKWwO53J9xG75F2Fdq4w0ApTmW5thZ9OmZQnJlzHTG6K4sqltie4RB/t1gwyZQEFYwWypoH2PZHbkQ3FC6XySy5BhJtdk6lvMCdKhgFAWYMdk4EFTE5lviEWcTuOXH10x0t7dBvOQZHo28WuBA4SWe3ldCZeOt5Xa2z1V6QftTE3c4lvcXdbt7T7S3u3SMtyQV5VgvAo10ieWNRyFq61PZjtZ4yO3IFdK1pv/CXvHXjpM58IPHD5EqPrW7k7sWI+DRZ3z4ihZpFEAL0HCiTRCGwseTxm2HpkDqMIKOSPLBO+WogFybdVmGwSXuBflp3Bjkq+tONOrHVATpWdZnQgYk4Fb+8gob52rmWEYTtBhPkt7aGk7aA4fWbHJiAI3LTWxjzAMzqFM5b0o3+g8C/CoS7Y0hn/PX2GB6BVSSA5ocSt5NxPbMeoIYZHff8wLJuf+v7b71rGmSMm/Cxz7ndUhcLi3NLqsu7uO45BQ2Fs4a0EXhCs1i0euuqgYUhrGha8JP9061m2I+Vz5ypYJAuqdLiaqz+pI0ONQVTd+XZ+g2pLeOKlrpvzHwm2Exs5JUTJyQUiNMhojrDLLlYB+QoD7Gf2y+p6rOrykPzoMxHhNP1rUSBgHr1BsXmCow2EgHMQlh9BUUezzMUgYPqcJfVkBK1UIQKZ43mG3uzCQxNGz1p6YLHK5jWqD+DXMqSYS7YxJSwJlCL88DyCGQHsBuMIBquagyaR7cAxZPLz169hBjw0eOBMyDMAN7A1FnvM1ZD9yiNASfEcSgP5ZgR3WUdNv1oLlC/yF+/t3z92g6Spfgpo3LSKXN1hoS869TcXsX8IQX9HGQY IOBmQZ0P I95D6RhKS4Wi6ILdcMjCK/M5MsvKfqexRW4c2d4dLbm/26Up+b/J3vDIqZK0nBzlbW2DTqs3YbnVcHIU8GPWH3+todeRY2wr7ErNBpzSVJenhlZDgYf4BeF3PzJvKsRijYFl0nQRYXIQ0q4lfkIN/v2BoBZbLhkzkJfodvjlMyuuuE3Zdl1tNtKtyTVLLzE+Uuu6yjq4e1C4b6RVl8yOyPeIHqqQ9tP5M+yPjadOkGOHHD2h77yJcYhqC3oSLIzN3OWIaDC7HZnmR89qCycJ1XH1PVOJLG9iJwkfv5KhO/b2hVV77z6ArGNcm0n3KNe7d7o5wSsaQhAsPjuhuFb5Tj2zzrc0Zlo5KpB9Vr1AjvzhWMiqzVljn7Z8fAhr57YVgAYosPQ8+DkoW4hZzSyygYNp5AawnhlRdZTp2EFlAS2SyxjvZn2AK4u5fh/5Bx7V86bsAhK5WG7ugTdo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --6o674d26cf7mrwfa Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: Suren Baghdasaryan Cc: aarcange@redhat.com, lorenzo.stoakes@oracle.com, david@redhat.com, peterx@redhat.com, lokeshgidra@google.com, linux-man@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/1] man/man2/ioctl_userfaultfd.2, UFFDIO_MOVE.2const: Add UFFDIO_MOVE page References: <20250423011203.2559210-1-surenb@google.com> <4xxeauieht3kdepkgsc73xroo42zkltepxpzce6yir2zouzr7w@tjp5t43tr7pk> MIME-Version: 1.0 In-Reply-To: Hi Suren, On Wed, Apr 23, 2025 at 12:55:41PM -0700, Suren Baghdasaryan wrote: > > > > +.B struct uffdio_move { > > > > +.BR " __u64 dst;" " /* Destination of move */" > > > > +.BR " __u64 src;" " /* Source of move */" > > > > +.BR " __u64 len;" " /* Number of bytes to move */" > > > > > > Are we in time to name this size instead of len? Length usually refe= rs > > > to the number of non-zero characters in a string, while size refers to > > > number of bytes in some object, which is more appropriate in these > > > cases. > > > > > > If this has already been released in the kernel, don't worry about it, > > > but if it hasn't, maybe we should call it size? >=20 > Sorry, it was released back in 6.8. Okay, no problem. > > > > +.P > > > > +The following value may be bitwise ORed in > > > > +.I mode > > > > > > Please use .mode instead of mode. That makes it more obvious that we= 're > > > talking about a struct member. I know most pages don't do this, but = I'm > > > planning a global change for consistency soon; since this page is new, > > > we can start clean and do it as > > > > > > .I .mode > > > > > > This is done in a few cases already in fanotify(7), for example. >=20 > Ack. I assume that should be done everywhere else. Yep. Have a lovely night! Alex --=20 --6o674d26cf7mrwfa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmgJVzAACgkQ64mZXMKQ wqlHJw//ebsaWn/y09CIPJybxyYKuDib7ZwG/FgRg2SEetBKrVWiYxuVZ9jM0HwK 22rKNXVJXtlFkP5MiBvtkC1u9avEwYonLf8/kbaAPdOwtlgQJlQF82Sm3jz1Q6wJ +XVmq2E4ZU5Hia5VIAM4C7AmS0qwRGT2udB4i0tdEcxFRdV5kziuNFqHKyLiMj2R aSUNENHlTfYw3K2Yvm6+HNe21GnwYqnKnjbFd8fEEtDx+HlO9zye2mf/D0Mg3LY/ 9UjCXepgWWmk6N5dzz5z9YIbUmKBQZZEFc27MRtYfmfOkZvH2pZFh7sSHxSC3CtH PFQ4tsDzL6YTc/Bru+3ZDM+LFp5XwgNxfxpD/aiwRldDJmS8mZM2m8xVMDxKSTz/ nqEWHVffLPZl1feE5DXkJiBmgG3TfP0NjRCnlELHf+cmt4L2Alm3a9kHl3siGnhA 4Cvl6WdHgYrmU6kgM37s1zjOgsO/QoNIh64fqD2MU1lmvewfcUiJftnmsjl8WPWM Sk6t7/z77vdO+qEmSPPfv1i/KfInatW+3Myi+Xx8DdjioZ8RdXjmq2hNRxbNmcML RMFQdLljeOpSQrCriIbJscDCg93Fa06YzLyD8Djmt5q+qFDlOghoBiyq/KlGZ10C Vz1V29ibMl90ptMbIPRf/e+MSdr8n1dONQvDNGth1i8AJTP48ns= =Es28 -----END PGP SIGNATURE----- --6o674d26cf7mrwfa--