Re: [PATCH 1/1] man/man2/ioctl_userfaultfd.2, UFFDIO_MOVE.2const: Add UFFDIO_MOVE page

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Hi Suren,

On Wed, Apr 23, 2025 at 12:55:41PM -0700, Suren Baghdasaryan wrote:
> > > > +.B struct uffdio_move {
> > > > +.BR "    __u64  dst;" "   /* Destination of move */"
> > > > +.BR "    __u64  src;" "   /* Source of move */"
> > > > +.BR "    __u64  len;" "   /* Number of bytes to move */"
> > >
> > > Are we in time to name this size instead of len?  Length usually refers
> > > to the number of non-zero characters in a string, while size refers to
> > > number of bytes in some object, which is more appropriate in these
> > > cases.
> > >
> > > If this has already been released in the kernel, don't worry about it,
> > > but if it hasn't, maybe we should call it size?
> 
> Sorry, it was released back in 6.8.

Okay, no problem.

> > > > +.P
> > > > +The following value may be bitwise ORed in
> > > > +.I mode
> > >
> > > Please use .mode instead of mode.  That makes it more obvious that we're
> > > talking about a struct member.  I know most pages don't do this, but I'm
> > > planning a global change for consistency soon; since this page is new,
> > > we can start clean and do it as
> > >
> > >         .I .mode
> > >
> > > This is done in a few cases already in fanotify(7), for example.
> 
> Ack. I assume that should be done everywhere else.

Yep.


Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]