From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E303BC369AB for ; Thu, 24 Apr 2025 16:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCB336B00A5; Thu, 24 Apr 2025 12:00:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B77CA6B00AB; Thu, 24 Apr 2025 12:00:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F2436B00AF; Thu, 24 Apr 2025 12:00:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7F4466B00A5 for ; Thu, 24 Apr 2025 12:00:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B40705E9BE for ; Thu, 24 Apr 2025 16:00:14 +0000 (UTC) X-FDA: 83369399148.24.007A167 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf10.hostedemail.com (Postfix) with ESMTP id D323EC0022 for ; Thu, 24 Apr 2025 16:00:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ATCUFXeC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745510413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tfFeYhapSdYD47FaFtGx4OWFt+GeEThh16hCxsDhCu4=; b=Z/ULCC9gHR1YnhIzNjzJQJ/08BfSSc8+fRp/Mjq2TeZ81tYsmFyjCzvPMgzWNKL3d8+Pm1 LMwniXURbzaayP79m+KU0lfyKtXBr28corJclVas5xfRbiOhbi6fIBcr29j0PUfoEQiKVG sxyJ5hjolzwGD6fvVVKxTgv8UqMhlIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745510413; a=rsa-sha256; cv=none; b=v1vMUl+HtNLBCXr3i1aHEBQAb0JsvUj3EWMui7KF1+3pKaAc2CuITFc+j6GiNdG4Hz/jUf 6BKEwAXAmgQURSMwtPW4WntdxO4IXTw2oRCiC16GAJaLk2dg9pXvIPGL3a2I2mZFH/7dLW uI2Nnl2qYh8qwNZBicHBkYP22stKZG4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ATCUFXeC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Thu, 24 Apr 2025 09:00:01 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745510409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tfFeYhapSdYD47FaFtGx4OWFt+GeEThh16hCxsDhCu4=; b=ATCUFXeCXCrRKWTChbKTH6WuHu0R5tnkFKBwadCsGgV77j6ZkKqSDe0jgQ/yQmQ79Ztmla MABvQr713842br1Ug5U2vuNJ0tvFs6CXjFiovr6hwukjE9D+WlpnWYGjmuF/KvikZkFzyU 3U6GPaaYNHbI0GjPY2FGBpfsKUTs2IM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Huan Yang Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Petr Mladek , Sebastian Andrzej Siewior , Francesco Valla , Huang Shijie , KP Singh , "Paul E. McKenney" , Rasmus Villemoes , "Uladzislau Rezki (Sony)" , Guo Weikang , Raul E Rangel , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Boqun Feng , Geert Uytterhoeven , Paul Moore , "Mike Rapoport (Microsoft)" , opensource.kernel@vivo.com Subject: Re: [PATCH v2 3/3] mm/memcg: introduce mem_cgroup_early_init Message-ID: <2u4vpqa6do7tgtukqb7orgxmlixguexsxilhnsiwv7atssnht4@o4cwziz26wrs> References: <20250424120937.96164-1-link@vivo.com> <20250424120937.96164-4-link@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424120937.96164-4-link@vivo.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D323EC0022 X-Rspam-User: X-Stat-Signature: yedhi5ntmsag31fw9ft3nd96h3haoht1 X-HE-Tag: 1745510412-925101 X-HE-Meta: U2FsdGVkX1/SjD+AoRIADQyNMlPPvC5NLg8NygD/e7WwxJwaeaJwE91aIJAqEVS5GKwFfXxFrcfwT1QurshnZzT1O/kNicLCK1Bpmqa0ghOSJFV/tigQyg2yX6jPVJbXOwLOUEhOAgqskCS4I+Fn75yg7fbAY4mtM7A6ue1wCSLqLFlbAruJ+k7HyAy/deaevv6k8YnuYoTDHqvuH3tXphy5ETWTG7bsZTn9CyXnMTXHEZtwdxY8OK/DNbHzftXfsqc2GDXCU526dunUfMlRiVQG6plPYDwE4DsylbjFnHRRqUkxdHIOvWqCNQBcvMgx0SIG8SnRUMuHzV6wHrnovr9KmxQ01OWGTV/xvnDQpTctYdxMl445blqkw2dNlNEeSnJ5Q7bwdNDuE/HGer0cZYI5M3lqAZaB5iCmFRG2FDUv/Hh4FaZQmH15Eo+E/VsZH+rV9DJaMbhbQrmeKgKuH+M23wtSouOuK21HSwYCZw0FSPT0pxHiWrLkjNhaiT9b3ODsh10jXUb4EfTKRqetqCC1RT4czFf0AZpSrQtP7O/jKzd1ON1Je9Y+ntcIjUkarCfY23FhOPhRwoVgGs43RIb9fJ/CKsZDcZQ7DJ80dxmPk8lljpv/IEt2WyFtf4QxFoGQzeazde/H+kAZKcmIVC3IH9MHhAXjQDp3yY0Jz7YO4QwFK4nw8l1QfLZE4liUbaPWI75momyy3/TMCaLJEX84a3Tg0evERPlPeTtRHzt4/bAmfltKnNseFyN2Jp7jW0Sismqju1OajvwVRAj2bYWAro4mbgOe+xnjmdC9qLLU771aBy3OOam1OZiUlnsLWfNySZGz3q7d6o1Yhb2vgpC9NjyH9qWKr3TmkvM0/x08NyElOe3CslJjT9TaVrQB3SnDWQtx859XQsP+2vrid6onmKwYZeaTMJLeJMPnQFx8U4ZQ7Fcm1IeMrqc58uDrjlwMnBQtNvn2JqNthF+ pr82nH+O XkMz8p6hcrvEkbuhhWS7BrLLL4wWzAhHH/nmrqxdc3httdGQznaoSqXKUdslYn5m6tGRD4QV1MnnVF9k2HZiTZ4s6vqpX2NgCrGGph61/f25HDO9695UiT/1BKGeKLjnqDBzzFqPtZNeEdijGuV126D0AehbJS5TLLbrw9dMfklGiDxP3XLMUIa8Yp38wS3Ird26BO+u3CJKIdQzWbG5sVAgNEqETtBMS+9Xi6RxAivQSRu0ts8+NyOVLUMHitHwK54ekjpsQaFZNSqqIVCPPk1tEdlllmyF4Cadi5zfNHghLixi7PLmBwI1z3shqYuHOaJ5o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 08:09:29PM +0800, Huan Yang wrote: > When cgroup_init() creates root_mem_cgroup through css_online callback, > some critical resources might not be fully initialized, forcing later > operations to perform conditional checks for resource availability. > > This patch introduces mem_cgroup_early_init() to address the init order, > it invoke before cgroup_init, so, compare mem_cgroup_init which invoked > by initcall, mem_cgroup_early_init can use to prepare some key resources > before root_mem_cgroup alloc. > > Signed-off-by: Huan Yang > Suggested-by: Shakeel Butt Please move this patch as the first patch of the series and also remove the "early" from the function name as it has a different meaning in the context of cgroup init. Something like either memcg_init() or memcg_kmem_caches_init().