From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53602C25B76 for ; Sat, 1 Jun 2024 06:43:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD9BD6B00A3; Sat, 1 Jun 2024 02:43:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D62396B00A4; Sat, 1 Jun 2024 02:43:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03EC6B00A5; Sat, 1 Jun 2024 02:43:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A1C386B00A3 for ; Sat, 1 Jun 2024 02:43:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 59DB81C2546 for ; Sat, 1 Jun 2024 06:43:07 +0000 (UTC) X-FDA: 82181377614.25.4D0F079 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf20.hostedemail.com (Postfix) with ESMTP id C1B501C000B for ; Sat, 1 Jun 2024 06:43:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JhwTnnh1; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717224183; a=rsa-sha256; cv=none; b=dHNqG7PRjM7mN77KHHvNc1e/yNVV7X5fMf8DEJvJJLcfiaXtwJIBDvN0rVZpQauTXdz6b4 lv/ou3UTU5MMy0bZuLy7Qyred0DWSJAoQRZv7kN21EgBZd7bDPUcT+RZFeRde62fdxXOx2 rvvF8f96GscVG9DVJ2D38z33IAj8Wkk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JhwTnnh1; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717224183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6g/m2Vo4ckbmL7s3SgPNBlQnNOpuP29aYJPD6t4ximg=; b=SyYdysNsP9DV4z9o4tIj5giNWx+hOC96KSz7Slitkm/55UichK3gxqPe12q5yPlmh+IuTF XgbFfdnhzUVwa3ShIWEZOO7CnxlOguptgsAzH7Sma3cvSpTt9NTpc5N3yoQMKZzbXUitR4 wUjUMUQ8U/6lBFG8NWPcXEk0nGURzuc= X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6g/m2Vo4ckbmL7s3SgPNBlQnNOpuP29aYJPD6t4ximg=; b=JhwTnnh1lqUzylBqkmbluW8TtdLppzH+OLMF3UnhBhc89uoOJ4FoB1XwXyRjTUIFovDeEA oR1VeeSkLb8HzsnUNOI/1tazE40iwXvaqnmWGuRnYNbpUwiPruV41EhHPKNnrDvQL4WY0Q 4WVV8sPX8eUKjOxBPtKLlrJ9dOj8kg0= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:42:55 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 02/14] mm: memcg: move soft limit reclaim code to memcontrol-v1.c Message-ID: <2tvwb3io7tynt32wwauyupbpq7kvmpkywm2e2z6v2npwmj2f7z@fydgwb7rsa6h> References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-3-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C1B501C000B X-Stat-Signature: 9u4u1dotrb7sof81rdq8mizu33sdu5uo X-HE-Tag: 1717224183-410250 X-HE-Meta: U2FsdGVkX19jAWy8GNYUf1L6R9DvwkUQijwJGox8qB25DLKITmk3ugdGGu1KYyT/mvlFwo9rovv1bIehtDQ+PKuq7xT4A8Qj8PnKHNuASC7kdmPyWlv1tyxttRdba48pLHdiXoRb/OhW0/LFnJwTDtWCUGxvxmiA7pJoSZmkThGVZtMiIi8tookttJoxjdrQ5Dq57a0h781vbfdSTUW3jzQeyP8+fnxulXHs0EC+shonydK9leuY66udKViDF+Rs5qXpLCFzL3Q9lP8zUE+OVaj41ilpr4o9D9izisT9LlBz/c0Or/Z32tJYtY1uQmiXg7XAjbcAq4JM17Q65gTfo6EJbwfDVYPVphNu6VpX+eHBGZsqc1RM60OEpbK6Fmny8/Oe10PufIKWzjVjaWzywRwz2zXDMbeYKgo5+Y5UOWkkR7hsHvUTchA/CxTFmkUmr1xvIev7md172Xsz1dZSj0buQd5o4UyyoXulTzolm/pPM/AxasmpRbJ8yMj2J0yHM7SWzkIksJe+mAEx3lQn51clhp4Lcte7TssMvtqwLimuY20bQ7+XrDWTMQYo+BfUfhF9wDETpGl32AD7dlbBDIuF3PsIaHZtn79HOuEtAF4Kt5SLvjibTfA6d4VvMU+QDp3v3AL2ECXXPdq1QXvenrc5Puw5x3bu80AXNRruFvbY1NPE/DBcPB3UvFj+iZBCv6JZA1MHwR6Ln/rjdn4k/SFUGEUaN4XWznKRsY+4xOeeC4GWLWE5hUHK1Zy5Lut0FEeJh0Z/3xM/xXsF6/dal9/BUmCwj2Wt1DwxXxrFeYB/mhUn0hONMQATaX82gjofIww0Q2NsLkZrVq8Nhn6zurdrUrRlpKyJAHEQBzRwEKk9tqh5JMALd4NgBWZdN0mI/b37YVvlEeRKtCEC+VTz1jBQ9lxbjN6MqWR2U2OfAt03Drq2ZJ8eT7qLyFRu/YC1Dp2GiKZ0xsKE8GLZtkL upNMHfDw uaJyBXVnqdY+4ZcJuvcYiBv2ZfwNwv2ohUmOKzo7Eo4OviJUIJgBM1H1b371Uz2zLyYuqOlyHGJSvMXbHtdD7bONuxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 01:20:54PM GMT, Roman Gushchin wrote: > Soft limits are cgroup v1-specific and are not supported by cgroup v2, > so let's move the corresponding code into memcontrol-v1.c. > > Aside from simple moving the code, this commits introduces a trivial > memcg1_soft_limit_reset() function to reset soft limits and also > moves the global soft limit tree initialization code into a new > memcg1_init() function. > > It also moves corresponding declarations shared between memcontrol.c > and memcontrol-v1.c into mm/memcontrol-v1.h. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt