From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7318EC3DA4A for ; Thu, 8 Aug 2024 16:54:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4D66B007B; Thu, 8 Aug 2024 12:54:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3D226B0082; Thu, 8 Aug 2024 12:54:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8F9C6B0083; Thu, 8 Aug 2024 12:54:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 973846B007B for ; Thu, 8 Aug 2024 12:54:05 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 086CE1C38DE for ; Thu, 8 Aug 2024 16:54:05 +0000 (UTC) X-FDA: 82429675650.30.261FC88 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf17.hostedemail.com (Postfix) with ESMTP id 80B2840024 for ; Thu, 8 Aug 2024 16:54:01 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=j80TubDx; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=cdSADMWK; spf=pass (imf17.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723136032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XuzRLbTiIUB+mm0J0FGm2Y6H15xSZhDOMF612qxaWFo=; b=wCaSPBlBnGbKbLqxskl6XpunPU08lfTw+B5CgV5HSYNjwEzZzNHtTGSMqhvvgNRGWJ7eBF 2rrt5k9lxJKqYq+x65TlIucaea34r5U/fjNKi4LacaqLciu9vqjFeY0shNx9WLcHypE1r2 DUh4WJnraLbY4nn2PArY7uSOuak8zQ8= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=j80TubDx; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=cdSADMWK; spf=pass (imf17.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723136032; a=rsa-sha256; cv=pass; b=Y+PeIQbcROspxSKiQZ/uY0gprwt4NVA2J3r0kWV/URW0UlKd/7rrJ3u14FwiWHeUkf8Cug x/Vi3x3w1lVo654aCjPa8JuHQLAvOwgcXYsPzmPp0wjXlIYH6Q2aeeU3m16WbvqMdGnXF/ jZu9MfZqdkTYOrwaXJ74oL1fvqrLhCA= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 478AMYh0024559; Thu, 8 Aug 2024 16:54:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=XuzRLbTiIUB+mm0 J0FGm2Y6H15xSZhDOMF612qxaWFo=; b=j80TubDx0AbhnfsZgJAtw0i1IE8C18A ARdfj0FbJG03uGH7umBVFCVly7XnAt7j1+XaxqAqzGEMQiEY8CTkxxE8PswCWSEW UnuU7eAvzg9C8rUnUiBLrvZJmOwjqGXB6p3+7p1DucZ4ngvxoh+PxPqtFsavHIh7 1TfDbHxhgxee+s/NNWitV9qJUW++w5sdY2iZcfOPrj3TvTzanGkuQYl+26FNgSxn o8SCC6G1ArpCKYEfv1lVEAtVOL6oW1n6uXhTRXRDtjHps490bKcmmzyybAJdGDe6 +GhHCvgXQZDiMux1dFb/0XeOlrLXpmC462RpEbFXhbMJE+54KeUBGVA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40sayea6g0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Aug 2024 16:53:59 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 478G1792039413; Thu, 8 Aug 2024 16:53:59 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2044.outbound.protection.outlook.com [104.47.70.44]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40sb0cwh1p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Aug 2024 16:53:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V+p22lqt9Tz0vk14z039POhU7W0uC1SCPnCoWNCKHB0KCcznw1v3I6PV+30z68vYVAS1zPd1Jp1DDKwq54d6NF89Hy4OVfBImygHvjsVuVFwMiqNU9NMy8W3jY5pzTATn8HqoRGgpQXGNILbw/YTEkAG4MfsizrCEJi6LCCSQmqQmgfk74jkKK2MCVneKpCCUA8/lNVjNj9CvAU/2n9xRCQXwTbNJx4h1waTvZZFW9ah9vzlIWy3iLlz5BwFxGSkJNWM3NjjVWBl9NWRPv5I/RLeOsfWiBO0jAgjo+4G4JeB3jwhiOZvGIQbqYymzOwmUStFk16JFIYjZ3NpEN178g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XuzRLbTiIUB+mm0J0FGm2Y6H15xSZhDOMF612qxaWFo=; b=AzCqaH4AjDTby5n1cuMwXv183mIhJP1OLLkCko5j4womX9AKj0rZ6cyTGE90lnn4/ui/ck4uBC72vw5oudKaGQTXm6yx0JvENUw13mVThKLvhLAbwPRscyHWuit5DI+N4n1Wu3Ha/7SWUGhEY6jZzDEVXOCorGqkY/96CAQj2ud7QI3hLvKRw6LeBHfxIrqyPHwDFCg6pxPnZYTbKiXRejbIEln88d/JyJtK5+J+97llsRHhPKW63eqF8qiZlYhgHeIQPbUyRA1zfU1Sj43mArh1USyn+Ib0T3ZHnpsJ9YQfBZRA7aerJzagh7w+0w2Y1GTVxULWfLrcVd+jbdff0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XuzRLbTiIUB+mm0J0FGm2Y6H15xSZhDOMF612qxaWFo=; b=cdSADMWKV8J9exMdtv5RD7g59xjlPs1tYGEJ+uP3QsBsnMkp24R1EV7RCi5Ka0Z5FlEDkMRj3Yraf3faT5LT7SIKfHzuuXV538D0thBVms52tPvkHr2asRIYB5TbAZHs1iwk+ENDqgrDU+jXP0oX+0yd2vBjUSSzTRNPuGf+Rjw= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by SJ0PR10MB5742.namprd10.prod.outlook.com (2603:10b6:a03:3ed::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Thu, 8 Aug 2024 16:53:57 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7849.008; Thu, 8 Aug 2024 16:53:57 +0000 Date: Thu, 8 Aug 2024 12:53:55 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH] maple_tree: use xa_is_internal() for better reading Message-ID: <2owp7odt4ryc42fzbtbxw6fg7zrkfi5g7tptyy4hgjpzqsthy2@46gbf75ibmz6> Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20240808043717.10930-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240808043717.10930-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0032.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fe::24) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|SJ0PR10MB5742:EE_ X-MS-Office365-Filtering-Correlation-Id: 33c1d4cc-2452-4b46-c6b8-08dcb7cab192 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mKD70UeG2/Fx9xvgTUJLlwMJHbzLs0EMt1/e4+qWzqbBz5eTTlPbhMaGCaLi?= =?us-ascii?Q?RQDw1tnjnmwBoOvPpxzg9Oy31X4P733RSgrtawkiO0VZsCr3XaeO0BubBAQr?= =?us-ascii?Q?cgq2nfMWHdu70OfrxLhrd7X8IKGpaikErJTQz8dMncA27l4lnEm9RUrmnZdS?= =?us-ascii?Q?SdispcB96q/UykK3EeidqUMv0TaK0p3YJnZPRMwl0s0K6GavuHF/uWP9+r7K?= =?us-ascii?Q?Fx6RNr2xD1s9X62D1SiAFz7tVm0bAp6iVK3DHnli1ZzeeHU5UcgkUOfQLoF6?= =?us-ascii?Q?GpUjQCk6eQLyTZg7YQEBJq7P8G0fMMfGOwYXGymnq0Zl4spYXoabvMsu88wM?= =?us-ascii?Q?PSrgsSOQpOvJPefjiAeBQH0HEy3gfAffrj8cTEvjVk/b9HB1LvGQmwqeOY/q?= =?us-ascii?Q?PNeFWmb4FmELPIapyOZq1reINhoaEzQav21zgKH3Xr+mKlWhw4SA2wT9i2fu?= =?us-ascii?Q?MXcUPDrk5WUmHgTHi51kvJQFag8bQPI/znGjxkPbWRE/q0vKgGQIzdAvkSaB?= =?us-ascii?Q?3K0Wp/PLC/oc3FggseC3zJAHHaXPq6mWBjHCislnZU0/DFAMtMHWrtItV5UC?= =?us-ascii?Q?z4d1t+IFIigYxlq5BXz4MKQIuz7c94lB46/Vy3VkUWRYi8Vg60Na6WfrG0xU?= =?us-ascii?Q?7+Knzk8FZYgnIIVtJ/f2Rq4JtSKADp2+HRQE/uYqG9R0mv0cUOGKXp7uE1RP?= =?us-ascii?Q?PVUKZ5IENeg/pj7MPH3UDXsCG0c0OWc8ZPAxtREnCdHfOm1r8Y7XgR2SGc8F?= =?us-ascii?Q?R6DF3WOB2Dm0lYlPS3zVJzIaunYMhGVcELPqEaLQW4/BANUJ14YPtK0N70xf?= =?us-ascii?Q?DcPINb8IoKN3qcKJgkQ4Mvn5vb772zPEtRDm2fVEheaX/nNn336JTgoTLdfj?= =?us-ascii?Q?3n8vv6Z5YwPLoAPTaau57xCXExbH9//mztFVxW1W630ykmII4+u+UErUFWOR?= =?us-ascii?Q?WRLoGqb+AeTD4BGmZmGiiis17kb+aKq78vjV8JUtKut8e+lvDNkypLYGhKBB?= =?us-ascii?Q?ZWEfdpMHSJLUZ1+maEoFZNEOK9waUwBQ9MEWab/mlbVXQjQoFrJd1waPfIz/?= =?us-ascii?Q?aRDGrHCfyajU+ymAduVLhcJkQNf1tohanX7qGdWy7BE9wpF0N0scnd5H4caJ?= =?us-ascii?Q?wokYnfZPNAPE9OtheVuTkD+GRHHJxexXrmhEGmxy4+K2eAOrA5ngcye8OAPA?= =?us-ascii?Q?NkYPm1GmATHS6U4YCjcYo7s7JqxU//Ctb9VMkG+7K+XDlGtcS1xnyGGbeRoQ?= =?us-ascii?Q?0nfuE4PMDgFLgJvnGUs+bgLixezwjUuHIutHBUWS64eCmd+te0S5skrbY3CW?= =?us-ascii?Q?O8P3scMQYK6pjzNcUtI4VWSsyXA4Co2Bh+sTLsBDWcAfvA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C0sLx5fpi4zaHMU+6sdtL0ry6AFeGwpShvWOttQsMxZC0DwqcjXYuuWbYqno?= =?us-ascii?Q?eVJ/dO3llw6m7084fOTbFbBHoFp/STWVpAa74nWgTjrKnbEvSNNu5Z+uYqO2?= =?us-ascii?Q?6iU5CdipPzrLAdCiwQ9EOlCGBZNdIjxvQRYKRafKHdFtFApwiOwUGNPolcZH?= =?us-ascii?Q?iEZbLqvdDhXRHq9ck2XmyT8lcRtbwuO5lEYIVD9I7fJIG3ESYyrg6D3f2r5m?= =?us-ascii?Q?y636dlcHtHQ/ZGP4GsFR4RVa4h91D9D4DDkd8oA2a9DJx96owNVbXeocTusE?= =?us-ascii?Q?xjmrNvTqXVEXy85ompCoKn4h0K7456mFi/in867Cj0e8beYqtqc2YiZM8ueP?= =?us-ascii?Q?+QF2jnAThwqR0tgsWZhcj0NcjHNNxJw/qu+XriDBPVjgP81P/up46oFje/SR?= =?us-ascii?Q?hmDKxwBgp6tZ7AQMspdmp497Nsy2GwI59S87WndRtlf1DchOm5sUKZmiPuD9?= =?us-ascii?Q?HGXLeljhZ7b8OmX8S38POgLqQ8OCpEB0EoEdmlpOtGk5YUkBppjDRloHApnD?= =?us-ascii?Q?FkMpHSkr9UTQBhLcwT1k5R/BvgMkazcWe955gf1waZL3i6cVHhmcxZyUdEG7?= =?us-ascii?Q?tOco1xuWEPgYkTK+AyV7wucvKhYuwBpZz/wHlkhnN2FtG9IDEejrCyJRFNRs?= =?us-ascii?Q?XXeoFmVJHpdCodjX76uzXQqWqfKggSRpfSAwdDZWoZtkZ0RiPpxSTqdMKYT3?= =?us-ascii?Q?IQUN2fH6GeQQy/NN7nEqVRcRz9klYUyrzH0NFwagz38CO3coQ+FCusG3Vl8M?= =?us-ascii?Q?fSKX0FRD8U4XSoqTLakf+mck3DCMwqIbx6Tn75xLIrewL7YKZkSKuUM1Ysiq?= =?us-ascii?Q?a3n5TxzcmrFVbsI1fMh2vvxV+KMWBdC7jUDquTPOAVlzjaUlk+KtbvxJIDmt?= =?us-ascii?Q?TWg+mWAi5zbWY6rH34mwmZa2/sxvhwB8GHxJfraGJ3gXdKjs1jUeHGB+9Rbu?= =?us-ascii?Q?IBtzWfYLcVXmPzn/ZBjlcYHUBoOoDHlHvhcZlUFw002dhKb740OVhPAHNvYl?= =?us-ascii?Q?o8iVaZYYJ4ssFMk1YqDXY5P8FyKFVA1yRvn4+t1dduDA63/Kuc2Q4ZLW0bAf?= =?us-ascii?Q?oLBwa2GoHZqQNUUWmcQOGQGVnovqQykYBDFo5eT32frpA4KfOCRseGcBI02x?= =?us-ascii?Q?MSofoHDNRDoqLctGMNV4rThSIQ44AU1+TBmX+3lqCLtabNx/Tk3ii7pop7qc?= =?us-ascii?Q?y5C3UgqQuvr2lBqdSf+dRs7iXcr3hmQsXexKNxA464y0S8Qb4FowsajANIZT?= =?us-ascii?Q?En+geojIrfeaGldeIA6YjSvhVRQBdDsX34ht0loG0Mw60WWE2yuuTxRK3k62?= =?us-ascii?Q?wCUsy5FOTBGdaRmXgcMjUS8ApLlsskGEdqbshFVS054HjpMNzRG74K9dLAvb?= =?us-ascii?Q?QEeSR09V9oJE76e1HY7r4gSHUV281QdMPmI08qJlu5juXw7T774Wq6C9BCGe?= =?us-ascii?Q?V6CzWYyO4xxolDbJPc6/1QF5oQ4nY/sTONCMvQQZiZBWmSSAD2QUsaAZxJIU?= =?us-ascii?Q?GbBsLWtV3OTBoG8K2eyhKnOGJXzPO/YB1uPs3zTgR3yK1j3XAallqq9FZ9DW?= =?us-ascii?Q?NRPqr5B06x51ZEU9xh2qO3JjXpbWIcA0hpP4DkX6?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: k9UsbstljnZsN2/eh/xlr3ruo7RwYpqpgbOI5AD0YbRqjTCBnB81bGjfj33S1I8CwBAbrDb1EOXKRALCeRdDS8hzDA8p1sAi5AdbbkSFATYzoSZwkpCHqJup6EpWCDxusDqEN6Y7Pcpv1AiV7OWCosseCa0fLB6pP3IsL961MUaX/OVrRiOfWtXFvu2KLtjLnIi1fo0fhlOhG4ej/VR/8ZRgWMIpN774Gcm+uael0wxwm0dq37lqSXe3Bzqf/UWuNJV2LA62wSCWEhVy8CAt0lhnLkJPz2Tz9o9kjxqifc2S9cAKYMEL7F0h1oAzyUMLrE9138rjE46qwSo19yDl9SmBS77ZsZXgW/H+RPm5S3awSFNC0Wpa6mwsXMb82ncUDrCTvUBDvt8a9YABWddcAWvhjzLNnFvAczp2r5Mgof7PG30WAOCiJTy3kgg2XeLpGiVJoEfUWHvRNWomojdD/v1SqFg6N+jlWXn8Csci22da3T0E1xB1+/+JpoRS65ExrkAMD+oGe3Kh32+ZEJyJ1OjGqGs9m/U2jHH5jgwoj3YQ+/MkRd57GfQp0uTEQqQ6mL3X5HjFel6QbWtciELKUg21VWA26hH8JfwHmJosrzo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33c1d4cc-2452-4b46-c6b8-08dcb7cab192 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2024 16:53:57.1819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sWYp7P2RYLDOYZYhUUpXWlNqs69r1FceZLJb+FJ2rEsBdeSDolPaX1u+FopPk+ci6V0hVZxH0Bo3DMwKrBC4Rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5742 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-08_17,2024-08-07_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408080120 X-Proofpoint-ORIG-GUID: sAC_BH9V38r7h4n-YndDZPXnlwmYHdOY X-Proofpoint-GUID: sAC_BH9V38r7h4n-YndDZPXnlwmYHdOY X-Rspam-User: X-Stat-Signature: husgkmddmm8wj765t5bcikz663fpqk3k X-Rspamd-Queue-Id: 80B2840024 X-Rspamd-Server: rspam11 X-HE-Tag: 1723136041-164767 X-HE-Meta: U2FsdGVkX1873xf3cGF30LBwPySqadjduJnr+/oiLz6+7M3s7Un7t7W2IFEe19Ti9JXFhQMevZyx2T1T2BZzw3eOxs0IWlStHFY2Bwe4Xrgw+Tr/uqIMRvzoU6/29v4wR+XbA6g1qCmicdGS2+YZqjP5P1tSPWxjnW0v+NlbBJWicxDFZEgyyc0TaciP7VVUK3rU8HN56Myo82dhGuYTFNKneB91VYqaGr+MBXu8BuNm7kx/ZvyHVH+30b3XC9Zjf9Dj/2msLwmIo6uBvTnPOHBWHhqXJbHRFE6LL0qpptb+0sPBrotjUQqP5XiOfEQLdbU6sqYWdVotnSNCJdMS9JYO6qInTpNEz7a7bUhqulTcirB9dwDH8ST1sbcNqlyMiMA8ZDU7HSQVTmOhZi2Stw3R6tw9scZtKJCIeDA4gHdXgKybM2TFtFYM5IzDdbnAQIfbmVm7bK8SLfUZH/yTwhuI9FEkoqfKzGfdB3CZ+bFDWX2RWfsGzQf9xbkNRIU+7q9YgOEpZVjTGKuSFNxxY8r9HFh+M99RGBdz7skBYxpyhZGbwpawPT61Hfmt42sXsZl52xvu/bTRJ3EeLFt6IFjRdn/VgC/O4hcxGm0x7/uvfgo6K5G2uFa7P9dlfg1hQhNpUCFLZU1+wxj7OfL4Q2DxN3eqBq8ejk5fsY0K+i8hfpz1SwoC7g3/SI+oMzYAf0QPlGBm9zqC6eXvhGt++WvpWHb2rAqBEp/0eIwWG0xy3iP9lvTu2lW/2Ax72nlnbVgYLI3wEtjH4rZqJMJVrOcNkYqpc+nhwhtWoem8IHieiVI/9EjkaHCSmClGXwBtsJyXXnMIRUi9dfoIcu2kkjPMSkyJtUJ/+o/B0N00fjqgq+qjTZsxmLnp4xbj7I5THVyj0g8OCuq8jKEltmI9jtzDQ8VctNhNGlijv8gAFB8WmWqnDcmJ4E17AxQJ4g3dC09qsMk/9MoDER2FyD1 LHShTgOe S5PIa1c+2i0eweZgYS8+4Y4W9aq66OPOu5e55PXmsn6ABJhOVicAcoDmU1GPS00uYMTeJsu1UrPeEAmkbEq9LWE9UDepuUEhxTDSMcZaiyKZxug5VN6TqvtKGHpc9uTK2kOuam4FIAsaGj3xFmGbuSoC7Bz0ONQiZuzM0mbUTxkP/iioCzTkxewCdeUqjDgIOLWprrLUl+jIfgJwvSyn28h/yeAJzsCFjIWjhpb9EJjDOhLc5h+JBX7mi8eVCgCAsBmTjKqPdPccP8DSelIaOLiyqi1SRoi12QkQxMNJw0q2Ev4igv8acHzv5eJsjDEIOi183u3fGLFdfcCI1/gU55gCDb65uYF86ETDSQN9QTeaB2tQvZZP93xqcW5VV7oTxatNYko7hegG0HSQEeIhCDU3PQ+X5z+obqc7OEHe71FHiDSS3L+M0d8WcVI/0ipWaPkDkTt6tXrymwKKMyzsmVyTfrxJcJ0zkpFCmqNuSO2iZPguJoFECEPHnfiMMP244jYVO+tPPNuMtF/wLai45Rvt//KDvSM1Eq9DrvVHpWqloYilDqf1UucQ6DEj63yfHxp3epZCjF1/Q6QAuZzaNEumIIpuILp52azwc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [240808 00:38]: > If entry is a special case, we need to expand root to store it. This > case is exactly the case of xa_is_internal(). > > Let's use xa_is_internal() for the check, which is friendly for > audience. Nack This check is to see if it will be detected as an internal node - this much is correct. But changing the check to use this function reads far worse than what exists today. If you look at the code below, it seems to indicate that the internal entry is being inserted into the tree - but it's not an internal entry, it's an entry that would be detected as an internal entry. This is not friendlier for the audience, it's confusing. > > Signed-off-by: Wei Yang > --- > lib/maple_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index aa3a5df15b8e..d39b0bceb802 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -3515,7 +3515,7 @@ static inline void mas_store_root(struct ma_state *mas, void *entry) > { > if (likely((mas->last != 0) || (mas->index != 0))) > mas_root_expand(mas, entry); > - else if (((unsigned long) (entry) & 3) == 2) > + else if (xa_is_internal(entry)) > mas_root_expand(mas, entry); > else { > rcu_assign_pointer(mas->tree->ma_root, entry); > -- > 2.34.1 >