From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375CCD2E001 for ; Wed, 23 Oct 2024 00:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C23346B00BB; Tue, 22 Oct 2024 20:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4136B00BC; Tue, 22 Oct 2024 20:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75EE6B00BD; Tue, 22 Oct 2024 20:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 857936B00BB for ; Tue, 22 Oct 2024 20:58:10 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1ABF1C065F for ; Wed, 23 Oct 2024 00:57:52 +0000 (UTC) X-FDA: 82703055120.05.C541BFA Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf12.hostedemail.com (Postfix) with ESMTP id B8F7E40003 for ; Wed, 23 Oct 2024 00:58:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=URhTwlBv; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729645037; a=rsa-sha256; cv=none; b=Mj2Gh5BBDxSn4hcztTOJVkTA3sbjc3qOrMGLwXZL9KVXu4aoIxriRvnmK+ggmnX+N8+hNf M4QhMAPhSCLRn2VFqxVEuLZrfVLrAY/bcvYqYfRkwrtU/n+bDlgoUbBlYHs4kgcdhZMuVD 6GFT6BLhEZ2n4VwEogvyb936gacEb4E= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=URhTwlBv; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729645037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RIhG4Nub/27TKSQIaMpr/BUBLqYCkfJlFCf4zPWje50=; b=RMh2/vuyCMZGzTjLZqBXpmM+P4FmJVjyXlXnZYBgtXGFGT83fFwPRJo1bxTKL57mrEPDT/ FQEpG3tWul/jT8klBgn5rslp4Thp1pSZeWEuIpxKmiXeeij7eX2TLiU5189hGZZ1Bs0w5d spDcqxOFmTefVvRiXbdi9cXRN26/FCg= Date: Tue, 22 Oct 2024 17:57:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729645086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RIhG4Nub/27TKSQIaMpr/BUBLqYCkfJlFCf4zPWje50=; b=URhTwlBv44lgRGyh4PCa8XtKj0YbC/9GMp4Cs2Eq5+MLAoj/HIcKsgYcsjq8+8tQxrs4EA WmOP81M2GcKuRaiatrkfiMYjUVIXH3CvYDCExbPIGMBdx1cY8o3eL9NP130p1oSF5pLR73 UVWAOkWj+CVAKyqKDO5RNgSsCbGoYOQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Martin KaFai Lau Cc: bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Kui-Feng Lee , kernel-team@meta.com, linux-mm@kvack.org Subject: Re: [PATCH v5 bpf-next 06/12] bpf: Add uptr support in the map_value of the task local storage. Message-ID: <2ngvjjbgow7bhsr5bpcyosxrzkbaux6mrvtvh2ru6wrzujtoki@7vpyhef5vux5> References: <20241015005008.767267-1-martin.lau@linux.dev> <20241015005008.767267-7-martin.lau@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: B8F7E40003 X-Rspamd-Server: rspam01 X-Stat-Signature: pwdtb93qpe79e9amedwweeyem7opnhpb X-HE-Tag: 1729645080-762131 X-HE-Meta: U2FsdGVkX18MQXQmQpYKlM7DXKjt5lj2XjeIkcZjnlXBQ4zdlT5WcPZbyxmC9VetcTavUW8Ri8NRKcrJLyWBYZyYKX1Qg9pbhAx0j45OeeYn2PwOdMlzQjcqfPBpIhqxB0ZSmFrKAk7h3zlrWX9/PiQtLam20tfc1jYpKSP0aNzEogLQgUe9NLmdh47nvcojhrcNghic7CD4jwihG6Gz1erlqZsyZwjJm0ExktBDpnflts2IAbkO3Ba1W7jdBhCeiyP5GFZ6rKq8+zPFRW8Qi2I7U9AZFjOE9e9guoVExj+h7t/leZlSsmOs+7FWUuBJliqP1+P6TqLm1bUlG8+KfzC2Xda1eao/beKaXB1M+WZNkl/NULO7uZDgCmnGpLIosye/IZAIn21OUhsYoAA2lLFerDuYQ133FVlyq9lm92ujqksyEVQgJh85+KPzYKPyX8RfDtYt058RKialIDPU8nnWYxKkLQlsheZ9iDLNPcnUaoNy0OAA+H0wczftkFnjsKe+RIXHDMuxbhEZ4XRuTwGwEpUP/qOxfFrFCRqmNspSGGzpuYVS8+8OFz17grUnKaBmF0iS3QeBpC/6QVTJMD3/dnzHq2ydoHuTExaRm8Xhfi2bIk0fnuOeK1JhdS1fWurp8s9f0R+l3RW782WRvr03siuqo71klngckd+BA73Hc++2wFx0DwMZ51CgsYk7pYcoW6pXqb/AkZX1bn8swlXYP1896sJniCNIY0JAJ78xNn8rm2Yj1BmfqZ0LVuPgpcEpXb1iTyRuuTGmooZDjooBm5BvqVUxGNaChNZaN1Fi5FIgngA1EPu/5OMqidtKEdEaNHase0mtPJiNLwTIaMSbm0JzT7gjB+p2lYADKb8EyJ8s+YpxB7ixITaZT3Wjlpo+1BesrtGWhlmOk7Qa3KsA/FvzxE1Vc4Iw7TdShmVVKiZ19v+5la2a5sVJi6cXu73Gth6mgw32izfG3b/ l+V4xP7g 26/lOBsN4U++OjRyylScSrwwNoBYkzZrDskJxwDEg3OCwbsj1oM7O72+xrECnJ/XvmhKntguA4AdYMVxn7WCINbkv681R/xRIYl+Fq6rN/dYQd0Q56eBMc//ZlgCnM3fClCaIzptRnGN+50alxv0BBYQpWFvIxjbTaudpxPeOiGLzmg0MFVQZo53NpBk5xJSN4xJUiYdRzZuQg+QyF73Li255deMkYiH4xBSAWZ/7eufTa6K0WjSn8VKdt2m1vfyBRuz++2EsWOrx6FxVgwjwnNtx39DWHc9KhUeQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 22, 2024 at 04:07:50PM GMT, Shakeel Butt wrote: > On Mon, Oct 14, 2024 at 05:49:56PM GMT, Martin KaFai Lau wrote: > > From: Martin KaFai Lau [...] > > + > > + err = pin_user_pages_fast(start, 1, FOLL_LONGTERM | FOLL_WRITE, &page); > > + if (err != 1) > > + goto unpin_all; > > + > > + *uptr_addr = page_address(page) + offset_in_page(start); > > Please use kmap(page) instead of page_address(page) and then you will > need to kunmap(kptr) on the unpin side. > This is needed only if you plan to support your feature for HIGHMEM kernels though. Otherwise you can error out for PageHighMem(page).