From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAB1C4332F for ; Sat, 29 Jan 2022 02:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D81D16B00C8; Fri, 28 Jan 2022 21:08:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D31646B00CB; Fri, 28 Jan 2022 21:08:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD2116B00CE; Fri, 28 Jan 2022 21:08:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id AAC5E6B00C8 for ; Fri, 28 Jan 2022 21:08:54 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 565928122838 for ; Sat, 29 Jan 2022 02:08:54 +0000 (UTC) X-FDA: 79081691388.18.35E5E2C Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf28.hostedemail.com (Postfix) with ESMTP id E9454C000F for ; Sat, 29 Jan 2022 02:08:53 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id z131so6787884pgz.12 for ; Fri, 28 Jan 2022 18:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=T5QP4rvsRHAf+k4UZm2ZD9yCitHTNkLO/bReAgS58JA=; b=XAOWparngd+vugNg20ipC1UryGHyoDbb93LFWA3GAFshr/ySrpNgjy0YOa40n9uwOX WFvwAfWyH7B9cVgYfjMdVfb3iLcrz8k/YZWWydMwq6lbhcUXm6H7YI2fLqPQzu0LljS0 HwRJ7P9DlLHm6QhpbU2EHskMMeLlmRBr76/x6yXh9DTtzluYrXFy7PnSX8DNU1CImkL+ X0htmpI8WoVMCogsmB98RJp1JgZPoTeUo+F3NM3XumyarJwpbqeTiP6vixyLsd/oIMRR w+ATpPW1aeFeIBZyNpc6itk7eg8dZVW2MnD2sPCqcLtismpsUxcQUdVBSVcGnZMbSR/U o6GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=T5QP4rvsRHAf+k4UZm2ZD9yCitHTNkLO/bReAgS58JA=; b=l5wdKVk3J17CFqvvVdaH2Wpiifpdx8DoWpZmDz56dLFaaruHyug5kAsc9eVPH8xNQh 8YfFQ7JdHBOsvlLwnX48qkSj7jq70uuuECTmSrhCbBs2tmcNF4u9iDQJpYAl620FH3ne yBWCnbnXj63JvjWnpjMZwWr8zf3YqpNBay687xCmdIBrmSBttlTKlgIgz00DJBK1g4Cq +0jeFDZCNx5gsaYm+GrVjQuPRrhh6QjayemFP5Qm8blUBSbSYIP2jlwlu4es2n96kd6b y73BFxlKum6GXaaoaV2flsb4CXAGbSGvTcu5a5GXv6YpKpxPMuQp3kIkemJP/fGwGfQG Ukag== X-Gm-Message-State: AOAM532Xphzg3gZrgyaFoEbInqZKrQCWd26uSXBKidXj7cPZN59bZ3oo 4GDroZVE/VhEU6Vmn0RnRoI= X-Google-Smtp-Source: ABdhPJylW7PZ+KYCbUQHk3BPPrL/0h1TQWt6TeoocnKqbSzNdvVTRyzsyZG6F3MSn8uf/GMqJ2XH/w== X-Received: by 2002:a63:6586:: with SMTP id z128mr8857019pgb.103.1643422132798; Fri, 28 Jan 2022 18:08:52 -0800 (PST) Received: from [10.1.1.24] (222-155-5-102-adsl.sparkbb.co.nz. [222.155.5.102]) by smtp.gmail.com with ESMTPSA id s2sm23087045pgf.56.2022.01.28.18.08.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jan 2022 18:08:52 -0800 (PST) Subject: Re: [PATCH] m68k: mm: Remove check for VM_IO to fix deferred I/O To: Finn Thain References: <20220128173006.1713210-1-geert@linux-m68k.org> <4d65d2e1-5fb3-456-3cc5-fbd3167d06c@linux-m68k.org> Cc: Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Andrew Morton , linux-mm@kvack.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Michael Schmitz Message-ID: <2ff869af-87a5-898c-b863-18e48527464b@gmail.com> Date: Sat, 29 Jan 2022 15:08:46 +1300 User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <4d65d2e1-5fb3-456-3cc5-fbd3167d06c@linux-m68k.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E9454C000F X-Rspam-User: nil Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XAOWparn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of schmitzmic@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=schmitzmic@gmail.com X-Stat-Signature: tj9gz6j8az5ak7ityyjhrg3pb5zggnee X-HE-Tag: 1643422133-395995 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000260, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Finn, Am 29.01.2022 um 12:55 schrieb Finn Thain: > On Sat, 29 Jan 2022, Michael Schmitz wrote: > >> Hi Geert, >> >> for hwregs_present(), the exception fixup will handle any access error >> (through send_fault_sig()), so this should continue to work. >> >> Why the special handling of VM_IO pages? Maybe hp300 had marked all IO >> register pages VM_IO to distinguish IO faults from VM faults... >> >> The only other area I can imagine this might have an impact is the Mac's >> pseudo-DMA - FInn might want to give this some testing. >> > > mac_scsi.c and mac_esp.c don't use ioremap(). They rely on head.S: > > mmu_map_eq #0x50000000,#0x03000000,%d3 > > Having said that, I will run some tests if you still think it necessary. No need for test then, thanks! Cheers, Michael