From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF254C25B76 for ; Mon, 3 Jun 2024 07:46:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4923D6B0098; Mon, 3 Jun 2024 03:46:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 443456B009A; Mon, 3 Jun 2024 03:46:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BBC16B009B; Mon, 3 Jun 2024 03:46:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0EF5B6B0098 for ; Mon, 3 Jun 2024 03:46:08 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8456EA1C60 for ; Mon, 3 Jun 2024 07:46:07 +0000 (UTC) X-FDA: 82188793974.26.EAB3697 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 2EB5C140003 for ; Mon, 3 Jun 2024 07:46:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t25W15xE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=T+be8l7H; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t25W15xE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=T+be8l7H; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717400765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ppjcw+ey9UBAAWa6TUuEs/1kMnYQaEpiNxwsiWo2PPg=; b=Kl+wicVf4JPpTFSENqpQg3+6sjEPqDKxY9qqfptvzCRxeYT2/Tjcniw2gKfb0koo93sU45 rgbADbg7qHX6ujEVhMRiNzOT2MPDew26cQFgvro+kNKInCvwZCYrk1xYLiiCsz3P+5Q5aa AyWNE4IsWejGzfx2Xl0CPzSUWtGGim8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t25W15xE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=T+be8l7H; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t25W15xE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=T+be8l7H; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717400765; a=rsa-sha256; cv=none; b=xOdLoZDJ+hOm7u5DlGljCikZEtgF4AN4P6obqBa0l+DyvkcKixAsA6cWGc+2mlNRArkzgf MuMrbyFkzUpO8bdohDlS47BkJZ3iRN552nbxrNHo+v7guyhWaA6SWaBUU0Z5/9KO3vo+Vo cMX2r1DPCmU1QQhWRjq6BNUFPumcnDY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5C20522196; Mon, 3 Jun 2024 07:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717400763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ppjcw+ey9UBAAWa6TUuEs/1kMnYQaEpiNxwsiWo2PPg=; b=t25W15xEW3ID4KWRgnM3+SMY43dWJxhiHe/yMP4eaV0xupcaZBE44g6mxnUz74OiEOQFGg w8hfZ1d1l/lbGYq1zY9XtRLyRLUV40pLlQ2VC3cWXiwEP4MZHWRFDP5nTUuEKInEsKzCAu +VaWoNdB/8uYlmCK0Y68hwvrMzOvmTM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717400763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ppjcw+ey9UBAAWa6TUuEs/1kMnYQaEpiNxwsiWo2PPg=; b=T+be8l7HJtjZsshSs1YB++h6HHENRFrfLr3DOttTfA4+sTYCriWkGzhE/oYHbCcJ/N0v+I sp40xEa9P31TZPDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717400763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ppjcw+ey9UBAAWa6TUuEs/1kMnYQaEpiNxwsiWo2PPg=; b=t25W15xEW3ID4KWRgnM3+SMY43dWJxhiHe/yMP4eaV0xupcaZBE44g6mxnUz74OiEOQFGg w8hfZ1d1l/lbGYq1zY9XtRLyRLUV40pLlQ2VC3cWXiwEP4MZHWRFDP5nTUuEKInEsKzCAu +VaWoNdB/8uYlmCK0Y68hwvrMzOvmTM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717400763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ppjcw+ey9UBAAWa6TUuEs/1kMnYQaEpiNxwsiWo2PPg=; b=T+be8l7HJtjZsshSs1YB++h6HHENRFrfLr3DOttTfA4+sTYCriWkGzhE/oYHbCcJ/N0v+I sp40xEa9P31TZPDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3F726139CB; Mon, 3 Jun 2024 07:46:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eRkHD7t0XWa5XgAAD6G6ig (envelope-from ); Mon, 03 Jun 2024 07:46:03 +0000 Message-ID: <2ff52c5e-4b6b-4b3d-9047-f00967315d3e@suse.cz> Date: Mon, 3 Jun 2024 09:46:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] slab: check the return value of check_bytes_and_report() To: Chengming Zhou , "Christoph Lameter (Ampere)" Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> <20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev> <4e4d45b5-c684-2d93-49d2-b179a088c2d5@gentwo.org> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2EB5C140003 X-Stat-Signature: dhpdjfp8htd9b53x3sx41gtojq49hrys X-HE-Tag: 1717400764-408637 X-HE-Meta: U2FsdGVkX18rpW+j8pSI3tQmrJ/nfEGryNLp/+wpzlOXtUxrhXsHiVvGM781BSVkdH9tMGFj80PD2TsPhkTe+ZatHyGg25a8tPTqorAmwcMxeOkaDlv8hjnK6f/lSr2UFGrqlIHVKITLhOmBAAnpyofj3aZBQH7lx+BFy9qb9dM99+jsSfLptx8muEB3kqAAPMadTBzNlXs+vzkJq8NvH8KGw0t92h5X8n8j5IegUr0ly4FiPWKA7cGe/1GrUjpKCoxgcrKACCzNzXE25Upmu1zvedcUOnvUHLOFO54ZnAc80NKiMwAf7ZiEs7eIx3t3G9EDiHpLf3fvcJ0cOF8BNf7DOIIAjzyv7butQifpoFEm0sxE9gy2wfU1Ln6mj2k6xGkk06zfPRnM+WfPqz7xdBmKZe8ClBE4mOUoGkIvNp//LUWc7GIj3ezBdLueBVvExinff4G+lFo8xIrChBJGnN06PuJ9Ny4W9Dd31RxKLu4lgXrcpRTkPGkRrPofV9dKlMLjHVxAr8uI6yleCxe2iY/jQ/I3ZjBFuz+T0YfqQjbATkSATuZycpOdw5NgZhgrKmSeVV21vXSU5o9aSRlSvbGWlgduRhdR89FDx6Fpye+OcmYioZ0Vn0PY2jvnglMTRsvy7PxKNsFurUWfemeWitcmUiiY4FdHsjCAkpDcesM4phlnEKCpoMlsvH/So7HxH/ck/3cWC271utb6rVkEuekrpmUQdjSBd7jmmS9Qzruw7hAioibarLfZtJyuv5eEMh8CNBumoLzhlHCrOT4PRSnxqXZlUh0IYqxNNyfESIehTqXJwLB3u9WyzCU2eznPVos8nZS3KH/s0UPdTE31sU4KdGgdtSlndtMsao9hWaR2t+GlppEHdG3o0cv3SVny8x/H1j9oEKD7VK+GAbyMfkfguvVamDVWhNlN+cjRwIFjIC4paSLzsRtVlOffABHy9G0FOpcEi4MqaX4mJfk bjF2fyRD NnsI7PiBWfI/5zWuiHjenTEKPt22QoVUlB6EGi6nic1yX/edbSsvpM6VSuNBW5IrwknbN2JL1gCNJ465ipjOm0Tnc41aFjehFnnEsVHSZl9LTX+dkN9uSaKGbfgH+AV+W1yZXp32dy8ZPQ3+sSz7/qOLTbmJWp+asR8JhQWZDfSl+kDQxDeTUi1GKB9ov8knymhk5IABBskjYeZnG1GGH9iBIeqa5U4F1joAFwnoY5MhWQ2Z9gkvGq/RSwl/porUEGMTyq6F6u+qFKimDRZRqkno3cG5QnUPOV7lbiIrOxxHkKYqxSD4YqTTeSTFfHfx6o73LjL/KhWhuzp6CllfmHGt4153opgFQRAUE6Ve3VlrhUtczNxFrO4FhS+uJlU8mD2TPB+061fEQioqhpkh/do2OGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 10:31 AM, Chengming Zhou wrote: > On 2024/5/30 23:20, Christoph Lameter (Ampere) wrote: >> On Tue, 28 May 2024, Chengming Zhou wrote: >> >>> diff --git a/mm/slub.c b/mm/slub.c >>> index 0809760cf789..de57512734ac 100644 >>> --- a/mm/slub.c >>> +++ b/mm/slub.c >>> @@ -1324,9 +1324,10 @@ static int check_object(struct kmem_cache *s, struct slab *slab, >>>         } >>>     } else { >>>         if ((s->flags & SLAB_POISON) && s->object_size < s->inuse) { >>> -            check_bytes_and_report(s, slab, p, "Alignment padding", >>> +            if (!check_bytes_and_report(s, slab, p, "Alignment padding", >>>                 endobject, POISON_INUSE, >>> -                s->inuse - s->object_size); >>> +                s->inuse - s->object_size)) >>> +                return 0; >>>         } >>>     } >> >> This change means we will then skip the rest of the checks in check_object() such as the poison check. > > Yeah, only when this padding checking failed. > > Now, we always abort checking and return 0 when the first checking error happens, > such as redzones checking above. Yes your patch will make it consistent. But IMHO it would be better to do all the checks without skipping, report their specific error findings in check_bytes_and_report() but not print_trailer(). Once all checks were done, if any found an error, print the trailer once from check_object(). Thoughts? > Thanks.