From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C8CC3DA41 for ; Wed, 10 Jul 2024 19:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58A196B00A1; Wed, 10 Jul 2024 15:02:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 538556B00A2; Wed, 10 Jul 2024 15:02:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4005C6B00A3; Wed, 10 Jul 2024 15:02:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 21D186B00A1 for ; Wed, 10 Jul 2024 15:02:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B4ADF40208 for ; Wed, 10 Jul 2024 19:02:40 +0000 (UTC) X-FDA: 82324764480.05.DE55EAA Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf09.hostedemail.com (Postfix) with ESMTP id A750A140021 for ; Wed, 10 Jul 2024 19:02:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fVOzL+MH; spf=pass (imf09.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720638133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mPZ60RuL6ih0QLl/o8/14hY+krd4EK1oz7htgw57d1A=; b=N6rrPVSmPgZBUvgpBlQAti0Yl/X5HqrGep+Xol/De/9GCJA1yfMTJS4o5zh4nBuSsSI0LS 3wGDVRTaDsYbU5L4e24kiAWqi1xH5wrwA+SZOlLymU9Zv+9flDG3Q26Ye4ABg+MHlv4g26 TZtxkGZ9kUKkzVfjQIHNomF/RSwCre8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fVOzL+MH; spf=pass (imf09.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720638133; a=rsa-sha256; cv=none; b=gOXQpr4lzGDIU6PUyljMHKlyarw6fXHDsDQ58pF7utG6ZKNVeFS4q5/s+aiXWhBv/KfdQi xzYM+j9hq1KolQciqxbX7g3tapF1Q7qHhZ8xWW6WXca+JPbXQ19qYczkYgWxzZIfughcZL fb/uc3ysgmDHBBZCrALh4FQCAIO3l3I= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2ebe40673e8so956221fa.3 for ; Wed, 10 Jul 2024 12:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720638157; x=1721242957; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mPZ60RuL6ih0QLl/o8/14hY+krd4EK1oz7htgw57d1A=; b=fVOzL+MHgD16tGLfw9jo0S9AqPNI75jsWV/W0PwEB9mBTuJWlu2JGo3PKPRLuHV8Uo F4rMNj5n0ZtHxO4WCafRmcgW/22ce1syyp1geGMCMHkV1p8i7ZaKBZ+PD9RiM79YsXW9 pELBFbtiZueiZl36DXUmUPlHOsGpmMbeIJ16CHD1sAQ2+8NGZ4Vvy9mABhsCtDlIb9B2 QoszMHMRpXFFMYyEVWGiGYHuMxKpAbCcTZHqJDZXkhnumP52khMuQx/WRYZBFhAYb8cW e0ZKCGg2GILtw0LtH4StbqR+zoLseAEAEq41fpYw6+zSLu53KjuEHxSyj/PUzMo6ZEYX Yzeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720638157; x=1721242957; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mPZ60RuL6ih0QLl/o8/14hY+krd4EK1oz7htgw57d1A=; b=wyBODTlg+Vo/EfM05OaZx8ZvXithe+nSzDoOsPKDHMaR3VguhHR0+YgF+u6m33DH+H T/keFoWzgVdY+wuoXUAsXzhq5nuKXWFSF8Kr4kJv1VsNfViItSJWyOZVFTs+1M+qfIXu IF8XiCGA4AfT8ExHdj9N9O72NCAt4XAQZHsko/LVVfIw9WKyBe1YZ2nLVhpSGhk/hkf6 70pJLa4fZlhpyt/RDr0S1q9/4KCV3KUy7z19viBSb28836LhDdduSOUBeIIGrGrQtcBf UJNNOoPmhGnz05GbwSXNyp91OrjnWGAMs4bjK9FnHybERYtoZD5FhmR6zMwtdvTQr7M6 8IQQ== X-Forwarded-Encrypted: i=1; AJvYcCWSmGxPdnSYhk8o4t64nvUUGPnFycgl+SvhuCuo1JrFYAYk/xHAgaQTZiBcPjbaanwRWygJtE/HAbIha0YSGv+TDN4= X-Gm-Message-State: AOJu0Yzjzr+zXa5Hi/N5FFHMnJ6SNhrgYONrxVw/uM5l+w4DWkdMDOiA pizhEMMJSNbgMxawjDnt1zz0wIol8WTur1gpH9mxpGFvkusjVgxJ X-Google-Smtp-Source: AGHT+IG1L8BlhXFrRo5w/hZ2v8OTkzJw0dc162nd8YCUmtKMgy4icMkIxWKQCufiuhXBIwUNvFBW+Q== X-Received: by 2002:a2e:80cd:0:b0:2ee:974c:596f with SMTP id 38308e7fff4ca-2eeb30feba0mr38435041fa.28.1720638156546; Wed, 10 Jul 2024 12:02:36 -0700 (PDT) Received: from ?IPV6:2a01:4b00:b211:ad00:1490:6cc2:4d06:940f? ([2a01:4b00:b211:ad00:1490:6cc2:4d06:940f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-426615876bbsm178014455e9.6.2024.07.10.12.02.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 12:02:36 -0700 (PDT) Message-ID: <2fe63ea9-613a-4904-8b68-134442c43261@gmail.com> Date: Wed, 10 Jul 2024 20:02:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm] 47325a5c88: WARNING:at_mm/slub.c:#free_large_kmalloc To: Hugh Dickins Cc: kernel test robot , Andrew Morton , Johannes Weiner , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Chengming Zhou , Yosry Ahmed , Nhat Pham , David Hildenbrand , "Huang, Ying" , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org, ltp@lists.linux.it References: <202407101031.c6c3c651-lkp@intel.com> <053bd429-ae19-4beb-a733-a7a838b1e010@gmail.com> <4bc6400e-6199-4147-9399-4a54c94613fd@gmail.com> <612af749-0a59-f91d-693a-43d6217ffebb@google.com> Content-Language: en-US From: Usama Arif In-Reply-To: <612af749-0a59-f91d-693a-43d6217ffebb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: jixaybnfuekr5gyjtio585zs8q7kb8pn X-Rspam-User: X-Rspamd-Queue-Id: A750A140021 X-Rspamd-Server: rspam02 X-HE-Tag: 1720638158-458118 X-HE-Meta: U2FsdGVkX18b3hLlWtwt24YajneIriV1RJKucSRuqUE1hVCfY2vFm/zes82FEOcSPnBOpOQPWyNWjHt8cSJ3qDYdln2EH+t+mspXgnvkNwXivBUipDfubxvCml3BhxPvRyHbdHyLB/x2rQIB3lZR1bdBvbEoNcKIRPuFvxKVarHKWc8o0TFM1yQh8fIyOloLpzVJb+TtUdSM/AvS/L427C01d/0S9YMg4XVxWO6sasR0wwba5oaV7/lSmY9VDmWfWm8jCf8h7ZjmkLUUQR24uLVliWVY2l0Oi72Z1iQIpWMZab42tp+LbW2xlCbeWgux0ou8ysnr14cCzmgKD20eEnUAvFLU7yYF2AsOIhiSZ5Wcvqs8xZL31DrgCpMRoLM8Mq0sS27QC4Z6N5aA97dLO4hmckHDWQ9pOK+ooVu5TldkNqLeCPxPaxRWgEwf9jkRFf3030sDx06ID08ghtGwBBU9AHS0adFXjeMCPcYgzx2C3IBUQLk/vOqDs9mCkyTzuqD4IKlWe0aYHb0zqQ5HikOdBWj9OSWtKaG3jP+vhSIuWFKECN5j7lp1zVUyKN6cF4mSSbDyoTqwoHZpAAPmpdMVd+1HFWfN2RDAaNuslsHJwrAByR0ZM0UcewKCDF+aFFwVpjvxHPJZAEAmmXwSctfyWWKzRYFag80+8hbMgDbiDi8DtjV3gv6IzMvO0rXVKtKnTdtwP2aE/RhmUS+b4s4rB1PL9DX5l5mwT1rsp7hHBYw0aatz/6KPSf5OSg8iRNYd3jn5Hu4dN3RY5TYnA8fVq+mG9xP+Jy9L8qoZBZGgDb2+Uw4x6F3eOucaLErwvOZFTjZsaY+CzN6PAlhNhXe5hH6FW2HU+1r2fJMzUJcoEBYk5kwSUQO84pJOvwXd02cAzYs3g4yvHVSUgY71F5pYR5i0M1mKpl8ojNVHZNELCM/oBgChx/99pwjty8N+yAvg+Q3+HDtKYqvDbQd 331EvXM+ 7EDjuNg6BUhIuWT2RaKtU4uxgAs6RDEgk/NdeeDnne4xPIFK45YNMknlUtlcqbCP39NMwFCDfWPaj4zNcmoqxxyjkXcl992PpOrILqZBedmRn9d05lRwoeBo3ufCo9V/3xJdNnBmcdOC+QLSGhqiUzfPWCgZU61ADRfgi9ITYNCoQoYuY6eWUVC66D722rTwJxpjVyFH7TGG+6bnSz4ZzeOSpNYnwelp/KrpH6cIOurEwxbH+YtjZGnSB505CBi4RrWgTQkh5fM0GFK8ZnduuQDOZup10qX/qJxIJgBzxZDS9oq3U1E5fjnd1NWcRNGn5eqH8LtqdQVsxCdR9ABmxKhXyBZVAtLuTUzquweEVNzYwDrmWPE6CJzGQtA93oIPnDYRuvxLK3UeBS8x9WbUjMircGbbr6B48BLAI6RYI2pTEl2UMFjGC5I3Lv3jcnbgf8Isk9Ae4R2nSe9HSllUjAxpQGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004812, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/07/2024 21:49, Hugh Dickins wrote: > It's a long time since I was active hereabouts, but the bot report > and your flurry of updates make me think that you should step back, > slow down, and look more carefully at the precedents here. > > IIRC, the main problem is that parts of the swap_info_struct can > still be in use from before while you're wanting to set up new values. > Observe how alloc_swap_info() may return a fresh or an old allocation. > Observe how enable_swap_info() is called after getting swapon_mutex > late in swapon(), once past all possiblities of error. > > I expect that your new zeromap needs to be taking the same care as is > taken with swap_map and cluster_info: to be safe, follow their example > in both swapon() and swapoff(). > > Hugh Thanks, yeah sent too many in quick succession :). Will be more careful next time. Both the 2nd and 3rd version are careful to solve the problem of using old allocation which you described. The 2nd one takes care of it in the same way as swap_map. But I believe its unnecessary to do all that change in the 2nd version, when you can just set it to NULL after kvfree, which is a much smaller change and takes care of reusing old allocation equally well.