From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942B1C021AA for ; Thu, 20 Feb 2025 02:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F97828028B; Wed, 19 Feb 2025 21:31:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A7CC280286; Wed, 19 Feb 2025 21:31:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1968A28028B; Wed, 19 Feb 2025 21:31:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EC635280286 for ; Wed, 19 Feb 2025 21:31:40 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85CFA1207F4 for ; Thu, 20 Feb 2025 02:31:40 +0000 (UTC) X-FDA: 83138747160.01.C7E6E13 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 0B4E018000B for ; Thu, 20 Feb 2025 02:31:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740018698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gCmXdW+FV6KolddGs9v0YEj1SYv5tQfmbxF++GMhBbk=; b=Uv62/xYL4eOPeu8N2eiEpoz4Gk5vLpLioOoMIOm2aWCmT7JWuGb78zwPZYfnOwo31iaC8n vTtA8YqeETUnNPzIvBtRV9fYxLPINlMLf1DqMY0j1DeaMPjOH/gzytPdSM30qFSXFASWma +8fA02lhu1FwY33GOSMeEA4dUzMDF0U= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740018698; a=rsa-sha256; cv=none; b=PCujqoGk8KNKK0ivpLpOkLe1F9RrBmdmwRGMAA1ixfXmb7DEZb17CKTeNh+rFHyCrDcuwd 8NTDaOKgHtOEV42a8HExS3oLtcS4FpDzvVQRdLxvjygqInFwL+6Rbr0GJeH32SaNq2sHPn 9uQFbu26kQoRjuOp+NIE3V0ZgDFz7Vg= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Yyy2X1Gc4zpk6Z; Thu, 20 Feb 2025 10:32:04 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id 32F151A016C; Thu, 20 Feb 2025 10:31:33 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 20 Feb 2025 10:31:31 +0800 Message-ID: <2fe4c4d1-c480-c250-1ba2-1a82caf5d7fa@huawei.com> Date: Thu, 20 Feb 2025 10:31:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page() To: David Hildenbrand , Oleg Nesterov CC: Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Andrew Morton , Peter Xu , , , , , , linux-mm References: <20250217123826.88503-1-tongtiangen@huawei.com> <3b893634-5453-42d0-b8dc-e9d07988e9e9@redhat.com> <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com> <20250219152237.GB5948@redhat.com> <34e18c47-e536-48e4-80ca-7c7bbc75ecce@redhat.com> From: Tong Tiangen In-Reply-To: <34e18c47-e536-48e4-80ca-7c7bbc75ecce@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemk500005.china.huawei.com (7.202.194.90) X-Rspam-User: X-Stat-Signature: ndzhabyuqtreupkc3mrs64yb4iqx9wia X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0B4E018000B X-HE-Tag: 1740018697-828413 X-HE-Meta: U2FsdGVkX184DQsdykocVqL2bcSndoxfKlQUXlT5hgLkTYmoBbr8U16WX9rLeBueHdHgZUQpR/3waJPD11Tjl5uAMaSOR2PQ534hdAukUwyiF5cwWFtcUZg7n7c1uxca/Q6/D+vRJK+xSIFyO5HVSkjshuB+FnEcVmybLK02cN3JBtB2mgqX3x3Ir5+69tBAoclqHg3DUXF/K9SIQHBm7Qg3RYDAfSRZy9a2E206OVZA5YVfvzZfmmoMgACmp+uAedpu0L/j0txKB4HWYotaq6MNcFjDb+EuKO65zDN6VExnmcht/vAawDdW7z5w+2LbJy+zJ5WLhpKNpxMR4ntsSM2WylsnuCbOg6hUJIftTIEnnnWACbc7ZFmRnliX2spA5elr8VU6uaCSu/4WiNB0653qed6PanSMXgAa0YrQGCEQU/wBHYSoB/sMzgipQg6CpjGXR96wa0La9pe4nYceimXmh3t9e6AwcM5tk1OrR0xXaoVZE+nXLPoetAOKN1gNTEYsrT9xxuB3aCPsyE6YrfPcH62TY6b1Qy/UAU4eQPNP9Y5UJe+YLKcyZtQkju+ObJYfFfrzcuHqLrB4hnOYChhwKRx9IDaa1mkj5cbpdRaMfp1Jd/A7g/NLSGKE3NaQPVcT3Sea8WPMABhVe80BI3Bj8vEXD7uYDqIVoZzuPORqSoQYnbFayccI8nkcfBnFG0rzfLIae0dpmA5B7BNXbgvqT9/9/3FeVhy3U2NPdDW8/cc/e8wtm3CLeAnVHxbUMLBCe542pHKcW+WPqSQawm3FmzrZqj6wPqf/qtLN2Squo6/0w8jNLI/zEjiBnlWXk8kReAPG5jpoFHHzjraPvjnSsJufOVTq85fY78OCE1mbUngWXkakwmRKYuFpL1J6Lpkb7nxEt/JugCYQtQhcjWzpzypBxjG1FacxcsEZ2RQhU0JTJBKQb5EIW0Vylud3niHzjQFluFNWd1vpQgg 9VVRLJLN 1kMcLBc1U6uae5QvBqAdlxvB1GNUNWdPJOwT9rZSPCjdnXa0FNtyhkLI2euyMvka4vpVKz+/1HLtyPklxzMj2MVIzRWhiAc4VtiiOFRqcf31CKTOLsktXryDYXO5bLAj7ll/vsUTz96TjmbCEKOx+pmgwcnjt/PqIrwQP7U0pMr6xSbSvU5j4EXvHm7D90fQhgmDLssL+5iCQJDQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/20 0:12, David Hildenbrand 写道: > On 19.02.25 16:22, Oleg Nesterov wrote: >> On 02/18, Tong Tiangen wrote: >>> >>> OK, Before your rewrite last merged, How about i change the solution to >>> just reject them immediately after get_user_page_vma_remote()？ >> >> I agree, uprobe_write_opcode() should simply fail if >> is_zero_page(old_page). > > Yes. That's currently only syzkaller that triggers it, not some sane use > case. OK, change as follows: --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -506,6 +506,12 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, if (ret <= 0) goto put_old; + if (WARN(is_zero_page(old_page), + "uprobe should never work on zero page\n")) { + ret = -EINVAL; + goto put_old; + } + if (WARN(!is_register && PageCompound(old_page), "uprobe unregister should never work on compound page\n")) { ret = -EINVAL; If ok, i will send v2 soon. Thanks, Tong. >