From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743BDC71150 for ; Fri, 18 Aug 2023 13:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFB4C94005F; Fri, 18 Aug 2023 09:51:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAAEF940053; Fri, 18 Aug 2023 09:51:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA72794005F; Fri, 18 Aug 2023 09:51:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B4F3940053 for ; Fri, 18 Aug 2023 09:51:44 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5AF2C1A1107 for ; Fri, 18 Aug 2023 13:51:44 +0000 (UTC) X-FDA: 81137363328.18.F1EDF5D Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf24.hostedemail.com (Postfix) with ESMTP id 0F9A4180012 for ; Fri, 18 Aug 2023 13:51:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=IAkM9N0t; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf24.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692366702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tqdc5uStLY7x6w5cp1WK5tJMj0qmxjDExObWY+/+D1Q=; b=W/Og76Pcs3w2E7xJ1KASHGxD/LNA/dFB96RGqm3ThzE8gYEGaLmRCexazd2UOQMxWhevom fqhmMeZ+bq2m9nTlCvU34towxWD2AW87RGD/awHEBl5Pu++Jdk3ZDNr/r99IUBKFJIRv3z dCwY4SRT1uijK/j4tsjmQfFqFuHaXgs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=IAkM9N0t; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf24.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692366702; a=rsa-sha256; cv=none; b=Bv5Y9iQlFLmUi1EaeT/jX4AL8OkrMWPICTPa0pYz229u06Kx0oJPEcXUMKVW7w9SMGgp3V gQJLJdwAM7QJbchiq6j+lK8u4DH7y4KBg9STZ6sWrOre5YdjuSavpFeplT7QwAw3qpo8g6 ew2tA6oL6S0JM2zs/WWlo2QfXcPXfkk= Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37I90GP5019038; Fri, 18 Aug 2023 13:51:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Tqdc5uStLY7x6w5cp1WK5tJMj0qmxjDExObWY+/+D1Q=; b=IAkM9N0txb65aDY9GpJ1/0Sm4wKW0BkScmR3YK6mNdtsVv8FG8kDcpqJVcUYOvDMet8M NnsU5eElqC0bc/aGbfWU7PwTCBmKKa42VWp+bfQr39r5nipItXTCuUUCBX03WanmS8Y8 IDNxebjNq+hG3NJ13tkXVFG6IkTb1GZmu3J+Ulh+/2OQs9RzHLgIH7ciGTNZU7WqF6C7 4L9+l1ad3Z2Vs1Um1m2njAmUbfv/O+He0kP2F0Hz8BhUTuCw/8BVIzugxRnQEdz6JEmf 2WPtPI1Dagz/BgQf7+NelNQkHr+RPW4+dGienPOgP3on+TaSozIP1O7ECw8u1uG2UqRE VA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sj5kr8fgp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 13:51:29 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37IDpSMn025202 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 13:51:28 GMT Received: from [10.216.16.154] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 18 Aug 2023 06:51:25 -0700 Message-ID: <2fd50bec-b689-738a-297c-e0f9ad3cc402@quicinc.com> Date: Fri, 18 Aug 2023 19:21:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [linux-next:master 1937/6910] drivers/mtd/nand/raw/qcom_nandc.c:2941 qcom_op_cmd_mapping() error: uninitialized symbol 'ret'. Content-Language: en-US To: Miquel Raynal CC: Manivannan Sadhasivam , Dan Carpenter , , Md Sadre Alam , , , Linux Memory Management List References: <7ad1160b-5f8c-47af-a1c5-51b34f656fab@kadam.mountain> <20230804184550.0cb12369@xps-13> <3604e2ed-8d30-4f7b-9e56-7af5b23b2ac5@kadam.mountain> <20230804190750.3367a044@xps-13> <20230805065510.GA18650@thinkpad> <908ee5e8-6213-5685-7094-8c4b1282015c@quicinc.com> <20230807211458.3de7c627@xps-13> <4b8607e8-4df8-3b15-693f-7d7478caedac@quicinc.com> <20230818153319.4f2ca354@xps-13> From: Sricharan Ramabadhran In-Reply-To: <20230818153319.4f2ca354@xps-13> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: f1wVT5XldYtF-o-FbKo0IuZSPX8t-G2N X-Proofpoint-ORIG-GUID: f1wVT5XldYtF-o-FbKo0IuZSPX8t-G2N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-18_17,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308180127 X-Rspam-User: X-Stat-Signature: ctrn7tnmj5hxgin3pfk7epj417ytcn64 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0F9A4180012 X-HE-Tag: 1692366701-763902 X-HE-Meta: U2FsdGVkX19Nadmm6F7rCUGKCuIWaNrJjSXf8HTIZnl3/XzftHyd8gtkszgV6LUPqh/adYGz6yprfLFmnJb8QAT3A+ilfgGUxaIrcu3IurdDGSbNf4vonpO9XVyRbN9LVgK/HhEUYpgRN58JGajyi9SDptmydLRFIGugoG4NE6OxgiheNeJUVQ2FC9ASUv9as9fJ75SXTjYomsmBPk5yl3LJRIJfCYTzyrlpV2A+W1Gm5aqQ7ZdHeNg28VJvV1cbKZDLK7CBDxP1G9OMkc5b1VDnELxU+/nZvnXES/JE1J9Pkbww8KKrYh8Vk14S1JZwmcoYMZfEevyi3QhW3bdWuzNnDoQRn3dv10OkokfChFKGIqDH3qlwFWQiedgPtkh/mdWSbxQOyC1vki+BT9RxbX28eJRMqnvojISrJcUQr7zikJZyPbdRq6FU7zET/+oyz+x367+eHxiPzwtcTxw3GRvsw3lH6fBzD220KYS/ae+z9cGb/7BFM6EvNIfbCOzzCciDet9AqAvZrYd+Z2Q0zE17ZuXrY1QTa1uvufV41ZAlu/Qoz9yJFl8eaWxj+KCFjnWhdfNgv+DYo8+Pr7NHf0TcYvt5mJauOJjjkd2kuvQE5iKdNGf6I+7ih2hf2fsKfQktDHF68TkuhaM61cBPl15v74FzEaAG12DtIuZ1Mwy0ynob74nruXs1S6/AGt4ru1ZAfd/3vTyc84sKAjn55IdpGsz4uLf+nnNVMucDaaxPpoh3QjfxGGrKA3hN/bOnZ0VmXYxL68cHEET3hdF7AxY+u2lt8hMRn7pzHe6DFWinru4mAugdINWDVI1LGDnzOH1yxyIyV5cWBmnkxlQGqw08Lw6L3E6Foljb+gAPn1NqkWPjuMIprcYRXth8EvrUtWEVhEomWJ0SSO6I2MEzHliv1J2tUulHDC+YpVgqHGK2/VtqMJ9pDZ5q5FShsaT8bf0iquo707ncTPzyhB8 Mm4MFJXa UlReh43o0sXt8bZSQAlnZ8jZnPJ9t9EHzS2hHTo/6Bc6iJ/6Dn1DuNYar0Yl52xWcLMXtg+9C4VUpHPZTE+eC32e9W0vyRfcm8o6PlvOXK26rBZ/61ttDg0zRo0m5ytYH4IJYrsejzyPnV3wqCLo/qB7BDBP1MmvbDr3G8b2YBWcAsSfc+j7WrN41rPL58AOMYeE3NmPTUlaENqkQgsrek9Znjh5qCz0z4AvmvkrjUi5Y2L1+L+0Ia3l9ATNf+X41SjKX6KcM0CNboszJc5n9292S+K07409hcfeksaGc0LY1wajj/qsX7GrafS/nDcMBgxU+5OICslyWwaW/0EL4fcnRbsRlkgcL57R8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Miquel, On 8/18/2023 7:03 PM, Miquel Raynal wrote: > Hi Sricharan, > > quic_srichara@quicinc.com wrote on Tue, 8 Aug 2023 10:46:14 +0530: > >> <..> >> >>>> With this series applied on linux-next, started seeing the below >>>> messages flooded on console while doing mtd r/w. >>>> "xxx "Opcode not supported: 0" >>>> >>>> opcode '0' corresponds to NAND_CMD_READ0. This command inturn was >>>> invoked from qcom_nandc.c driver from below places. For read/write_page >>>> driver does not use the exec ops. Hence these calls just ends up >>>> being -ENOTSUPP and ignored. So removed their invocations. >>>> If this is fine, can this be added to your series ? (will send >>>> git-format patch to add to your cleanup series). So far, tested >>>> mtd raw/block read/writes and all works fine. Will do further tests >>>> as well. >>> >>> Unless I really don't understand the controller, this is non sense. >>> nand_read_page_op() is precisely what allows your NAND to perform a >>> read. Removing this call cannot work. >>> >>> What you need is a proper ->exec_op() implementation, and repeating >>> this becomes slightly annoying. >>> >>> Look at your qcom_op_cmd_mapping, you don't even have a path for reads. >>> I bet something along: >>> CMD_READ0: >>> ret = XXX_OPCODE_READ; >>> break; >>> will make it work. >>> >>> Please fix the driver and test with nandbiterrs -i. If this test works, >>> it is encouraging. Otherwise it is still broken. >> >> ok understand. Will fix this up. > > This is urgent now. The driver in -next is broken, shall I revert > everything or will you test the above fix quickly? > While we are able to reproduce the issue, add path for CMD_READ0/READ_START for IPQ platforms. All mtd tests including nandbiterrs works fine. But we are not able to get hold of a SDX device where we could reproduce the issue to debug. We are working offline with Manivannan for the SDX remote debug. Will keep you updated here and if we are not able to solve this on SDX in next couple of days, only way looks like revert and re-apply it for 6.7. Regards, Sricharan