From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103ABC47077 for ; Tue, 16 Jan 2024 22:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 765AB6B0081; Tue, 16 Jan 2024 17:27:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 716446B0085; Tue, 16 Jan 2024 17:27:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DD666B00A8; Tue, 16 Jan 2024 17:27:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 49F8F6B0081 for ; Tue, 16 Jan 2024 17:27:42 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 12A0880B9B for ; Tue, 16 Jan 2024 22:27:42 +0000 (UTC) X-FDA: 81686612364.24.C012A68 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf05.hostedemail.com (Postfix) with ESMTP id 3EBB0100018 for ; Tue, 16 Jan 2024 22:27:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VfPWiEzF; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705444060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=euua8TbFvT7bIKUoXXmmlR4cAfJPgJdRjAqKppqIecE=; b=q8rnd7hfX2ofsyT6IZ2PIqaVFsKA2i7OS/xWRHwYS3y2eM2VorYlbQrFElpblhAJmSJD9A Sodiy6LbLem5y5/tfF7BIVh9cr3j48eyGg/BSaBHv3NeFI932Ig4JELUhWn4XyvwltEcf0 CMJ1xsJ7d6ijto/UrxkioLQCElWklbo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705444060; a=rsa-sha256; cv=none; b=0wGDrPvHnApAJgKWL8Zd6Ixw1WBFV05h1wNSV6OIiZBbrvfZb95BbOmgW0RPRpNXlsbJZf SE0NB7RaPq+A16HqRpIM2HqdvFd1bPs8JRjnNZtyK42tAjvTezXfr1Rt5o+xFbL9Rewril 41bzZTU1dB+oRejXSt1Ai5t+qjsTBJ8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VfPWiEzF; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-337b976773fso1046995f8f.0 for ; Tue, 16 Jan 2024 14:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705444059; x=1706048859; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=euua8TbFvT7bIKUoXXmmlR4cAfJPgJdRjAqKppqIecE=; b=VfPWiEzFqa3Djz7GVkKktmNJlf8qF83481ZTlDAF9yI5w9Ghoy850vYda13V2CqmrS yfJxsw/g1WnPgD4ultvEcLBqdY/qpKBhnAnHrw6SZRNrxC4PXVdz0pDaRz4oX8yG5Ak1 EwSLIplBV92DV0x2SWpA3U2G7Mm2q7ttpAmvQNjmgHKsPJIHcWyY9lZSYYvnvZoDHnHr C+J78QFEjmOVan/iz2Mi6YqrHfsiCBhf4cwN7GXbiRBD+nPMQcP9Gwtc1eLwvUOm14TT rc5Io7ozO4SThiO13oBukPqfTVGcExGGcMnzspK8RonN8Vx+mD37MbGPmXgTyZGCLjze 6Edw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705444059; x=1706048859; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=euua8TbFvT7bIKUoXXmmlR4cAfJPgJdRjAqKppqIecE=; b=EO4ZUOV5PAHoL07DE1qE4fPpG7FwR7KHdqcCajEv+t2jLQ4M8mKIQ3VtRPFXS20VtC 2IXdGtFr3v2slUzEYKefPzXTtUri0+3n4+CMWJGTiAJ0DVB6vZuqL59YDDN+2ByIYuQq uyzvWDBaV0Cy3WwrJLq+rDWMii7jYxXiH7Ve68vZp2g5gsPmxDHsZKx/YvJSikTsAd04 FYbhJC0/wPKlk118BlegOvsAYqSXtTvfmo2Pz6uMzlF7zKtCcbvxga8peuWcMHbGZlLk gR5gz7cBRUL3VFCY6cBVi8RLPbZHHrtuiPmv7HpqzW/D0n0IUFNyqbjT4zaLZeJItpgG k91g== X-Gm-Message-State: AOJu0YxgxZVTjk7J3WHKduE72eZ9nfNGPXNPekukqNt3tm66tY2b2lp1 NU8s5NkNrxj2TsgrEsNeAqA= X-Google-Smtp-Source: AGHT+IHLupeptjw4yqd6axr42EBhj0iaxFvFsIK4145/Se22Wb3HqJ2VWqhCjtlJeVESOfCuFf1t4w== X-Received: by 2002:adf:e94a:0:b0:336:6837:efd0 with SMTP id m10-20020adfe94a000000b003366837efd0mr4073622wrn.142.1705444058565; Tue, 16 Jan 2024 14:27:38 -0800 (PST) Received: from localhost (host86-162-136-255.range86-162.btcentralplus.com. [86.162.136.255]) by smtp.gmail.com with ESMTPSA id i2-20020adff302000000b0033788e357e1sm145538wro.108.2024.01.16.14.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 14:27:37 -0800 (PST) Date: Tue, 16 Jan 2024 22:25:23 +0000 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() Message-ID: <2fcf0acd-f451-4e8d-a769-81e1cee16ade@lucifer.local> References: <20240111192329.449189-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111192329.449189-1-urezki@gmail.com> X-Rspamd-Queue-Id: 3EBB0100018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wjag4tgndwce34tzxdq3q416gzwja5g5 X-HE-Tag: 1705444060-984240 X-HE-Meta: U2FsdGVkX19zLxlhbnHygHVQOfqTIkWVOA2xaItMUSfKebZMvrALSmXdxrfEuSuCe4nWUP74H/CtIjUHi2aJdbPn5fBd/7jZPo/Hden0ItpqP/wPOscIFfwzQQSwaHfTRnfxFmbqZu1eVMPOAMjWoJ5aWKUzIdGuRMxvaqjw4yxIl5cqBgMVp+5S6ij6+x2r7cjclnGGIdv/Tzh0zLluBi9bzyFQU/otv/6BU0Xr2qJYUOnawsEaAwtxkkqcklxrGRHtOXt/rUcqkIbqvA9ZdaorWGPEJ7HVY0yb3fPSmBF8jpHUIwNeOSRWAuvAUkV7tdIHMRMLZCXNxWTX3F6XXacrwxrrNoBRi2gYp7zhLiX1D4beBh3YLNlGdzDWAzoJQT75OW4f6uBkFD5ET+DjqEPP5z8pEc44TVnesBNO7FifctdKcho9Ww/7dpnfUEnmvifJi1gk2KH48p3l/2uwyY+y8xNoCrI2oPs4uQ/GtKY+Wvmn3gVB/Y3enLhaECpiV+0TCAyx7Xdbopv4c2M6yAR3sR4lCijLLpN4DW6kpydQGeuoBHvsTxrEhq5kjsRQYBdgd1R2t6cEDK25obi76fOIEjE694xFmAv1AdTPKhkUOdrF+7jtnd7uCbPexMwVrPRYjUDgL7nVhBx45mKfTVSeroNanLycAUUddT4FdhWe+MVZ/hE6F5JnjB6pS6O5I+WEC/xClhWdD0CBE2SAlBFDfmrBrblwtsLytcqG2cWFV/UOiD7EgYqC769p/dt73r0xvhUGEe/S2g0ueA+xmjRTRHLSa1RONi3bW4Go+AgxX80GYxhQy/SAxuMgV0QT0IRCa8YjVokpwh6jw9CzvCRPcRvje6BG5WaenDgXx+GbjEUfreEzbmCEEelkIuAGgNpq+LpGWnkf6Qx5CO4Gcm+GxD1xMbtYugSGJPX4DieTaHfH4pQUJlhn6BSubo6tFPL/0rk/fPjXikFK5E6 KcG48hqg cTK7SkbnqyVXiMupNJR8bil2J+390MhlcPlZMN4kr77nvW0O1P3bNDcSgqBJZ5ZnPy7J6aY+XFIcOMV3RUANuxLlNOQSBgSaiabm5OXl5AdqnZ+gFwObegkqv1FZUYDbA+EJGI+e/IuM/XhHtoI58DOCBrybCsb7KIIWt9joRUOQjt0+r3vVdx7Fmxug+T3MliE1/Z2N3QPDV50+tSqwVhCJkGI5RmTXi3bcbEXiuaO8oZIlRvr0iVaWC+sGe4X533hp0afmuVLPAx9ac3W5uG4u2ocBVI+5rT0xwhjXZbs6ZPSvXccjS855L0hC8Pli4nc6jR7G65TGa08Lfg2KMqh9Fr/l3WjtI66eU9UFQNrJy7UlPeXikT7r2qthRqo//DKmO83IqwIX/ODJMyXBHlyYIZo9FPhSHxe5xLY/y0GqG4mDptyBHF49fD/wQnRVda78r5lxmXNH7lMN0m/KLwvnpt7BzJzNECAkOTrNQGDNj1J0EOaH6N34pkQCg0ei6XhfXw7YXI2qzh52CwiHp7CHpNM0QNJXlUoDB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 08:23:29PM +0100, Uladzislau Rezki (Sony) wrote: > The vmcoreinfo_append_str() function expects "long unsigned int" > type as a second argument(0x%lx) to print a beginning of vmalloc > start address which is defined as a VMALLOC_START macro. > > For some architectures it can be considered as "int" type, for > example m68 generates a compile warning message. To fix it cast > a second argument to "unsigned long". Ugh dear Lord. Insert grumble about maintenance costs surrounding hobbyist architectures. I agree with Christoph the correct fix is within m68 (and any others with inconsistent typing). But for now we do need to work around this. > > Fixes: 9bdb180b2d ("mm/vmalloc: remove vmap_area_list") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202401120218.y469Puyf-lkp@intel.com/ > Signed-off-by: Uladzislau Rezki (Sony) > --- > kernel/crash_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b60de490c1fc..49b31e59d3cc 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -748,7 +748,7 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); > #endif > VMCOREINFO_SYMBOL(_stext); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", (unsigned long) VMALLOC_START); > > #ifndef CONFIG_NUMA > VMCOREINFO_SYMBOL(mem_map); > -- > 2.39.2 > We definitely need to get this sorted for the bots, though moving forward we should patch this problem correctly in the right arch. However for the purposes of the fix feel free to add: Reviewed-by: Lorenzo Stoakes