From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB401C10F1A for ; Wed, 8 May 2024 02:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BAC06B0082; Tue, 7 May 2024 22:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66A586B0085; Tue, 7 May 2024 22:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 532516B0088; Tue, 7 May 2024 22:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3389E6B0082 for ; Tue, 7 May 2024 22:13:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C80388068F for ; Wed, 8 May 2024 02:13:32 +0000 (UTC) X-FDA: 82093607064.23.18B74C0 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf20.hostedemail.com (Postfix) with ESMTP id C379F1C0005 for ; Wed, 8 May 2024 02:13:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=aKkpASeQ; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715134411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PnVKvCgegzpzXY1p/Owa2fV8B2MMlLljlSzcXtnLj/4=; b=r+UMJPJNnEf4dNqfXOptcR/7IkblF+oUK7bq/ciB0GKEbMgtCFTmhtuiBjlFXJSIDKkTpY ARdq2nGwt0PXSQJ2s3Y9iI+dgUxS/MhPou4n4hPcvfFC3VwoXCNED42mi3yNWNQLszChJi p6WqBnFP+u7RtUvXAIML+QOiI8Z7+vg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=aKkpASeQ; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715134411; a=rsa-sha256; cv=none; b=h7TrEM4FOLz050q5sMFJacariPnz8DVMyrBJPLrQvW8Jg4SpmJfM8s3jo4WwiC2JlupzXA CGxNsYWWVSdlj4rq+pBHOul55QY91l/x1dZasLa1vyOipqUgKKhFKf3jqtAO+W/Z/xQ/CQ SpAuvP61H4x/r2tEq5v2/0pvbj4TjUM= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1715134406; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=PnVKvCgegzpzXY1p/Owa2fV8B2MMlLljlSzcXtnLj/4=; b=aKkpASeQ0aR6lG043/xyA9XoNpuYWU8vTDkmrpa+B9ExnKfsZBnQOZM77qleK9l/jMWX6dDwyBGCla5GdWnDKDT7w+3mc1lCDH/duZXZZXNF26VHcsV7LJBaQ2Q52/R8L3LdUwwKexWNTXDL3mhQoXNEzIQPbvcIdvZLZ8B4Ljo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067110;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0W61sxpy_1715134404; Received: from 30.97.56.69(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W61sxpy_1715134404) by smtp.aliyun-inc.com; Wed, 08 May 2024 10:13:25 +0800 Message-ID: <2fcd6dfc-21b7-4e3f-9741-8f0d23d2da5f@linux.alibaba.com> Date: Wed, 8 May 2024 10:13:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm: move highest_order() and next_order() out of the THP config To: Ryan Roberts , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, david@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <9576c979-8a11-48e2-aec4-646acf0d8e26@arm.com> From: Baolin Wang In-Reply-To: <9576c979-8a11-48e2-aec4-646acf0d8e26@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C379F1C0005 X-Rspamd-Server: rspam06 X-Stat-Signature: rcxxfj5upjbburjip5wi5myxa1u1b4fs X-HE-Tag: 1715134409-389613 X-HE-Meta: U2FsdGVkX19rK6OWYkhTLa2ieouKt9fJvjxjsHF2PEQCtZfxqwqtbo7YJXk5CkFQznjw6V9dfThi449+DF+R14z1OfKu0hZPR3rRFAVLsr/3YVlcx6FcABbbew2uGud7pDmEllXxBJMyd+5ynvjo+mtCcxUlP4iTbCEJqJWuK23/LsQUIvLhmtLuzM6bC7St8aWrufmovvIElGLADRQHxG2LS/3v0m7/fMFFRBflRl1EihNxnpkrY2gf+CeL/msQEK/kYNcfZmGlYN4/n5WcJK9SQvUAXo2fKlYAgZyU8udjkCKJQMljQNM1R5Qcu+rsk8UrQ3NFb0r3G2u66S8nKXScGw9Oox/74UBbKdkpn9KUWPklhdgW2rUuH42yTkV0fMR13s1X2/tzeWf8TM3pM39t29In6kt+oJPebC4cKorNhTcJEz2q/FDxCQRIQk2U7Xuk7oYs+9l7gxFS5Ope6uCplVBTyy/yxlEKSzx+qCiPd7xDVLB0ZYGWPQXxUynSUZ7s+YNuj6MtM0z/mvVImnc00iAN/58a0j0gM8o5XPqskZmFuYXqqE1Vo3P7ynnlK+nzjFbs8FqGcd7hQULjdc6XKmSgeCNLTOW77OxHiS4qeov1YIeuuXtIi0zx+lsWL5jSz5kBoEYPPXXCbe2zFj0ASUIJiNOxeT8Jssn0BDxOYwvpOqsvUbhZKFEXQZG7JrzPKuMJyAYQc2N/ThWWcfflxSbG8xyZ0MAD+PsNxgiMySI/aSugxoXAOVDqY0zJG/SDMGW5o73x1CVyi7/1+m0dbp5tssX0/c36bgjbcumifMKWxVUFDd6xkWYtq/Vovc1RY3K9yNcrGqU5INEu1i8UK4rX0KaqR8TwA8hdSUvVrZHIVWjhIlASdTm3vHbdocAwGo6kKnBSla8h5WoP5nnVkDJ10s3q5HwUpIvgry8zoaZabR8ajL2wzhgYwEkGTpR4/eyi8yR8x1IX2pP ZfvIhEoG QXfPkCwgny0gNQTtZP1L0aDZP4BfNINV0w8pLG0rdpoKoic13qEPEJMqVF2SG8xc01y/p4cgpFuwjzO3ZpVS4l6TO54w5Z33xKjB3YEL6d1PqmKItsASii5puTiPNHa/ssme+/hqAjUEsRaV8FT6HpPftW/uZ382p9dVdmyFJU3ECMr3utaav2Z2+pkYOXCi2krbhe2+7zRJbhagYibk8LNbmYUlOzg9tsmQVMMjzT9lItMNV9gqS2E2pDkMmMJJ1/T61Uvqt/sF3VzWTy21LEuKqUB1UjL5nIdkuvHk5LReWGY2pISDqbJtzvLfFTYt7jF/WRe6ZI3vYyVm7Fx/p5mEmPqqmghpY1vND X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/7 18:21, Ryan Roberts wrote: > On 06/05/2024 09:46, Baolin Wang wrote: >> Move highest_order() and next_order() out of the CONFIG_TRANSPARENT_HUGEPAGE >> macro, which can be common functions to be used. > > Sorry if I haven't kept up with the discussion, but why is this needed? I > wouldn't expect a need to iterate over orders if THP is compile-time disabled > because we will never try to allocate THP? Cause I don't want to add some dummy functions to avoid building errors if CONFIG_TRANSPARENT_HUGEPAGE is not enabled in patch 6. Another thought is that the pagecache can also allocate a large folio even when THP is not enabled, so these helpers may be used in the future (not sure though). Anyway, I also have no strong perference for this patch, below dummy functions can also work for me: diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index c15bebb2cf53..7aa802ee2ce5 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -586,6 +586,16 @@ static inline bool thp_migration_supported(void) { return false; } + +static inline int highest_order(unsigned long orders) +{ + return 0; +} + +static inline int next_order(unsigned long *orders, int prev) +{ + return 0; +} #endif /* CONFIG_TRANSPARENT_HUGEPAGE */