From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F9BC02182 for ; Tue, 21 Jan 2025 07:58:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 779E16B007B; Tue, 21 Jan 2025 02:58:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7273A6B0082; Tue, 21 Jan 2025 02:58:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A13D6B0083; Tue, 21 Jan 2025 02:58:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3C9F76B007B for ; Tue, 21 Jan 2025 02:58:51 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D141745657 for ; Tue, 21 Jan 2025 07:58:50 +0000 (UTC) X-FDA: 83030707620.10.8215122 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 618F1A000C for ; Tue, 21 Jan 2025 07:58:48 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJengcbb; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737446328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4I9mBlR4gpARht8QBYs3gpwBx+UJqaSVtQfoJrZOBOQ=; b=sjO9fM4yfp3FtAeltNP/wifT0JJ7Ca1TzTUiTRAs2QTrvLcA/ngH3UW5EJFJM+ynqrVhSr Ul4bw+6xhbv0t7b3ZmP9qjtNwS4sMAD2dWOskQH9/opcP7sqv9dU3BkxgNAr26HSRm6fb6 nRaUSFknT0wwFs/khM8FdlD8enBcDu4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737446328; a=rsa-sha256; cv=none; b=rF7bMH8wvv47lazSdNVCV26ZGg+Fcoy6+v927VasHTJ1gYnHmSLhahWnyfqr78+gSICUdB gHULYRYd2LwgN/XfyTlcLdM1RHagCJxMV8JvCJQpeBQFSmxLhVPz52nq+ihc4zCmKf3sgN Jvr1nLYglseMd/JyjiSU86rl5yp2YQE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJengcbb; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737446327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4I9mBlR4gpARht8QBYs3gpwBx+UJqaSVtQfoJrZOBOQ=; b=gJengcbbmIWbGx/cd1UreFTUeaQvqFO8ahtldK1bIjCGTtGkR9K59ELOgbRO8CKofIVhZh egi04T+TefkrdL4KyXcPUuvNt/n6F5990rzFKSrDFb/wqdOuR0sFw0rDLhjt7oaBoV4Zbi BFxqAiuZrXt8N091twzcbtR+JTZ5XWI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-iwS6la7hPbO_lX9_JjsI_g-1; Tue, 21 Jan 2025 02:58:45 -0500 X-MC-Unique: iwS6la7hPbO_lX9_JjsI_g-1 X-Mimecast-MFC-AGG-ID: iwS6la7hPbO_lX9_JjsI_g Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38bf4913669so1998221f8f.2 for ; Mon, 20 Jan 2025 23:58:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737446324; x=1738051124; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4I9mBlR4gpARht8QBYs3gpwBx+UJqaSVtQfoJrZOBOQ=; b=esikzoC/vnJMN65lcLZQoDpB68SMF4hHUeg1zQVEFDBNTQVSZ1DnQuoC7AkZkJVQ/L xc56PODYZW6eEVqayGTnqNdiBOOvYs3gSWq9kuvJxMHSom3aQxRdojbGZ/D+wmaB3Auy 1QdzMtqx/rosgawZeuORpEq2j8YBq99/WEoj8AKxwaWKEUErVs8+hXXRL/x1B5oVp+zj 1nVcuOuyDpRQcmEPd5pMtC4b810jc6g8ozIkHjMzKyDTjTJ0UXy8Gu0tmz2m1VwHG4s6 XpOrf8scUhxyts3ZF6czygMtnIaRnmHKVeSpocwZwt0c9tzVVSDtOX9SWQ/pxxz92LF9 bhZA== X-Gm-Message-State: AOJu0Yyz3Gyi0Tx8RnVmjflaRMbRMJ5oE51Rtkuc19EIvyd1eo0XDzBu LLND1vFRKZX/bOIGJfKPJ1NcX4xmdFsgVnCLbgHQ4L6cCYv0VcxGS+wucbYDY8K8EvHy9kNuxD2 cSbRlLRUVR5cbkUKTOkz0PZW3krJ6MyonpN2VnbJdaDCI+wGY X-Gm-Gg: ASbGncto9H9Ev7ZWS58GmWcuZCm185y3UctiI03yafkYbmpEE76T2Blp/Rv4jU+inWM T5WiOKj9Pzox95ChzYV8/2oBtUt+G41XmPa6mvM/g8LByiedWOSXKBpXz026zYT2BtE4449wtQm XEB8cRbdmX1Px59XEJUQB7FCfm5yFC4/FGCtGuHVHWxvKsblwvss8+X9/zv6n1wx18LFMoTfAP6 TdybVx+h4rPFy+wBAJITgRkaThpFleUswhfZXWPuZqMkWV8qf1/ZUk82wGhXADGLRprpnSosMuZ LfDn0OOM0sQb5Ae/v+yriWCMW94J1vWHGjCyaNnsWgk8V1Gk9zmyK9eKHzF7/zvNoR+yiK8k2wC A+LhyrRF+YvSMdBzLPoxajA== X-Received: by 2002:adf:fd84:0:b0:385:faf5:eb9f with SMTP id ffacd0b85a97d-38bf57c91e7mr15554606f8f.48.1737446324725; Mon, 20 Jan 2025 23:58:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3ieDoku8HI00OZfFefH+x+Vx9Juw9PgMtLEyJ3OtSMHPP2xLfQn+F5T+VSGDEQEJiQcJbaA== X-Received: by 2002:adf:fd84:0:b0:385:faf5:eb9f with SMTP id ffacd0b85a97d-38bf57c91e7mr15554586f8f.48.1737446324338; Mon, 20 Jan 2025 23:58:44 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf327e327sm12313241f8f.87.2025.01.20.23.58.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 23:58:43 -0800 (PST) Message-ID: <2fc40750-2ff7-4e73-ba52-c4d9caaa4f4f@redhat.com> Date: Tue, 21 Jan 2025 08:58:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio To: Miaohe Lin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, mhocko@suse.com, Wupeng Ma References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> <80984553-a2b9-46b4-acdc-f7abba3c755f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kPaAMRXC1J2wHqqaRP8eUD_9cTpfFBpSvKA4ButVDwg_1737446325 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: fpqon9nt8u8ffashwmwgr87n7nxesdgg X-Rspam-User: X-Rspamd-Queue-Id: 618F1A000C X-Rspamd-Server: rspam03 X-HE-Tag: 1737446328-193675 X-HE-Meta: U2FsdGVkX19FVzwSPSOUDS5KUry6v+M+GZ7ZqKKd+88MZwcuvyzjbTNbmAI/G2GvUzsx+OjqH0OdXkT0J5k/SrqjKvXuFSRHvAoppa/TPfCmcyi3+z25NA9EWipsH8AI4ACLLI7LQCpuf0hn9VxJhrJcuRF/NDNHDyFkM7tQSvwDylQ377x81DFr+cNPLh+PoU51nowvEVkz7ku9A3nL9btBYukyJGYQq7EpayUJKCXMGefT6rEfVxoHwbAsx2EK5FLqRb/qvbXBF0sDrnTM62+vzqcMksKNdpViHUsPa2Is5CUaAC9ztGLj4WqQn1hgnn/2Ou3hsyeyOqSUJLqVRFIYolWec5tYZve/NNBGKXTdUtbxHiKlxWpWCswMcajLeZICqOrPm2rtJFkS9p5VaksgRMR0Cfw1iW0NX7hEJwixl6x10uzlQJRpN8+fpRxllbo5y6h1pCKBk74Fx4jjyr6ww8qy2PiKY6SgcyDha4d2XTemz4E25CI0Zb0dxNlKfe9U8h0c7fr7gV1No2XEe41IxvAWSc6NVJsXD6iDjnEHQqRir0gp6z8ZGK8UFRiLJznrAr+yp652l+RPznieyNexnKYzYLi/ano0NHQE/h2Hd6KP5KMF0SVEPTqZ3NvMe424wZt89GuyxpkUcPh27QbLL8UtHFWJVFbPE4T615c2cACxcqI2Y0EfkkrD3OZ1n1rEvv+RgUxnvqyMbQCC9l52RcZIQowFjL1JrQ/sU0q+TA0RmmdPwUXCPfaxXxES8i6FzZ7uWt+qGyi96751TUWFT9wP42KYFpTKKLQPctnS7JHE6h2T1lhMFyRTLCu2jCKyRv15lG+f5Dp0uqj0BIn3K1wU+cW7r8Nz7sVJ7bksM48u6vO+oK4KnbP72njypWzFgt6STpiqFQsp6AwosyCoU4zE5G/lRr989i2W+1fcR2vgy/POYm70ntMGVGnfHnqv7lnJPBfbm1MqKZe SS4LV6YD 2E0RwOKyNBAjdNvAVtqD/iNwvKpFh5PmThJhFB+FqAJfT3mZi4WizAcpMIQ+h44tOzs21eIkVbPYG3L5QkeIVxr8BlzLHouFiGqECariooZfUPVahG3AUq/879fgXgaFmytpkT9eqNeH74G0JlUOTGCddB7xC9/pFHnbh8haz8frzNO7KNidaVETAIgM0ZfCxOwKZZt+GBNabXerf6slHRaF3tHvMTlxI90FsjvcXmM5Vvnih7b7KbCKENgXxu7Brp6kIzLXfFAsXj/jPYFU5kzTIikN39jh5A9afv93oMcjlw4FqM/4W/dlAgeF8DcTyFixrLtMbENE0J8Y7kzCY0wnWxrlLVEkqB3MZ/aEKEOw2h/3CQ1v4RQzv0Ji4R+wXWWDzGe724P5as+08tFzTpBLtf4G+krecD0RVcLD6Y27gikPR7UDgx5E98IrEntEIgGNU40uO5BfeXy6YhMU4BFBA0ygzFlg0NhnCnmDX4a+5oPcLqCFz5NlU3AxoQB49F4VnCpDQiVRqfrCjeaCt0/7O45meH18LpHqi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.01.25 04:20, Miaohe Lin wrote: > On 2025/1/20 16:46, David Hildenbrand wrote: >> On 20.01.25 08:49, David Hildenbrand wrote: >>> >>>>>        if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { >>>>>            struct address_space *mapping; >>>>>    @@ -1572,7 +1598,7 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>>>>            if (!mapping) { >>>>>                pr_info("%#lx: could not lock mapping for mapped hugetlb folio\n", >>>>>                    folio_pfn(folio)); >>>>> -            return; >>>>> +            return -EBUSY; >>>>>            } >>>>>               try_to_unmap(folio, ttu|TTU_RMAP_LOCKED); >>>>> @@ -1580,6 +1606,8 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>>>>        } else { >>>>>            try_to_unmap(folio, ttu); >>>>>        } >>>>> + >>>>> +    return folio_mapped(folio) ? -EBUSY : 0; >>>> >>>> Do we really need this return value? It's unused in do_migrate_range(). >>> >>> I suggested it, because the folio_mapped() is nowadays extremely cheap. >>> It cleans up hwpoison_user_mappings() quite nicely. >> >> I'm also wondering, if in do_migrate_range(), we want to pr_warn_ratelimit() in case still mapped after the call. IIUC, we don't really expect this to happen with SYNC set. > > Do you mean TTU_SYNC? It seems it's not set. With your patch it will be now, which is the right thing to do I think. > > There might be a race will hit the proposed pr_warn_ratelimit(): > > /* Assume folio is isolated for reclaim, so memory_failure failed to handle it at first time. Then it's put back to LRU. */ > do_migrate_range > folio_test_hwpoison > folio_mapped > > unmap_poisoned_folio > > pr_warn_ratelimit(folio_mapped) > > But I might be miss something. And even this race is possible, it should be really hard to hit. Does try_to_unmap() care about isolation? Skimming over the code, I don't think so. I assume once we take the folio lock, races with reclaim are impossible. In any case, the race is unexpected, so pr_warn_() would be helpful and not harmful. Memory offlining code will later simply skip all PageHWPoison() pages, independent of the refcount as it seems. Failing to unmap might not be handled correctly at all ... I think this might be problematic in other regard (e.g., GUP references), but failing to unmap is "obviously" bad I think :) -- Cheers, David / dhildenb