From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E27C3DA61 for ; Thu, 18 Jul 2024 23:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FCA66B0085; Thu, 18 Jul 2024 19:36:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AC556B0088; Thu, 18 Jul 2024 19:36:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 774C06B0089; Thu, 18 Jul 2024 19:36:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A8A76B0085 for ; Thu, 18 Jul 2024 19:36:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1DA3CA1DDB for ; Thu, 18 Jul 2024 23:36:34 +0000 (UTC) X-FDA: 82354485108.03.CEEDB00 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 9ED201A001C for ; Thu, 18 Jul 2024 23:36:31 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VeCX3KMg; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721345770; a=rsa-sha256; cv=none; b=emVhUZkDew97k68euXDJ+6pFTmV78ZcSTQ2WfjsiuLnZHgV2jryW1CmntTs2bVZhMjXl1r rxVBxg11GxcJQxRMnaGqOCvH5wGyAb0p5lewwOqLoXQqk+JjenywfOduvJ5qs1v1lFWfFj PRVAY1vJCUprPpxjWbybFrmNQeTNjjc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VeCX3KMg; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721345770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cXn2FMIulOwKD/dALcoO2d1mEEwa00LIGNe5/0vkHoU=; b=iVWROnL6ertB8maMpECUEmqsDxCm885+hXNroSA2sM+opEvLGr14uBrJbuIhcho1jSbUiR svrYclxQYPpYqLI77eoROSBBGflAhOLelRQgm5UyrdGMSncHw9vhsdSIjbi+KU/eBVQXKj KfXKq8qKgGtTMw7Aj5QWdxMGZRv+dE0= X-Envelope-To: pasha.tatashin@soleen.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721345789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cXn2FMIulOwKD/dALcoO2d1mEEwa00LIGNe5/0vkHoU=; b=VeCX3KMgX0CuiqZf0yZa2vq1WIblArijXqPIWIeh5DnwvrsEEM2X3OBk0RDAf3iOYK2yZJ JTJJGeYcnZoo4iIunkNjglFfL0qt0epTJmBvCy8UZq2Cvdq2hTzoScnYVNoaz2UjFcWopo 31RHe1a3pEEspzgCGX5vBbd782zoH0E= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: jpoimboe@kernel.org X-Envelope-To: kent.overstreet@linux.dev X-Envelope-To: peterz@infradead.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: cerasuolodomenico@gmail.com X-Envelope-To: surenb@google.com X-Envelope-To: lizhijian@fujitsu.com X-Envelope-To: willy@infradead.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: ziy@nvidia.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org Date: Thu, 18 Jul 2024 16:36:19 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Pasha Tatashin Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram Message-ID: <2fbbxcsjs7vtzpb6a5wudbppcr2wgc2xwdw3cgs6ejzx6rioze@z2sct6rbulng> References: <20240718202611.1695164-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240718202611.1695164-1-pasha.tatashin@soleen.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: t5hu8xbnku8kyss6k7k3t95m6n3516id X-Rspamd-Queue-Id: 9ED201A001C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721345791-479218 X-HE-Meta: U2FsdGVkX189oeTUb8cvXomDd0Sy0dTrvn5OhwJ/lmtB4OxPXzEysXFSCCjA+148shR5EZF3JFREVUsgHOgOvw1xburBsQh8+KF+APoCCl/Dq01mdA0DMGfVFEnhkILEhnsN9DcqwqiFEegsWh7lyfh5VgOA8+2zvOdUksIomyQ7rsDg6RMx8V3Xn6H9NgfqolfO6uT0pbUFyVXo/ib8RrljvqqNyVgrBXu4eDMvob/ZTJIMCgHAaQ5QLhVQsT69gpf6Z8A4y3CfZE2tM1tg5wd4CpB5y+mVjT3jephF5z9N2o7B3QG5k7NuTeT+JuBwYkUk6XBijp5jmHAXY6/u1KLKq5/WJevdKA3ikMm/aJcNJxsk82ix1QasH72dA6HJVlGwa6bksTGZkgd931mu+A5oafoHEtZydBY3T68qjW6RzyWlMzdAlBwxbWWyiuwDd+KM4ETpCsOccD11V0Il1gxSqpyotnNvJFXCEa0vbQu1VlXmgagS1gnqY+mbk1dktbVRVVXil6/1PL61ISNcqWG1238LHP6JWGqI+r+GJcdNNbK8SrgK7OJ2oDrrzFW0sTzYy4S0efpEgKmWktqiP7emU3Z7TODwoBEMQuqKaHWF5AtHhmqv+bed4HoHm5Nrl69O0NulwJ7XoYY1LmQBAdA4DSijqS/Zy8Rrjhfs4iAtdJNvPQbZydMZt7t3z4VIlxYblYzDDkBnDL+g1N29L+SHwSisWCCh6uUsaGs19UahDVDIySsAk0T6+34aZ6L/a8Nu22D24I0ZpTySEtYS9HCQld4Vyv0w/HcG8mlU2eoDeVgzTFbRF7cR6qd7hPTYKxwNJR2GWiefQB21gFAa/BIUOdWOpKWbofE0yxtZY+PNRE5DXV2iW7lsDkgg1lC6orXkx/kbbhWzwsuZKauKz3D1y0wWlHJre6KJnwVdZcWufC4kHeInOppQT5pXdpIeSNobduYi5crs63DFzz1 TPRYttan GWiFBM5u4AaN9EMUkhOk/mtgvbym+3Gb8Vn29Oz+Hwf44wmb2eGLyhgOxJ7h9GEOPOVCud9zgktmPE3lVcuKoBv12yi1SoC32vs0LveA/Eif4tA2LMnxbljWc4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 18, 2024 at 08:26:11PM GMT, Pasha Tatashin wrote: [...] > diff --git a/include/linux/sched/task_stack.h b/include/linux/sched/task_stack.h > index ccd72b978e1f..65e8c9fb7f9b 100644 > --- a/include/linux/sched/task_stack.h > +++ b/include/linux/sched/task_stack.h > @@ -95,9 +95,51 @@ static inline int object_is_on_stack(const void *obj) > extern void thread_stack_cache_init(void); > > #ifdef CONFIG_DEBUG_STACK_USAGE > +#ifdef CONFIG_VM_EVENT_COUNTERS > +#include > + > +/* Count the maximum pages reached in kernel stacks */ > +static inline void kstack_histogram(unsigned long used_stack) Any specific reason to add this function in header? > +{ > + if (used_stack <= 1024) > + this_cpu_inc(vm_event_states.event[KSTACK_1K]); Why not count_vm_event(KSTACK_1K)? Avoiding header include recursion? > +#if THREAD_SIZE > 1024 > + else if (used_stack <= 2048) > + this_cpu_inc(vm_event_states.event[KSTACK_2K]); > +#endif > +#if THREAD_SIZE > 2048 > + else if (used_stack <= 4096) > + this_cpu_inc(vm_event_states.event[KSTACK_4K]); > +#endif > +#if THREAD_SIZE > 4096 > + else if (used_stack <= 8192) > + this_cpu_inc(vm_event_states.event[KSTACK_8K]); > +#endif > +#if THREAD_SIZE > 8192 > + else if (used_stack <= 16384) > + this_cpu_inc(vm_event_states.event[KSTACK_16K]); > +#endif > +#if THREAD_SIZE > 16384 > + else if (used_stack <= 32768) > + this_cpu_inc(vm_event_states.event[KSTACK_32K]); > +#endif > +#if THREAD_SIZE > 32768 > + else if (used_stack <= 65536) > + this_cpu_inc(vm_event_states.event[KSTACK_64K]); > +#endif > +#if THREAD_SIZE > 65536 > + else > + this_cpu_inc(vm_event_states.event[KSTACK_REST]); > +#endif > +} > +#else /* !CONFIG_VM_EVENT_COUNTERS */ > +static inline void kstack_histogram(unsigned long used_stack) {} > +#endif /* CONFIG_VM_EVENT_COUNTERS */ > + > static inline unsigned long stack_not_used(struct task_struct *p) > { > unsigned long *n = end_of_stack(p); > + unsigned long unused_stack; > > do { /* Skip over canary */ > # ifdef CONFIG_STACK_GROWSUP > @@ -108,10 +150,13 @@ static inline unsigned long stack_not_used(struct task_struct *p) > } while (!*n); > > # ifdef CONFIG_STACK_GROWSUP > - return (unsigned long)end_of_stack(p) - (unsigned long)n; > + unused_stack = (unsigned long)end_of_stack(p) - (unsigned long)n; > # else > - return (unsigned long)n - (unsigned long)end_of_stack(p); > + unused_stack = (unsigned long)n - (unsigned long)end_of_stack(p); > # endif > + kstack_histogram(THREAD_SIZE - unused_stack); > + > + return unused_stack; > } > #endif > extern void set_task_stack_end_magic(struct task_struct *tsk);