From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9641C433E2 for ; Tue, 1 Sep 2020 07:41:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 702A6204EC for ; Tue, 1 Sep 2020 07:41:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="h7dmGQy1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 702A6204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 02A466B0003; Tue, 1 Sep 2020 03:41:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF60E6B0037; Tue, 1 Sep 2020 03:41:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D96A96B0055; Tue, 1 Sep 2020 03:41:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id B6A866B0003 for ; Tue, 1 Sep 2020 03:41:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 724BC181AEF1D for ; Tue, 1 Sep 2020 07:41:29 +0000 (UTC) X-FDA: 77213697498.20.party02_480572927096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 486AD180C07A3 for ; Tue, 1 Sep 2020 07:41:29 +0000 (UTC) X-HE-Tag: party02_480572927096 X-Filterd-Recvd-Size: 5420 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 07:41:28 +0000 (UTC) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0817WNaH125544; Tue, 1 Sep 2020 03:40:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=h3419/CEwU26a+0SHFDvKwjc5uwrFx2HmXp4BB3PFtw=; b=h7dmGQy1iJCXPBvlTCmpgTw5WSKuIIZR1svzyiP/1aui2jbjQHM9AxTmV/96ZYKAF4HL yGYh7Kgyg1ns7FLiu+Wh1/UzwCYT1fq9SJkVWzUg/Fpp0r8FuX3DNQ7/jY+qf9EuXK8S YneqVbYvODVnaSuPILEBrP5bQkhfdAS7Cs+nZSg/mqPMYQt75dBBzo6ePeW3BiW1Rw54 qpEZFSBuFAMjCOCxyfD7UtrM5NZgtSs9JcnnxmGLzUFd7fOkUodwfUFMthRvcddBje0g eRkdFMX+MDN4mwVyjs0uwBlWaDt8WuYgQutzVVqR7jKVbFT6FC4AAvtSHw7kSju4VUre 5A== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 339hy60796-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Sep 2020 03:40:28 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0817bLDr016300; Tue, 1 Sep 2020 07:40:19 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 337en8b41s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Sep 2020 07:40:19 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0817eH4d12648802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Sep 2020 07:40:17 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 588AC11C04A; Tue, 1 Sep 2020 07:40:17 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 104EC11C04C; Tue, 1 Sep 2020 07:40:14 +0000 (GMT) Received: from [9.85.87.174] (unknown [9.85.87.174]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 1 Sep 2020 07:40:13 +0000 (GMT) Subject: Re: [PATCH v3 08/13] mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP To: Christophe Leroy , Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, Gerald Schaefer , Christophe Leroy , Vineet Gupta , Mike Rapoport , Qian Cai References: <20200827080438.315345-1-aneesh.kumar@linux.ibm.com> <20200827080438.315345-9-aneesh.kumar@linux.ibm.com> <9beaaf93-b2dd-6d56-7737-9f022760f246@linux.ibm.com> From: "Aneesh Kumar K.V" Message-ID: <2fb4ac88-d417-2bdd-3c56-a816c356636a@linux.ibm.com> Date: Tue, 1 Sep 2020 13:10:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-01_04:2020-09-01,2020-09-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 mlxlogscore=859 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009010060 X-Rspamd-Queue-Id: 486AD180C07A3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/1/20 12:20 PM, Christophe Leroy wrote: >=20 >=20 > Le 01/09/2020 =C3=A0 08:25, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> On 9/1/20 8:52 AM, Anshuman Khandual wrote: >>> >>> >>> >>> There is a checkpatch.pl warning here. >>> >>> WARNING: Possible unwrapped commit description (prefer a maximum 75=20 >>> chars per line) >>> #7: >>> Architectures like ppc64 use deposited page table while updating the=20 >>> huge pte >>> >>> total: 0 errors, 1 warnings, 40 lines checked >>> >> >> I will ignore all these, because they are not really important IMHO. >> >=20 > When doing a git log in a 80 chars terminal window, having wrapping=20 > lines is not really convenient. It should be easy to avoid it. >=20 We have been ignoring that for a long time isn't it? For example ppc64 checkpatch already had --max-line-length=3D90 There was also recent discussion whether 80 character limit is valid any=20 more. But I do keep it restricted to 80 character where ever it is=20 easy/make sense. -aneesh