From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2BCC02198 for ; Wed, 12 Feb 2025 08:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81780280004; Wed, 12 Feb 2025 03:57:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C803280001; Wed, 12 Feb 2025 03:57:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 640D2280004; Wed, 12 Feb 2025 03:57:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4496B280001 for ; Wed, 12 Feb 2025 03:57:19 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 09AD5B22D6 for ; Wed, 12 Feb 2025 08:56:34 +0000 (UTC) X-FDA: 83110686708.05.48619D2 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2082.outbound.protection.outlook.com [40.107.236.82]) by imf14.hostedemail.com (Postfix) with ESMTP id 1B2A4100004 for ; Wed, 12 Feb 2025 08:56:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=0FPghby1; spf=pass (imf14.hostedemail.com: domain of shivankg@amd.com designates 40.107.236.82 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739350591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dy80YVMUJyAT2txxDuy/VICv86/ORc1e9LhXHkUNZCc=; b=3xlEVg/rQscAbvn1/OKwufh9I5zMig3/ZNx36Ewg7IUarnoS49auSLTLWYaDp3+JdzP2+7 Vf4dE+qbKtnRfI0gYWl7IE1nfdTJ4fBYtIYBQOrf/DnYNQfuMaM55s9hErQ7zfvGatnN0f hgEYxjezPK0Zh1vCVITVwRFozIHI6jc= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=0FPghby1; spf=pass (imf14.hostedemail.com: domain of shivankg@amd.com designates 40.107.236.82 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1739350591; a=rsa-sha256; cv=pass; b=cDvwnLthVP4w4tBKoxalGTyMfBk7jECwKEo22aehRlDzwQuIaV6puqt7741SN4SyB5EPaw yo4+Kpm5SD4aa2rfD1c3nP7GUFDgr765xWxcvx2ctncCKDU18XGWxoMsvyTgLWWFOM7WZz 3Br+2OIYLOblrWQMNxrw1hiknv/JmZw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oY7B7YAtRogy6tAOrFEaBR+dCkslZOHy26KkZYcSxhOZkuAkEXJrJTrWr1qpwEkzjm8zFyiLJ+RRNJ11lSpjdYUzj6CMXty2luIdl5mgQFXkHZCgY7eVIh6qOFOr3UcStIEL/HDnGV5yH3qsoVRpOZtx4IStZp6036w7ThfQ1y7pU1ULz2dJL4OnIhUqRf9i+bqKTUOfoEuuxF0yNerz+QxcHme5DbYXCvbXtU4w6A81J3XIo88qtQnSIrRcFavlbBrOAecQ/MQwuvAHnOQHpnlLKv+1TmLETfH19Ioy9yfcfBjw+JKdqL6Pu/jBiIFRCGbZQPU3CLcSKfhZnEmjPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dy80YVMUJyAT2txxDuy/VICv86/ORc1e9LhXHkUNZCc=; b=MARD2q7VwasBV4u8sb62hz+Dj+iBy3UDdqiM4f4uuImdV8z1DxRegAScGFWvYEsrnTIZXy1Z2MA+/Vt9a1gSC5k9ATCN6hJqBdRn1YTZXDmd+zXxG/FnzPvFCq5UGyU8G0u2QozJxz0QGCQ3C+GffTWhyZI3ljYSy2Ddoc3LR46ThI4QPXrqn/29zKgR2FaYByccT0UFQWp5Gpbl2Qu/LAPkMnaK8zyoGckqekSdEyDgZKTx68bnAyZaiX5a8iTEt4R+rcjxhKrIohbWQNluSrppKE+FHXvslktwcVT3wheDc4TDF77Q1K21P9Q8VI2zOLabKTNQcbq1jYf9lETwUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dy80YVMUJyAT2txxDuy/VICv86/ORc1e9LhXHkUNZCc=; b=0FPghby1XF++lKSNDIINwYeNnPVHu3FtXxa2r5/tG3j9C7oJUXYS41sjuOgcBaxbtmIQvn3vYCjfKpEvAWoGwOXAsaSRQpBKUKy4r7c4QGQ55TdjLf/Wyl/TTDmvGCDKf8JrZV9UyWNnvMf11OtkPsU+Yrk1kQNw9sB9C2XSots= Received: from CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) by CYYPR12MB8704.namprd12.prod.outlook.com (2603:10b6:930:c2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.11; Wed, 12 Feb 2025 08:56:29 +0000 Received: from CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870]) by CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870%5]) with mapi id 15.20.8445.013; Wed, 12 Feb 2025 08:56:29 +0000 Message-ID: <2fa007dc-fb49-428d-ad71-f3eb01b73cf1@amd.com> Date: Wed, 12 Feb 2025 14:26:23 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] mm: Constify folio_mapping() and swapcache_mapping() To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: David Hildenbrand References: <20250210212142.4002210-1-willy@infradead.org> <20250210212142.4002210-2-willy@infradead.org> Content-Language: en-US From: Shivank Garg In-Reply-To: <20250210212142.4002210-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0162.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:26::17) To CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4262:EE_|CYYPR12MB8704:EE_ X-MS-Office365-Filtering-Correlation-Id: d62eb6af-bfbc-4f49-1b9f-08dd4b432361 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TEkrYXQ4MSs1bERrMW1PQUxydUV4ZXBVb1FsYXZvY0d3RnBPdlJZQ0QrZGdh?= =?utf-8?B?QkUyRy9ZV0QxT3B3Y1cyMVJoU3U4Z3doSFJPN2FDRnJjcmFDTWRIdEtySW83?= =?utf-8?B?V2ZmSVVGemR3K1dXUEhOb0F2RmFFS2swZUxrK2hOKzFKRWJ6TlZKRlY5dktX?= =?utf-8?B?UjM0S29rNUZmMUxFdjVrM1d5TFRMalR1aUFZcXNFUjhGN2YxcmJWUWFPOTBO?= =?utf-8?B?MmFQcDdYQnkybVFiN3Y2VWlUZ3VnNm8zUWh3aDI3aDh2R2MvWVgxUjRCaFdI?= =?utf-8?B?STBva2RrRVpiODl4bis3ZUJhckdxZ2tRdGFSUjNtVFU1NDIxc2hJWHpvUFdF?= =?utf-8?B?RjdtTHJ2U3dlTGJrek9kWGZKRG05NllycmdLQ2ZTZ2RpazQ5dlNScUJzeDEr?= =?utf-8?B?cjB1N2VLeHJtdWdZeFozK0NoQTk2RjJqOFppenV6Ump4K3RpeEhiOE15T0hh?= =?utf-8?B?c3ZSL3h3Q3lnUlVGMVdhcExwb0ZoQUtRV2tjRHpEU1BKeHB3TVE3MzdmN2Vl?= =?utf-8?B?Nnp3ekRqbFNtOTAxVS9rL2lIeG5KWUxTUFgyaGxObnEzUHYvZnA2b1h2blpI?= =?utf-8?B?UlJncWJjSE1CNXNYTkZJc2dkRGdwWkVIaHJnV1RZWmZBQ2daVlpTRVc4VkZY?= =?utf-8?B?UkI1Y0RNcGdzeDh0TCs2ZENkaWhCQzFPZklPcFV2MHhJV2FXZ1JoMmhHb0tN?= =?utf-8?B?TTlaYW00RUdGaWR2SGU5cEFCWWcxUG1manRvZXM3SkZFNHBLdEZuc0M5aXNC?= =?utf-8?B?Tm96ZlM3Nmx0NzRLUmJpczdDNlJYN0d6R0ZXV2oxNVRxTmpPd2JPcTFWanBP?= =?utf-8?B?SDgyZWxGalV3UFpCVEdkNXh1ekNqZDZSeWU0ZXROLzlEa3VjUVdjc1MxaWNh?= =?utf-8?B?bGVTVHZFeW1uUDltYk9idERXZU95NHFXVDBFS1ZLVENpWksyemJjbDdnTEhm?= =?utf-8?B?QjdrbS9NdHhiSjJndnM0cFFoR0t5ZVJWdWZDWUxQNHlpMER5ZUhjOG03Rzl3?= =?utf-8?B?alpPMlkrTk1EMDM5MHArMXZKa1hxcGo5TXQ5RXZ5ZnRPZ3p4QmdVbU85dks0?= =?utf-8?B?eFRqci92NWpxSlhtcGVZbUVYeFYySlNRNGx1MWQ3bnZzdUtaNGNENlpsRTdn?= =?utf-8?B?U09xbmNoK0d2UkM4cXRDYVVLSFU3VFAwQUlxbDNLVy82emVYc0pqZ2JDeHdp?= =?utf-8?B?OWFWUlRJMC9GelVkTlRmSEdWbEZEK0hCMkx5cm5KNGJMbUcwb0prM2FnV2FD?= =?utf-8?B?TlBrWnNMNmJxVVFmcXFVam0rV0JBTFpSbmhudDNXOVd0WjUzUEE1RUdCYktR?= =?utf-8?B?cFZBOXc0eHJzM3NJKzI3QjJiOGJLSndaV1ZjeGIwOXFDazVQamxKNFRSVi9k?= =?utf-8?B?MEE3Y0pvWWI1SnZrQ1NkTm0vRVRKdjlSemYvOTdTWmg4MUFDbXIwcHlUeERB?= =?utf-8?B?UWo4bVJtYS9Pd1FaaEllNnRjY25SME5IQXFTRmtYcW5kbCsxQzY0SmdQSkt5?= =?utf-8?B?dzBNRmFyUGxCVEpSTUNWaXd2NFJaeVMydGprNXRsR2FGc1VzRjY5SXZzYlZk?= =?utf-8?B?K1lHMTcvMHpORFNnQ1JjVVhOKzRibU40MlFQOWNpYU1Pb1llUXBWeTlCeTho?= =?utf-8?B?Sm51VjFsaGUvK3c2MWFNY0ZlRmVLb1A1SllzRThsUE0rdjJxcHBoR1FLRzZF?= =?utf-8?B?cnFEOTJNT2dpTUt3cUtBbmNHYllMUnUvUDdIYXUvdmJONEVmb2QyWndoMHdu?= =?utf-8?B?em54ejdYZHJKeDMrTkN0akR5V0lKUmwwVVN1dEZ4SEwvVlN2VksrdmNUVVp1?= =?utf-8?B?T09XdkRSUWVmeFFnNlVGbXhnbkZOR0VESDUwR044UktaZlRhNlNNQW9LRVlU?= =?utf-8?Q?uZUSOhp/NamGM?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB4262.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akgvM1QwMlNtVnJQZVExU2JaQ09WQUdNZ1lUMEtMNHJYYlEyeG02cmo1aDZa?= =?utf-8?B?VGR2aTgzcWhiR0VzS0o0MnVtNi9SanoyNTRLbXVBS2Q0UWhXRlFuV212alpM?= =?utf-8?B?QWVZelFEcWJSbzZqNG1taVlqVVppSUJkVDU3S2VvZGRpUUxRS2pxYTRSVTI4?= =?utf-8?B?OWdLRG9yS2w3dThwUHJ6ajdDUGtBVXVVTTArSHRvTitITURRM1lIT3U0ZGc2?= =?utf-8?B?WUpBUzk1WVBWaHdVck9OQ0F5RUx3Qkh3Nld3amF5eTUzY1YzV2NTVFZ2aWUz?= =?utf-8?B?Ty9sWFByTmcyTFpnODZueXRXdDlhYkZLQjVWK3l2ejBGWGVadUM1UzNSc0RM?= =?utf-8?B?K01ydWJVRm9SKy8wanBWSVgvUlZmOWttaVNKQk5YOEVMSFFPVTFHVVAwRGhM?= =?utf-8?B?dFRSNVJERkpIRWdMeWxhSlIySDZweUxlR2pocEMyTFg1a0tHS3FjUHl2R0pI?= =?utf-8?B?bUtBeWF2VmExbEcvaHcyVTgzL0JUZzk0YXl6Z2wrT3p0cTdDc3RtUzR4QWx1?= =?utf-8?B?R1FqRGdjNmN6VVVxUzlFVDhZb3FPNDBSSUp6aDlwaytkZ0cxcVA3TFJqWG9o?= =?utf-8?B?T1hZTk92N1VGNWtrL1FKV2c2a1Y2MDFHVzZITGZ4WHVuNHpGTnlXWnhzeW5x?= =?utf-8?B?bWtWRTd4SjJUaFZTNVFNOXI2b1VCWmtmR3RpVWdtbkVyQW1VSG9TeUV6K21Q?= =?utf-8?B?cmZXVUJmZDhpMDVzWUZOQjBIMldud3dWYWtpSGJXaTFlYXp1RFdZSW5zVTgr?= =?utf-8?B?ajhzNnR1aEswWHp4dmIrVTV2cUNNR3poMWpsaFU2YUx2ZnY1TVY3ZEJ3bXIw?= =?utf-8?B?aTlhSEMvODlIVjh5Rmg1VjlHSHlJb2k0SDZzY3VpN2ZrTHFpZC9udjBYdENj?= =?utf-8?B?ZDJ2VmlpdlhMWkxRN0s2MWVrd1hsdUo5WFlVV0tjZEpZU29aaE85cTFpK1pJ?= =?utf-8?B?Zi8rbmpMbmlEYnY3SEthYVpuL25HTTlDL0pSNG9jUmhOejl5ZktBZTFaaHRj?= =?utf-8?B?dVEwNk5hNmIrZk5ZL1hZMGxvY2twSVpuRWhwUjV6RjZLUTJWZ1Ewa1VHaTla?= =?utf-8?B?dyt0bWNsWE1tS3JoM3h0ZVpFZ3VYRHQ5QjE2cDAveUxLSnZrRkVhTllHVElG?= =?utf-8?B?OXBUYlJreHY4dXFoU0dkdjVocWFQcUFIQStpbllodGwrL2JMeXhyeC9yTzcv?= =?utf-8?B?QmlrNzQzY3JNcDBxdGVrNXFBY3FqMUUyQ0tGRk0zZHpPMXNWcEhZaklPUFpa?= =?utf-8?B?TnhEOW9OTGx4d0t6NERneTladnpSMHQ0ZTBkZFkvdWkxbXdZeG5PalJ5Q05a?= =?utf-8?B?Tk5EVzk5S0JHWUJHR2pZcmZJazFLYVBQY0hPSG1VbEJUUDMrUWhqUXpwQWZF?= =?utf-8?B?WTlCVGZsOUNUeGdIdHAvdmNWVHZ2dHByRXRCQUs3MExIbmx5ZUR1UWxRTVNo?= =?utf-8?B?NHMyb2NTQVJuL25peklHVUQ2QmNyeWpZeXp1b25BOWZML2g3MDFtYlAyakND?= =?utf-8?B?eUlROTdVemVOOUE0WlBjbDdaWWdYaENCZFJNY0xrc01tcnorYWdBVDhzaERx?= =?utf-8?B?K2xyQkFQK3R2VFh0ekVaMGZUd01SZHJWWTQwd3lQeG9od1VVaktuZ3RRVlBt?= =?utf-8?B?VFNlbHhydGtWaWg1OFY0YUJJT3h2VlA1N3VQSGdicmJpRWZYLzZJd1RWcmpv?= =?utf-8?B?MTRNVDlzYkRLOG05QXpCc3QvekpZdXo0V2x4UU1WZUk3clF5bUpWbjRQU0s3?= =?utf-8?B?SjlJRW9Vd01ZcXRFSElFM1J0elpUTENEczc5NDk4ekpMSit3YnNwdmo5ZnJp?= =?utf-8?B?MFZ5MWl3czZDVFBuSUIxRmhScUVkY01MZmNnTTF6ZzVRd1NPQm1jdEpwTHUr?= =?utf-8?B?MU8zcTE0anlzMldkelFPK2JmZllJUzgxamRENzFCRmdsaWVjRW5XZWwxNWor?= =?utf-8?B?SGU0MlpoVW5ITStoT0NzM0RXVGhESVRMeXlXelUvWjArU2JNLzU4UVpmZWdJ?= =?utf-8?B?cFIwbGg5V0ROdXJkVWlpS3V2ME5pUk95TktIZGt6bXgrbnZva3FYQ3ZRclhP?= =?utf-8?B?UUFmYmhBQ3BTT1NScnZjck9tVXpVendFRzJSTmFDdHBGeURsTGcwdnNxdHZR?= =?utf-8?Q?QcVB5dd2Eq9oExKhfIBDN6xAS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d62eb6af-bfbc-4f49-1b9f-08dd4b432361 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4262.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2025 08:56:28.8408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OyQo2gm1RZzsldyKZuC29lDHGHABdwjmnBpHg+pcvylR6MoETDLrhP1Hikl+cQqMsNxr3Ifradz5foxUCqGc5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8704 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1B2A4100004 X-Stat-Signature: xhqtu5t6hunns9rjmgtmcjpfizzckeo4 X-HE-Tag: 1739350590-87475 X-HE-Meta: U2FsdGVkX1/Xhs+xmgC0qgmMMkxdFgyH9clvxvJJMkR80Wn08+MfWZ3oqUjEqEFb4vSZw3EZLXx0l934sEO6JYheVdbljAI6BWkMAgaBFh4h6OTNFfJOrdN7BzlLC81VSCx1NL913jE4Z/Vtif0otXe5RTbkVt4EHpcA/7SjP+cOTKAvgD3nlP6efTvdPBOcCDQdFF4YXPcpGne7WOPw7HaB4KmiDskUVKEEA5LRze3gA/8zlQ3kaxDxzTv10yB+t2utlQSoPTBhK6e+8XPtA8tnehpjZ7doqPBxLT0wI1vys3U20iyd9K2FkKVPnR9jVLbw2Mqvfk6H5OlDRnJ8iQlmluqsU8H2yik7IGkIijQ3OPouSFqA4G+SMW5uqDOzvp1QEM9NdlB1a2aIlQSbU0r1Zf7N22ltZ0SEMod0RU7MmoxDrwbAgg70Isu5XeFDYDfjiJsWsBmuES1qrzFLPNooP5VPMAYaoAaKguUbtF9UcTTqYsZ2hagpexXTCFNgc53oGlnu1HSqzNxc/tyh6sBt1GwhqHfCI92PIGaogzNE0vN633dmGgVa2OLcdavdSnUn/mRDctMBDMIgfN83WMVfWUCY+HUUb0L+W560O3UlxOH+LnPRH/IE4k4oATL42SWR/TgrIhKOFkjcsiZ14M5vSGmTZ1+sYN9lkEI1WfXxdVK+qUzUKdQJVzIUxwwHDbQKilKxkuc0Zh1uCp60gWtJEROpqonFNCECkBtOSrgAbFZASJ0o1qPyZhyiS4fWI1St8LoTQBm0ow1WgLfutqM4FarPBGOHM7jWhtE0Nc+1ifPSJo96/LNGwDLjZmBEmDEm0N36lNjFFC9p9rMXJK+3QQGLj+JSXTC4sjnL2ZvPo/t3SXqGU2dZv5o/vqmJXKKvc9TaMA6o/BDPYhTtYhdMEIlgpLQrDdNg/NlNa+r6i2kSHXMVwPMTZcgYolH+oFUMD+N3obg5SWwsgbO 8V/0p4YO cqVUDXrUq4vsGnYZJ2SaLBe1SD6pDiRlGHVCwRDy/jBmjAdu7fd5urWw8cR/67CgV5ho8CuJDrokS931eTqYZ13MfudyBQt8jumQ9etcl2Q7WzJGIWM7950SF6or5W5wYME1za8YnbkpkR00c0WJ595JRmvHOeQtxwdyx7VgK1LvWFTO0/cpaxjj4L9UHwJvZoTa3c0gKPKtTzz5qHu1qMtFopnIj6eD5f1Ft0ZSyQP9yfZt6kcsM9cs1Xm90/W/uTmkeEfBLzn0//D5g+ByGPUBkCkFLRyTeJsuzTn0+GmILKAtrKeJo9jELnYDV3EqthtFM8VaRjONtsPbIRUPbftuVqORhFgwdbmAnuBR67skU4LO0hrFtrcupTrO/kveEPRSCDmGKX3lM1Cj79OMc5aBwhXlbgTScoJbxEOZtMX8Avw6jhmmoInd5NdNKgdGLMMV/4RBvsM8fHos9M8/liq58Xmjhe7CnNjDWE0qjYyWoRK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/11/2025 2:51 AM, Matthew Wilcox (Oracle) wrote: > Neither of these functions modify their argument; make it const > so the compiler knows this and can optimise accordingly. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 4 ++-- > mm/debug.c | 2 +- > mm/swapfile.c | 2 +- > mm/util.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 47bfc6b1b632..8a9b2d201706 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -532,8 +532,8 @@ static inline void filemap_nr_thps_dec(struct address_space *mapping) > #endif > } > > -struct address_space *folio_mapping(struct folio *); > -struct address_space *swapcache_mapping(struct folio *); > +struct address_space *folio_mapping(const struct folio *); > +struct address_space *swapcache_mapping(const struct folio *); > > /** > * folio_file_mapping - Find the mapping this folio belongs to. > diff --git a/mm/debug.c b/mm/debug.c > index 8d2acf432385..fa3d9686034c 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -67,7 +67,7 @@ static const char *page_type_name(unsigned int page_type) > return page_type_names[i]; > } > > -static void __dump_folio(struct folio *folio, struct page *page, > +static void __dump_folio(const struct folio *folio, struct page *page, > unsigned long pfn, unsigned long idx) > { > struct address_space *mapping = folio_mapping(folio); > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 6e867c16ea93..ccaed8c2f761 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3658,7 +3658,7 @@ struct swap_info_struct *swp_swap_info(swp_entry_t entry) > /* > * out-of-line methods to avoid include hell. > */ > -struct address_space *swapcache_mapping(struct folio *folio) > +struct address_space *swapcache_mapping(const struct folio *folio) > { > return swp_swap_info(folio->swap)->swap_file->f_mapping; > } > diff --git a/mm/util.c b/mm/util.c > index b6b9684a1438..682ecdb1b1c2 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -845,7 +845,7 @@ struct anon_vma *folio_anon_vma(const struct folio *folio) > * You can call this for folios which aren't in the swap cache or page > * cache and it will return NULL. > */ > -struct address_space *folio_mapping(struct folio *folio) > +struct address_space *folio_mapping(const struct folio *folio) > { > struct address_space *mapping; > This patch looks good to me. Please consider Reviewed-by: Shivank Garg Thanks, Shivank