From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCFEC48260 for ; Fri, 16 Feb 2024 06:34:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55AEE6B0082; Fri, 16 Feb 2024 01:34:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 50A5A6B0083; Fri, 16 Feb 2024 01:34:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D1158D0006; Fri, 16 Feb 2024 01:34:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 29ABE6B0082 for ; Fri, 16 Feb 2024 01:34:36 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 91CD5C48FF for ; Fri, 16 Feb 2024 06:07:37 +0000 (UTC) X-FDA: 81796635354.08.D695472 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf10.hostedemail.com (Postfix) with ESMTP id C700BC001E for ; Fri, 16 Feb 2024 06:07:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JSaJ5yE7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708063655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3jfwmJzlihpeqJsyg1QU7sAxw4D/j0HY4WrYv8mMarg=; b=wnqydHkYD4pOEM7ulD4Z56IMh4giL2oSutChneeCiRoXo7fl3Wx0oxT0y+JOFXo4yfNrrd JdH0tG0E9HuTaWpPk9Dglyzg8xR32YWp4DfhVOmwub1ue5RygKK3zwXPcRDEOtLbw8h4+i dQte/1rYk2XVsi5CM1J4Y0poSGgpNv8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JSaJ5yE7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708063655; a=rsa-sha256; cv=none; b=KWT2x8FLJH/Q/TUGcnm1ARlQ56Ft7pXm2wCKj0DdnapS7R+BedX/7sMfpUZ3/GuWQmNb0I 0xUyNMVajJ9Ic10zfZa8/70cK5loPmFb8mTbk995/dJi7wToau5ANezM6AlOfyFCc6Cohg +PQpvM1y7C3oS8MXiqMMElTYNCmsNno= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-603fd31f5c2so23456587b3.0 for ; Thu, 15 Feb 2024 22:07:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708063655; x=1708668455; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=3jfwmJzlihpeqJsyg1QU7sAxw4D/j0HY4WrYv8mMarg=; b=JSaJ5yE7nKkZkZIBLxXVQM39Dz6XH+0hwy/Z82+XC629LhwFjAttC1kkM3GUS3ZRFQ 0GuH50qnsBB+5F5J12CrKb9cdacI1Q5ztHMImBYwp2IRExeqpslaCR96f2/Ian9OYQN4 cdY/b1SMjiKM9HQs7YPgeCrRwDT3mOIWKYOjU90qUVjtWmqFFjAYERdO+vy64cgw2zyl 3mHgy1czNLbAET3dJWkcJESqjT8QmpjLgRrQG4WVOoYrQqDgvPSF8epkzaQggoX4LpQa NokgBtgk4fJvgWxDIYx8aDN+cnZs3JC4ZBMe1u3/4WKj68w/5/Si1AKYVTit1GT8nu3h eH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708063655; x=1708668455; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3jfwmJzlihpeqJsyg1QU7sAxw4D/j0HY4WrYv8mMarg=; b=j5qZCuanRvRdkAIr0fJzpMQs1GLhkXXQxc0cTqG9E52F7PgFp5ZK9MtepniWQtJjEz Jv6jYbqYzYywMI3hG/amuwQSGX8YRWzPPIDJ/uqzXIg6ZxF6DKOmM4mWSfSiyr55WiTr saEoaXTVvJDFfruQHZnYj1riOE5BQiBIZSxXC4O863WbQS0Jp4E7Vo+pLskrUrnfHhej TFAwvvVWD3cwqzCh+CQoNnIhSb6hsNrnJIuhD5qcdQeJkj6YwVLYFHsGq8fj4xWAEggf 6a8hnYHXbNqWXjCEHum2znfE5Xec5i7wng8G03GIqGQy/Tyhjh9a6ZFPAI5F+g40kfGq 2zoQ== X-Forwarded-Encrypted: i=1; AJvYcCXyMbrapQrjQy8Qh7eZF+8ymwcNoTPG1ghTQWoSusg769JmjhbODXyHF3QdprHiE7iBUu/KtC414PWHpwkQjBSS+OA= X-Gm-Message-State: AOJu0Yx/JhHRZZTioU1gGVciH04lFuzoitb/FPxPd75sej1MB2V5K5Fn uhWY5Z4VZNgKuK9Ne1/mfrtYu0pO72KqIYNDXKiF8reanKMU0tYnXvDsWNRWZQ== X-Google-Smtp-Source: AGHT+IFWwzWWjeXWKZhFQnt9h+ixZ5qv2MVfhWOavvb6T0AnfYUNlaTcCHxs/e9Uv0QVVC9gJGLerA== X-Received: by 2002:a81:52c9:0:b0:607:e909:beac with SMTP id g192-20020a8152c9000000b00607e909beacmr2044239ywb.18.1708063654791; Thu, 15 Feb 2024 22:07:34 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id x190-20020a0dd5c7000000b00607fd619a78sm79596ywd.37.2024.02.15.22.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 22:07:34 -0800 (PST) Date: Thu, 15 Feb 2024 22:07:32 -0800 (PST) From: Hugh Dickins To: Christoph Hellwig cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH 05/20] shmem: export shmem_get_folio In-Reply-To: <20240129143502.189370-6-hch@lst.de> Message-ID: <2f97998a-91b2-1db0-bcee-824e38e98cc5@google.com> References: <20240129143502.189370-1-hch@lst.de> <20240129143502.189370-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Stat-Signature: usi66gro6t9sackcjkx5hmzn5oskq3fz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C700BC001E X-HE-Tag: 1708063655-545797 X-HE-Meta: U2FsdGVkX18V4DpBKewovVvdHF5J5/YX+zLh/KrX0nNmqs2k9It4ed0CMf56h8+C9sMPHYK+AbeYLqxwanPfiZ1TrWa2JN4Q8eLgWlejmo1MPsu17QUGIZfhLyPQmIH2K+SROafyoZdJEuLotx6mX/bim3+C/hbV+y2vVyEEVqx7dQ4lr7eC00DAp86K7zjKeKgIJpXGkVjlYTWKYrIQW6psgfRrkRu8AA8u/hqb/LIOnqgY8BgzGYjIHXCC+XKoy9Ba7M4x5t7LTk3j/POSoH6zqG8Y4yelvMmR8nm/LEXsYPxPPZDEiU0QVq1c6Peu0sC69qhIJksOP9Rp8SErZdyfObQPqDC3Axs54f7I4cXBt6atsG5roZlGBkYBTFW6NBB6eSTWNsif00zUiMO6hz//sN66U3dlAnh/+V1818Dq+MOmrWIv5IGOXnK7eZoKmp2a5gGE58zhL+U+eYESF9RHSr8QWc8peTttW9rD1kcZqWIP5VelW2T9t1aKe23CmJng8bFXQP5b10elAhPPA75lkPgur3KRzUDT2BcE1SWmZZB22nOVJJCRj4g8yY2/gGyj/KUNdiAkdoK1uFT2AofNiNfqHhUFI24tMnQ9qNmOKqxSJ0JWgAryofq/w7gqabpv8iexQ6Ui4z/mbC/XTS+PVWqPYuaiDaRJf4GjVaDU+Tjn4ZV9XOwqWWSqhedhGrushW62wZMdKyyH4KzaZRo17Zb2ouR/niRugCHTlpB5PQ20ctOMcwz/sG1PWZhD3+e+p6nMedGPNAjf9MBDtMX1E/oisLCcL/r3i4z+DZdTt24I3bWQcB1XgAxXbuHRNqgL+9lngygKd0ahwrIWy8csQOSCC3d4BicF3L6x0v9pJUmBUDAv/kt7QmsUC0Lr9aWhFBCoygI+KqD7ZDdm+MofgBEUS3nzyA746OOLVj2HIoW/rbH4Cw6tluM0GF0K3PKw6WZyOHL2w51cVqm RCVFU1r8 p50oqdjg4hIrmYHuMiEb9ckydkywt7Zd2ZC1iwbgXMW5KRZTAu9hrZBWGNwTYQUQLh/CTARxkb1V7bXBjn/cMxw+OS9I9/sqVUz2YT3tY8Hxy6b8tOet6gUTjpy6VQONk8kW0xUnoe3coeuMEwWtv4uEGA7w/ETnhZi+8WnY2smWyeZsmp0Bp8izlPoGBQ0ya9WGuhop+P4CAuXuYxfg/Hk78i4ePO/hJ2vTnx6FdO+vUlGfNtChWWdTUp1Mw4gNpOqvvIH2HEfgcu0QTQZ0kR9TiqURH9RbjNVBud/hLSSIObbiX9nP0PNQEOD4jezotuZNNnW9D3R+HsOkry23RpcslRuUw5J4r0bkUXmVvYN4EPVc0FxjvD3Z+O7m/zrps2ENmiR4BF0ggi7TWYq0MVtABztAObiIHloCGhlH7whAJvZvhaHTyp1QIaMSHzTQ+aovquqMO+2rSr+h2dhMsXCAYu9TaVaeFavapZQagA7ukwVPYdWECbOdp04rQUoiZUQ1HJXRaZ6AO9wM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 29 Jan 2024, Christoph Hellwig wrote: > Export shmem_get_folio as a slightly lower-level variant of > shmem_read_folio_gfp. This will be useful for XFS xfile use cases > that want to pass SGP_NOALLOC or get a locked page, which the thin > shmem_read_folio_gfp wrapper can't provide. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: Darrick J. Wong > --- > mm/shmem.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/mm/shmem.c b/mm/shmem.c > index ad533b2f0721a7..dae684cd3c99fb 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2137,12 +2137,27 @@ static int shmem_get_folio_gfp(struct inode *inode, pgoff_t index, > return error; > } > > +/** > + * shmem_get_folio - find and get a reference to a shmem folio. > + * @inode: inode to search > + * @index: the page index. > + * @foliop: pointer to the found folio if one was found > + * @sgp: SGP_* flags to control behavior > + * > + * Looks up the page cache entry at @inode & @index. > + * > + * If this function returns a folio, it is returned with an increased refcount. If this function returns a folio, it is returned locked, with an increased refcount. (Important to mention that it's locked, since that differs from shmem_read_folio_gfp().) Hugh > + * > + * Return: The found folio, %NULL if SGP_READ or SGP_NOALLOC was passed in @sgp > + * and no folio was found at @index, or an ERR_PTR() otherwise. > + */ > int shmem_get_folio(struct inode *inode, pgoff_t index, struct folio **foliop, > enum sgp_type sgp) > { > return shmem_get_folio_gfp(inode, index, foliop, sgp, > mapping_gfp_mask(inode->i_mapping), NULL, NULL); > } > +EXPORT_SYMBOL_GPL(shmem_get_folio); > > /* > * This is like autoremove_wake_function, but it removes the wait queue > -- > 2.39.2