From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Usama Anjum <usama.anjum@foss.arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>, Dev Jain <dev.jain@arm.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Mark Brown <broonie@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v3 5/9] selftests/mm: check that FORCE_READ() succeeded
Date: Fri, 23 Jan 2026 09:20:03 +0100 [thread overview]
Message-ID: <2f84676e-e0c5-4355-9276-b275c75938ce@arm.com> (raw)
In-Reply-To: <ab021f50-60c9-4d5c-99a0-255ead6e2288@foss.arm.com>
On 22/01/2026 18:36, Usama Anjum wrote:
>> +static bool populate_page_checked(char *addr)
>> +{
>> + bool ret;
>> +
>> + FORCE_READ(*addr);
>> + ret = pagemap_is_populated(pagemap_fd, addr);
> Very useful. Maybe extending FORCE_READ can help the entire suite?
I considered it but one needs to have a pagemap fd around, so we'd have
to open it for every test that uses the helper. Maybe such check is not
so essential either (see David's reply).
- Kevin
next prev parent reply other threads:[~2026-01-23 8:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 17:02 [PATCH v3 0/9] Various mm kselftests improvements/fixes Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 1/9] selftests/mm: default KDIR to build directory Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 2/9] selftests/mm: remove flaky header check Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 3/9] selftests/mm: pass down full CC and CFLAGS to check_config.sh Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 4/9] selftests/mm: fix usage of FORCE_READ() in cow tests Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 5/9] selftests/mm: check that FORCE_READ() succeeded Kevin Brodsky
2026-01-22 17:36 ` Usama Anjum
2026-01-23 8:20 ` Kevin Brodsky [this message]
2026-01-22 22:18 ` David Hildenbrand (Red Hat)
2026-01-23 8:17 ` Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 6/9] selftests/mm: introduce helper to read every page Kevin Brodsky
2026-01-22 17:39 ` Muhammad Usama Anjum
2026-01-22 22:20 ` David Hildenbrand (Red Hat)
2026-01-23 8:25 ` Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 7/9] selftests/mm: fix faulting-in code in pagemap_ioctl test Kevin Brodsky
2026-01-22 17:43 ` Muhammad Usama Anjum
2026-01-22 17:02 ` [PATCH v3 8/9] selftests/mm: fix exit code in pagemap_ioctl Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 9/9] selftests/mm: report SKIP in pfnmap if a check fails Kevin Brodsky
2026-01-22 22:23 ` David Hildenbrand (Red Hat)
2026-01-22 18:25 ` [PATCH v3 0/9] Various mm kselftests improvements/fixes Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f84676e-e0c5-4355-9276-b275c75938ce@arm.com \
--to=kevin.brodsky@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox