From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE80C3ABA2 for ; Mon, 16 Sep 2024 06:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 926A16B0093; Mon, 16 Sep 2024 02:34:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AE4E6B0095; Mon, 16 Sep 2024 02:34:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7773A6B0096; Mon, 16 Sep 2024 02:34:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 583CA6B0093 for ; Mon, 16 Sep 2024 02:34:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7119F40131 for ; Mon, 16 Sep 2024 06:34:19 +0000 (UTC) X-FDA: 82569637038.10.91BCCC5 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf10.hostedemail.com (Postfix) with ESMTP id 398F2C000D for ; Mon, 16 Sep 2024 06:34:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=XPMjxyGx; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf10.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726468347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=43RYhMal7eFWDuospxEJRYGHTyjhRWaw1O4eSzjv+Zk=; b=yocbANHJ9VYKSFJSObr5j6ygCSFLo8iGcxmD9n+YQyu7qbKCot9P5PQfkNvvPtD8/qsXzL 3/1Qj5nk/KCqUnRA5RGEGOtw5z2QWcnztkT+eJAJXILdxwWRv5KX79y0s5N2LfJUZCOhpU Q9eN7kG4YKn+3a1+8SvmEnUHVNEBGWM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726468347; a=rsa-sha256; cv=pass; b=SxHRTeZp8AjjTw4JZgQguBTdhT9KB6A2oJwZ1qBm+6tpmnbCp5wBFosRlL1eCVw2eXbmk7 0E0gobC5nu0aP4++/0l/guUXk6KQrtC+oIumwrZ6HyxVU2gRuwEycQ06rQeeWRrXIuJEcF jOLX0CPTr7bfCZpTJB+6UHcOD4hsdio= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=XPMjxyGx; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf10.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; a=rsa-sha256; t=1726468447; cv=none; d=zohomail.com; s=zohoarc; b=OGvm7ygvNmrVcMUH3uk/1Ygh3LpR+kRy9v3hEP5a6stjVmEdIiDJDGxkRahnXF0y/ynakkv1s7aW9/UfP3dIIwnHoh2kvlXYZimvf36nJEosLXum9tA3A0SJ3pa0/YEtnGnC1WnZrb7wIm988Oce/ODsZl/5LQ2Arxlu1s0Rjxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726468447; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=43RYhMal7eFWDuospxEJRYGHTyjhRWaw1O4eSzjv+Zk=; b=HLH8GeLCiQUMGzT2IUbSDAUCxN2Yv05AtbeO++lgcTifwz+xA/MOGGZF5G051GM8AzHlePopRxbznSVHOgf1NsxauBHyGYhvkwtl1L7GPo3X2YCbuVIu4anyLx+W27l1JpxCgXy4No6AupnUks34xn9r1h1UiaX6EchZbriSIN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1726468447; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=43RYhMal7eFWDuospxEJRYGHTyjhRWaw1O4eSzjv+Zk=; b=XPMjxyGxnAy9z6Czv46dQNk07NPfKnuQEF13B4wcGAHKvMSnxDS9N8xYdk0KayQr 8sM4XHLweL4+BrPyoPK6xSyUQwoiNs30NauhM7XKYxhKSuOKWwP9DV78LNb276b7pC+ LXuPPO6Xr/XYyhImxAtJKPBDm/8trc+q6vXzFGPY= Received: by mx.zohomail.com with SMTPS id 1726468445372886.5813772455704; Sun, 15 Sep 2024 23:34:05 -0700 (PDT) Message-ID: <2f6cfc9b-4f3b-4f64-9c4d-63e3453b3105@collabora.com> Date: Mon, 16 Sep 2024 11:33:58 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found To: Shuah Khan , Andrew Morton , Shuah Khan References: <20240912103151.1520254-1-usama.anjum@collabora.com> <20240912103151.1520254-2-usama.anjum@collabora.com> <3b700650-159d-45ad-91a3-59fca3019766@linuxfoundation.org> <35f21581-71f3-4234-9b03-dd3e3bda664f@linuxfoundation.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <35f21581-71f3-4234-9b03-dd3e3bda664f@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Stat-Signature: 1x1mnxj4hfx7ac9i5zkd999s9i8qtgsz X-Rspamd-Queue-Id: 398F2C000D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726468457-355265 X-HE-Meta: U2FsdGVkX1+1xW2PfLXfw7S/8dtucZUouKFm/25k7b5RopBp+T+ZZPpfkD5O+Hh/mGkT21adf0COiKvYZTtgMLCP25U25w+j2Wv8IN6Rdgzry2BjfjCk7EQFFUsVbFati8LrCnYS8OGmHeFePv6sAlD0AS3EUBW2V8ZZ5QKxd6vzEdRxgq5seTrtpW5zGvsJcTEqVXH0nfBl4sFiViMC6EGXfGYa4v7QaLLvcBNuclnFM49CiBV2gqQgoJYjmDDFZCmFVZXuHozPkbRFLlijYcGGI8RFZrjdE2CCIGADpWcXTkzB5mDhOOuVXs4e4HQEg9k5fgATMWQg852Bd0eEgoqATlRvMWrCTKvYaiRgAd27dBu9EjZcM9hIQ3xOJHKgi9+SMSrinS50bl8d5fGw1WClZeUWa6NQ6yWU3DqwlELSJ7/oYAMIGGQPweC3zohm6qMmmUarECHXlM42espfIepjjc9/unbtn2wagIGdgStalnUZr7spDh9oJagNCY+MkHIkDwVhe0PBlf+7GX1N5+i1z8Tg/mbGA7w/yJWwc+Zsj+kulDp9nHWjoBOeKWhNGjioBD6hpMJjg+JIBT2JWk4GB2Hq/hPRyQkTWFnsa0nX3qoua0ta/4+N00YAYc4p5Bkw56O6FyjHI1SU9NAji6juhWZI5b9Pg3I7oSYkSei7qQ3obmBF5ybJ/SyzlYDgddur/+mjfYOC6NONNNUbkGQQC+EfMtP+oDMZs9UAxLDqdcbJ+t3mymvfA1SMBjvtVDeG2TZaZwd0ee4LVHrkVbWbBuUzvycU/2Z16eosPCkH6RTlBAumHePXg4kxPHYClG3GjSsItinMI8FLTw6SuG6F6HSAxMt8+rDlaDQRNLgUB+OIQusC6Lm+TrsUdZx63yEmkH6R0mBBLFSrAS5CJtn3VWf2J1mHRNLhG5vywNlvejo6T9DISfe4FTlFHKeDAi6hzMhZ8dGK3aa/t8V zPPRzms2 6thIqOGOdbdaB+YcALgb+JXp77Ou0OfzZHBEBI78wf1DNplPw1Izz8RGsKGDapxKTiqW1BBssHHQ/d94aMgwdbZ/RBF3nnfuWJ0Bv+5zj/1AvnE+IndigFinmbyBRmOvbTaVyiDgyINz6I5Wy90FgdW7oBiGWLlIiGQl+dThxNgils0PLt1QX0s0/LZskAXIso6vutEGMbEKcNBrj3Q3BFO9i6lgmENt+bYDm7Q/2RSUcF9rXIMJc5bDB6YhdneH/qzOvtnIUZZGcv5FOL+0jKgSCHnBMer34Wu5iSMRSyyAwBG0c+EJm7dK8dQps409L94I6kes4zP3mIg9tHPmzk5uWsi7z6F8kl5Usca7lhV2NKX67cIRIWiwCYJ7zO2u3cesKitGIuAQn7mI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 10:28 PM, Shuah Khan wrote: > On 9/12/24 10:10, Shuah Khan wrote: >> On 9/12/24 04:31, Muhammad Usama Anjum wrote: >>> The userfaultfd is enabled in the config fragment of mm selftest suite. >>> It must always be present. If it isn't present, we should throw error >>> and not just skip. This would have helped us catch the test breakage. >> >> Please elaborate on this to help understand the what breakage was >> missed. >> >> Also this commit log doesn't look right to me. syscall() could >> fail for any reason. Do you mean to see skip is incorrect in this >> error leg? Please see comments below. >> >>> Adding this now to catch the future breakages. >>> >>> Signed-off-by: Muhammad Usama Anjum >>> --- >>>   tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c >>> b/tools/testing/selftests/mm/pagemap_ioctl.c >>> index bcc73b4e805c6..d83dda8edf62c 100644 >>> --- a/tools/testing/selftests/mm/pagemap_ioctl.c >>> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c >>> @@ -95,7 +95,7 @@ int init_uffd(void) >>>       uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | >>> UFFD_USER_MODE_ONLY); >>>       if (uffd == -1) >>> -        return uffd; >>> +        ksft_exit_fail_perror("Userfaultfd syscall failed"); >> >> This looks wrong to me - Is missing config the only reason this syscall >> would fail? > > It should still skip if __NR_userfaultfd isn't supported on a release > or an architecture. > > The real problem seems to be in main(): > > if (init_uffd()) >                 ksft_exit_pass(); > > > Why is this ksft_exit_pass()? Looks like further investigation is > necessary to understand the problem and fix. Let's skip this patch as it'll create more noise on unsupported architectures than catching failures on supported architectures. > > thanks, > -- Shuah -- BR, Muhammad Usama Anjum