From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD8CC7115C for ; Fri, 20 Jun 2025 14:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E7866B008A; Fri, 20 Jun 2025 10:16:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BF146B008C; Fri, 20 Jun 2025 10:16:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D4CD6B0092; Fri, 20 Jun 2025 10:16:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 60B066B008A for ; Fri, 20 Jun 2025 10:16:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 256F85CDA3 for ; Fri, 20 Jun 2025 14:16:12 +0000 (UTC) X-FDA: 83575978584.03.26474DB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf03.hostedemail.com (Postfix) with ESMTP id AE6732000C for ; Fri, 20 Jun 2025 14:16:09 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="raD/+oeo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cKLQCT30; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="raD/+oeo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cKLQCT30; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750428970; a=rsa-sha256; cv=none; b=0ZAPfxXx3fCA6dcJ/eivOR5XLP3lRF6vrmjhUaAmy4Sh+jSL68YpBuywyW9JBLhqXK7X/g cKeRUlNVpywKhqAuDjrelrWFlbb5JVYpiaXXiLi6zlIkATJ2SMs7mdfRh5fVPD+SMVEoZ/ hXOjaJFnyfvmpNKIkGJ7TxRWHWXnl/8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="raD/+oeo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cKLQCT30; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="raD/+oeo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cKLQCT30; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750428970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MboJ+7WvdngUbOiVxLK4VUJHJCS5vTKneoNhaznc+WU=; b=Q7HL4OM0p3zGIes7NIqncp4n0HX3s0xKY0M0RV7zVC117stbhfsiK8vNzevOuefXtL/sUU tjw8TWZPokPtPrXefH8WyFC9c0ZtNtsVKgHj6cdHo+98T/qzEHER8ax43pu+OIDYieJRGC NSqVfCaHj9KX9La341WXA+CQuRwc7+s= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 637C3211A5; Fri, 20 Jun 2025 14:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750428968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MboJ+7WvdngUbOiVxLK4VUJHJCS5vTKneoNhaznc+WU=; b=raD/+oeoqpZqj/kTkhsAl+qaps08DKTWjyEMbdKSVAQ6weOzvJwWoijNZGOEJRbkKF1P2U W02EUWOBtJAZti8UnUOCr3XfMBbE0BxkXVpENtTx4LQhSllpMSva8dDqD+dkCrY+dxyDFK jrzJMsFt7Skg/whRXpZgbp17MylEdUw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750428968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MboJ+7WvdngUbOiVxLK4VUJHJCS5vTKneoNhaznc+WU=; b=cKLQCT30Sb9Ra2gexwDqRderOW+NF/kUVzhpD5FxCroCzB35l1Oj7RWSIWSbMbmNxj7BOv MnAbjsALT7/hu1AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750428968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MboJ+7WvdngUbOiVxLK4VUJHJCS5vTKneoNhaznc+WU=; b=raD/+oeoqpZqj/kTkhsAl+qaps08DKTWjyEMbdKSVAQ6weOzvJwWoijNZGOEJRbkKF1P2U W02EUWOBtJAZti8UnUOCr3XfMBbE0BxkXVpENtTx4LQhSllpMSva8dDqD+dkCrY+dxyDFK jrzJMsFt7Skg/whRXpZgbp17MylEdUw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750428968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MboJ+7WvdngUbOiVxLK4VUJHJCS5vTKneoNhaznc+WU=; b=cKLQCT30Sb9Ra2gexwDqRderOW+NF/kUVzhpD5FxCroCzB35l1Oj7RWSIWSbMbmNxj7BOv MnAbjsALT7/hu1AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4172E136BA; Fri, 20 Jun 2025 14:16:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fDafDyhtVWh2SQAAD6G6ig (envelope-from ); Fri, 20 Jun 2025 14:16:08 +0000 Message-ID: <2f6a2210-7327-4270-b072-0047936144c7@suse.cz> Date: Fri, 20 Jun 2025 16:16:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm/madvise: thread all madvise state through madv_behavior Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , SeongJae Park , Suren Baghdasaryan References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AE6732000C X-Stat-Signature: odfci8q63cs75d5e4dhn3mnu61mo7go4 X-Rspam-User: X-HE-Tag: 1750428969-732432 X-HE-Meta: U2FsdGVkX1/X41cWjDrSIcrpR0TR3NfkC/8059whaSTof7i0kQeoUPMmV4Rrhuv9aXAuThYreU25d0bvT7BDOb/NHvxl9TcJE0Ngn+VE337Lq3VfCd0A8/S2WhZADjkWP5hc6U59k28qQTMCD7CyRACRVfomM5VJtGmhfaMpM/Go8brxn07sZrlBa6IZLzrHSjqiQztoifTYGtHL1kyref1WgVexM3DO8C93thktuxoOBmP2stlDkg0ak/bEokr5uXPyvpj5bqaKCoRqO9rTHFF8zfxA8pAQxiSodUByciSqHw44zhKv2WlO09qD1BUrOGiHWd9jsVk+YVSPT5p5WfuSwU9zWVQQpJQD5QgVe/2qyDvKJUwVIfhUpzvz29sNZq+VWs6ZamutlsidfguGTuK2sxtIeBP2uex0OVxU+MNGHRYtX+JDhANIF+RJB+RcyVO/voxZD5V5afg0m7A/R+Pby7WCl5+4uHOSssRk3K3wF5dfSyoP+JWdLH+tXibiYg/aEP5PWXbTeMTqvhKmOCQx47pVG0za34m7OImw3twwzuT1EACfdIPOsj5x6N2+4Lk7EL12DGWhvQqsVexjQ5P/9fz9jCQLnQw7J8b522XmOveORUgKwPH6LMWxb8hgoc4gmSF77kDSnK/M5kAWTNKDV7KlViCigo7aPRIRTSzzfFGs3mQRGKndQZwpYGpgIeO2ANk9YT2l+KLkW+pCSGwub5D7jwk37jJ8As5lnoWVwOweLgKlSm3O6+QqLm8XjXMQbT0+LJ/CCZH+GRi+tXSWjfIt/eT9Qnb+RtuKo26DtJDny1g/VUyIRFcLXEsdF8cMDQQ8rFNq9jt91kJlXIobg6pX1Y/YVpVwlvvZXg3Xcjv+sKaDRtfsLundeZ34PmAtwRDgr1jhhmehpqjsR6EDcdtRV1oqYI9K2VOkj50uNvd2tlIykklzlWhubYQABGtwSE19FFu+3mS0X1j 4HY0xHBK mX+ickzT1U6XA0bgVfbM2/QxzscWQYkUAfV/XJOccnWoF6Wca0Fw3+YyDQuVB71kGosGwR3zJ9lDDuF9meUuzG64jaqpnKA/EXOpYaVbRBKRJ5LNWO28A9PgZ/8QJWmm4WtbW691kSxHV17Xtn6iTGk/5j5+92u4s2xtq3TcnvpFqNRmpfcca0qtYSzEXclOqxxx72/HMr/30SDgAxT4PnYd6PKa8TbtGvXmXYLOv38FoE+omFIwRH1Sc4QyaL59QpL0LemxU+OkPac2dFCvs8btOWecsWtHevXkfse+GTcRvfwIYNJsOFX+xRsTHh4USnU2d8PkET03shw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/19/25 22:26, Lorenzo Stoakes wrote: > @@ -1662,13 +1668,16 @@ int madvise_walk_vmas(struct madvise_behavior *madv_behavior) > range->end = min(vma->vm_end, end); > > /* Here vma->vm_start <= range->start < range->end <= (end|vma->vm_end). */ > - error = madvise_vma_behavior(vma, &prev, madv_behavior); > + madv_behavior->vma = vma; > + error = madvise_vma_behavior(madv_behavior); > if (error) > return error; > + prev = madv_behavior->prev; > + > range->start = range->end; > if (prev && range->start < prev->vm_end) > range->start = prev->vm_end; > - if (range->start >= range->end) > + if (range->start >= end) I believe this change is fixing a bug from patch 3/5 (which I didn't catch, sigh). > break; > if (prev) > vma = find_vma(mm, prev->vm_end);