* [PATCH] mm Add MODULE_DESCRIPTION entries to kernel modules
@ 2020-06-21 6:31 Rob Gill
2020-06-22 9:00 ` David Hildenbrand
0 siblings, 1 reply; 3+ messages in thread
From: Rob Gill @ 2020-06-21 6:31 UTC (permalink / raw)
To: linux-mm; +Cc: Rob Gill
The user tool modinfo is used to get information on kernel modules, including a
description where it is available.
This patch adds a brief MODULE_DESCRIPTION to the following kernel modules:
hwpoison-inject
zsmalloc
Signed-off-by: Rob Gill <rrobgill@protonmail.com>
---
mm/hwpoison-inject.c | 1 +
mm/zsmalloc.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
index e488876b1..d506945b6 100644
--- a/mm/hwpoison-inject.c
+++ b/mm/hwpoison-inject.c
@@ -116,3 +116,4 @@ static int pfn_inject_init(void)
module_init(pfn_inject_init);
module_exit(pfn_inject_exit);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("hwpoison memory failure injector");
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 952a01e45..eb4d380c2 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2592,3 +2592,4 @@ module_exit(zs_exit);
MODULE_LICENSE("Dual BSD/GPL");
MODULE_AUTHOR("Nitin Gupta <ngupta@vflare.org>");
+MODULE_DESCRIPTION("Slab-based memory allocator for compressed RAM pages");
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm Add MODULE_DESCRIPTION entries to kernel modules
2020-06-21 6:31 [PATCH] mm Add MODULE_DESCRIPTION entries to kernel modules Rob Gill
@ 2020-06-22 9:00 ` David Hildenbrand
2020-06-22 9:26 ` HORIGUCHI NAOYA(堀口 直也)
0 siblings, 1 reply; 3+ messages in thread
From: David Hildenbrand @ 2020-06-22 9:00 UTC (permalink / raw)
To: Rob Gill, linux-mm
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Naoya Horiguchi
On 21.06.20 08:31, Rob Gill wrote:
> The user tool modinfo is used to get information on kernel modules, including a
> description where it is available.
>
> This patch adds a brief MODULE_DESCRIPTION to the following kernel modules:
>
> hwpoison-inject
> zsmalloc
>
> Signed-off-by: Rob Gill <rrobgill@protonmail.com>
> ---
> mm/hwpoison-inject.c | 1 +
> mm/zsmalloc.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index e488876b1..d506945b6 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -116,3 +116,4 @@ static int pfn_inject_init(void)
> module_init(pfn_inject_init);
> module_exit(pfn_inject_exit);
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("hwpoison memory failure injector");
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 952a01e45..eb4d380c2 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2592,3 +2592,4 @@ module_exit(zs_exit);
>
> MODULE_LICENSE("Dual BSD/GPL");
> MODULE_AUTHOR("Nitin Gupta <ngupta@vflare.org>");
> +MODULE_DESCRIPTION("Slab-based memory allocator for compressed RAM pages");
>
I would have split this patch up. Also, you should cc the proper
maintainers. See MAINTAINERS and scripts/get_maintainer.pl
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm Add MODULE_DESCRIPTION entries to kernel modules
2020-06-22 9:00 ` David Hildenbrand
@ 2020-06-22 9:26 ` HORIGUCHI NAOYA(堀口 直也)
0 siblings, 0 replies; 3+ messages in thread
From: HORIGUCHI NAOYA(堀口 直也) @ 2020-06-22 9:26 UTC (permalink / raw)
To: David Hildenbrand
Cc: Rob Gill, linux-mm, Minchan Kim, Nitin Gupta, Sergey Senozhatsky
On Mon, Jun 22, 2020 at 11:00:00AM +0200, David Hildenbrand wrote:
> On 21.06.20 08:31, Rob Gill wrote:
> > The user tool modinfo is used to get information on kernel modules, including a
> > description where it is available.
> >
> > This patch adds a brief MODULE_DESCRIPTION to the following kernel modules:
> >
> > hwpoison-inject
> > zsmalloc
> >
> > Signed-off-by: Rob Gill <rrobgill@protonmail.com>
> > ---
> > mm/hwpoison-inject.c | 1 +
> > mm/zsmalloc.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> > index e488876b1..d506945b6 100644
> > --- a/mm/hwpoison-inject.c
> > +++ b/mm/hwpoison-inject.c
> > @@ -116,3 +116,4 @@ static int pfn_inject_init(void)
> > module_init(pfn_inject_init);
> > module_exit(pfn_inject_exit);
> > MODULE_LICENSE("GPL");
> > +MODULE_DESCRIPTION("hwpoison memory failure injector");
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 952a01e45..eb4d380c2 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -2592,3 +2592,4 @@ module_exit(zs_exit);
> >
> > MODULE_LICENSE("Dual BSD/GPL");
> > MODULE_AUTHOR("Nitin Gupta <ngupta@vflare.org>");
> > +MODULE_DESCRIPTION("Slab-based memory allocator for compressed RAM pages");
> >
>
> I would have split this patch up. Also, you should cc the proper
> maintainers. See MAINTAINERS and scripts/get_maintainer.pl
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks for forwarding, and for mm/hwpoison-inject.c,
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-22 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 6:31 [PATCH] mm Add MODULE_DESCRIPTION entries to kernel modules Rob Gill
2020-06-22 9:00 ` David Hildenbrand
2020-06-22 9:26 ` HORIGUCHI NAOYA(堀口 直也)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox