From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8E1C05027 for ; Thu, 26 Jan 2023 09:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D6F28E0001; Thu, 26 Jan 2023 04:28:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 187C56B0075; Thu, 26 Jan 2023 04:28:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 028278E0001; Thu, 26 Jan 2023 04:28:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E2E126B0073 for ; Thu, 26 Jan 2023 04:28:29 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BE2CDC010E for ; Thu, 26 Jan 2023 09:28:29 +0000 (UTC) X-FDA: 80396424738.10.C8403E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 9EC704000D for ; Thu, 26 Jan 2023 09:28:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B7kaUqG0; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674725307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hlpy8oMhkjt4kiolXYLNtGmM2K2CX6szoOfA13GZPeI=; b=g6S6SJZE2MkPwNzBnZq7MNk9kddaH0tOUhY8Pm9vlM/GHaBLkl5NpRje/ajFTZA2NLERT0 0HCKiL1hlo5HFJJS5yPmAfvsFam6okZ1DUIjN9VwQOf0KtLco/mumndpeNaSKyLqmSSKsT O0XVWCmqEYVU0kBMeMXosYtNQ5sHy2g= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B7kaUqG0; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674725307; a=rsa-sha256; cv=none; b=otn2FC4FYHxUihnvY6ok1SkmwoB5OnPVkXK+fgpEgTnKek+cI2C6MSV2vaFbCJi+48hBC5 gET7GT3WSQSry3nGZrzI3/VTO6IXHcKJkJSbW0XpfcEVWht/7bXgLLbWUZMekbvbt8LT0q 3XVdCcVAhB8r7nLj6WePyNAnSS/tQrM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674725306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlpy8oMhkjt4kiolXYLNtGmM2K2CX6szoOfA13GZPeI=; b=B7kaUqG0fklbT/E6lhPQuyZI5tGPEHF9NqVmygSGzr+1tA1cSM9BlgDRtDhfyIrTFUizlY 2lVSSg6JyGEaomCAfIUaMoCQdY6GyQn4WM4zJn4M2sjYEsVMGQaNC+xNysEcfXPFRhtmED KMNh98ypluaCGVOk8u3tUBclcbXTcYA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-663-9z9i3lZbO4aqLhrKpaRj0g-1; Thu, 26 Jan 2023 04:28:25 -0500 X-MC-Unique: 9z9i3lZbO4aqLhrKpaRj0g-1 Received: by mail-wm1-f72.google.com with SMTP id l23-20020a7bc457000000b003db0cb8e543so276150wmi.3 for ; Thu, 26 Jan 2023 01:28:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hlpy8oMhkjt4kiolXYLNtGmM2K2CX6szoOfA13GZPeI=; b=X8Icn58CyqadLVO5JsDzKdum1e6SnghMCSD0MJA5+pOUC6y0Ad/6GAjKY/XsM/M4iH rAMXt8I4M1UYEnDoR7ZCdvNtcVzQaKFoGdlKKoPM1Y5p90qtNw/Hlfhgv3KK3SMianzc XMMoQg9++ApjYgoVA0N9lswaQY3pg01SCtXMymsl4E6lmHWrqKPh95C4eLAxv7gtj1ch OXbYxg+L/SZHUXetrjpqVpz/p3FyCxCPJBGuTHmX71ue/MhpEancGxTNwZ0FPAWqravK 9vVfSQEp9KrJ8TZ+q9cFGAeIUWfip7Q1Xg71hJdZeknLH7EEG3PC6DuXUzY5PKew+JIm ipqA== X-Gm-Message-State: AFqh2koV1tHda6atctIkUQqj1j0lMaRymWbKsCguzYWPmHlHSKPOrPH+ mhAQ3JG5RBNWjejFmsk1ZYvguLxoTYYPQPbyx5ntsxZwZG8j1ItoplFuSoC69P6LxPwEN30vhwi HF3T2zj+rmuQ= X-Received: by 2002:a5d:6b09:0:b0:2be:110d:5d59 with SMTP id v9-20020a5d6b09000000b002be110d5d59mr29514217wrw.51.1674725304552; Thu, 26 Jan 2023 01:28:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXvUubeSQ32vzl9stAsN2dulKbFqGtYmFtL06g225jZTpyT/iCMWZw4XveGa5u+qTWONOqnjnw== X-Received: by 2002:a5d:6b09:0:b0:2be:110d:5d59 with SMTP id v9-20020a5d6b09000000b002be110d5d59mr29514191wrw.51.1674725304256; Thu, 26 Jan 2023 01:28:24 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id f28-20020a5d58fc000000b002be5401ef5fsm629228wrd.39.2023.01.26.01.28.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 01:28:23 -0800 (PST) Message-ID: <2f39d449-f760-db73-5da5-9d7016f1350f@redhat.com> Date: Thu, 26 Jan 2023 10:28:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic To: David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-6-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230125210657.2335748-6-dhowells@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9EC704000D X-Stat-Signature: m6omig9gt6ipg7re43mn45hpn3a7sbuf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674725307-829623 X-HE-Meta: U2FsdGVkX1+Q0lBiIb0mCVl/cyInM+xnvt1+5mLhEKq5BbOnARuaREnuSC4HLtg+omteeiiZkpt5n9a2UgBl9gNtFeqagxVlTMxvJZPOf6AOoFFRcihAowZ8EkCVxX/eztJ8Tl15OpCi7WcHqMTEKZDRFxc+1QYApkDqsnjBYWcoUub40aUhZEu/SqZvxB1PnQqtJqg+XKNHTPaSIj+KtC+AoD5hy4LeRgUbml2amL19ETfdOxFeg9AnyZlCQYNzlejprUSNRxT/7rjacFI9KlPonQqXfGF5XO8nfTeic2Korw+eCkZq4eOlKhaDWCwVim2Buqgpr/W31tFosSU1r1kg0LnHeP+eMpRG1dGqjKEo6c91lGoZ2NKyL1/wF0r3HearWYEV99VcyaPgBZQyPbiC3ZdlW6E9hx9m132sKdFBNq6QnLj2AyqlxKAMBl05yapbdcgonnotcaiujs3aggOndftpT1WP0eQB/0KYu1TZgPktAOVrFor2qYgXBnCb9+fMqwbOv1op9hGWWx5yQsynA0BOuNwxv4bEdpXN5L4W091JBXKk7Bf2/aYhnALl0Opfi8oxvYPq06XvNpH4aCwhT0RsmxWjEwFcmrZ7ZW2BtDhGpzFzvdKA75Ae4jBqSxxlYRn7aBQzRIQnsdI1/rgGlNd8zW2ThTmc4c3YuVbRMCOwP2o5BD/1ONfZ4LXlQxTCGKaq1G1v8wJ4ZYsoFd2ZkE3UGIxuNXugA02Mf0A1bzE58xYf92mfc2eGu06yrZ3XJvaOZE2bQC54KdrMir1U4OE+2wt0zXnpN9GC8E6s7edyp5Vm8XzsT4te3oMJUntk3S2mXeC9euSs0Ewo0mB8b/K2C84lBVa2EGtT+aUEg+cGUYNQYL9kdR/7J745IA9LvFQUq6yKjuS4qYrVBrCSn6//ELuzPL3x3uVjdslHFkbFCBTrfFIL3fn+OAoZfCsT14hm3NmwuwZws1J 8hXR7OfG xK88xcUCBhXu6gBLlz/zqxeymdjqvGLLYwhFN8EdFsazDNkH9NRW2nyc9AT2hvAjU4NiStWdpGVf6gBzR6/b+aFR27dw5p7I1p344ZuKfhUJ67zFk5rSq9D6PQaDR4ECyI5FkS7ATmCpvsW2n35H5CLLY3wlp5LVXBbe3nr0nEZLMbe9dgH6dMQ4jVgnt5hocAHXZtHX7OO4n6dSYKU9rgXUt5DABsM3VNScOt6v+7SNqxrubJv+7woYi/CbUaEBjC0cS7FISe79a1NWvVA3chSpV09Gucgvmzemd7jEgUM1weNMHxhR4d0EqdtntHRg5sLdEANlDXpIRHru8ZUG0UjbGu82A17FpQfvnIh6FPw25lbSWT3OH+LfyV+Wqy61svgvKi9bVqj5RccnJGYpibDJQFNC6p+J4Qe3mv6lPfr/j5o0rqTxYjOnhXhVOEv1/gJlsjc1cwN2q+V7Mvuz8PKpSwlMrWKrqglt+j50HD4l1/NdxwgWpZEMpmNmVv8WTdQJ1C+BTHbLcAVaPDcCncGs9rnLiCBStzS3szoQMYyKh7UXOnSobo6c+4YO19Sy26RnAkKtaEWuz/MQO9olgoRGZAQNRGBU+e+Ui7L+eAxS4CweFKZV/7duQI8q0Ggd953A2xFttPtITBN7pwxPhC1EsWTlVlKKNMLWJ1z0owW4FhV9Y94We890C+y3khgIv58xKxQBfPlu8oUXGiFtsr7pIRkIWsnApiFww X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.01.23 22:06, David Howells wrote: > From: Christoph Hellwig > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > meaning is only set when a page reference has been acquired that needs to > be released by bio_release_pages(). > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > Reviewed-by: John Hubbard > cc: Al Viro > cc: Jens Axboe > cc: Jan Kara > cc: Matthew Wilcox > cc: Logan Gunthorpe > cc: linux-block@vger.kernel.org > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb