From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C59AC46CD2 for ; Tue, 9 Jan 2024 06:19:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E308B6B0072; Tue, 9 Jan 2024 01:19:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DE10B6B0074; Tue, 9 Jan 2024 01:19:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCFDA6B0075; Tue, 9 Jan 2024 01:19:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BCCC76B0072 for ; Tue, 9 Jan 2024 01:19:10 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8C116A0173 for ; Tue, 9 Jan 2024 06:19:10 +0000 (UTC) X-FDA: 81658770060.29.9C0E1B1 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf03.hostedemail.com (Postfix) with ESMTP id 6357220007 for ; Tue, 9 Jan 2024 06:19:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=YamSfekn; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=isZB8Vf2; spf=pass (imf03.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704781148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i2E0GYQGCUnukc1Xm2CUnNLh1yKk7Vr1Uo5Z8zGq0O8=; b=k9nvveqpR+CnARj/l8zLO0dlS5ADGAA3cgujp6gKugstjWOTzkPx3EhTDcP//pTWxApSgB pm+OFicN6LXQjyEYr/a9quZvRHxuUGyeHXvsQUPammXGbGigT+Rs2+mGAYHjCqj0MwZT2F qDFNlcTJ9ZxCQKm04xwPJagR9IR1XHg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704781148; a=rsa-sha256; cv=none; b=sLCGiFs3GcNny9Cic76hiFDoKa6khyUmDc1u0E82xJB50i5xlYpB5UIH+uxAd5T6YAKNQ4 9wTf8+JFwZnsSn7zFY9To3rfunGgKMNxWBWBgTHW1tfDNEIHtN7ka60xu4S6WAsKyV/E6b 9OYuKg0z8ewG2+g1UQth0vvwJLaV9Jc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b=YamSfekn; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=isZB8Vf2; spf=pass (imf03.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 69F935C02D8; Tue, 9 Jan 2024 01:19:07 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 09 Jan 2024 01:19:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1704781147; x=1704867547; bh=i2E0GYQGCU nukc1Xm2CUnNLh1yKk7Vr1Uo5Z8zGq0O8=; b=YamSfeknz2EVajGJWpKi/+fSQc S/xhY4fkku5oq/4N1cyPBjKoGPARMcjxDp8th9UGD0z8sKNyJ1YfJ6DM17z7sxSL HO1KFt1EZ3d/hE70mHOG706fhP76ugYn/G25BI3UvG1xOiGcavEOFwy4y2LbGZpE VvDox5Lat8XlZRFVAofWsrwyOxRmY43evhG8pnMLN00230JpwvICRKe86trf/DEh ujcAJ/CR0aW89rqJM1nU2cSwUbJrDw63mLNqmmBwlRruItEXQ5ZtowNJwP/0bGME 3c0iQsWOl6IJj9f5bEmNsbwI8NtGrMW2nDhp9lSp1inLoDERBW64TtqmSF6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1704781147; x=1704867547; bh=i2E0GYQGCUnukc1Xm2CUnNLh1yKk 7Vr1Uo5Z8zGq0O8=; b=isZB8Vf21ChqCRootrre9JTBLbgE9pMGz3oek4oNAfmH MbVwn1XjRN3+n9Jio3r/Ii5RwAz7/6Ykb5y1ymSGw6Bp+GCVdJIv+TlmOmlNJK9/ k36xh7zs31oKjQkbwY7jOMyIZIolc5EUZzOBOhzMqy+fpAydJOcd2ovRdX9vmYO2 +lq9+OVruUPPeU60319cMeLj3YEn1TmsLZypmv4uCuQ197t62kEI6eDOJL22jnNQ Xtq4eA8oGoy3aDbs2HhFgE6Q+PELya6eHOG+Jw1AADPWbab34uODEiAFmHQZEwGy saVQG68oz5nFloV4mG/3QEFWJINlUF0fM4YMOC6AiA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdehkedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 84DE8B6008D; Tue, 9 Jan 2024 01:19:06 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1364-ga51d5fd3b7-fm-20231219.001-ga51d5fd3 MIME-Version: 1.0 Message-Id: <2f2e8df4-d8bb-4eff-8e70-0ac38736bd74@app.fastmail.com> In-Reply-To: <20240108174330.472996-2-leobras@redhat.com> References: <20240108174330.472996-2-leobras@redhat.com> Date: Tue, 09 Jan 2024 07:18:46 +0100 From: "Arnd Bergmann" To: "Leonardo Bras" , "Catalin Marinas" , "Will Deacon" , "Eric W. Biederman" , "Kees Cook" , "Oleg Nesterov" , "Mark Brown" , "Mark Rutland" , "Steven Rostedt" , "Guo Hui" Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] arm64: remove unnecessary ifdefs around is_compat_task() Content-Type: text/plain X-Stat-Signature: h1f67m549515r3h53rzf4ghc16wcwfit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6357220007 X-Rspam-User: X-HE-Tag: 1704781148-172963 X-HE-Meta: U2FsdGVkX18zb32pmRTxuYtS9HAg1ZUxhT86TzKypqBxPh9C005MmJjI27cAiZ3zw2uE/9xTdIkbFH2BqSqjY8hfPujSJJwvU8Omg7xNJPmsaGcI0PJR9TnwFcN5AS8ZshrjUo19s85zKXbuPi/As4BwViAFX7WW11fgF6y/u1cdwQHFNH6bq0a0dLLdNZuHRKhPK5ZAYR4fgh++mA5GnB6m145dk4tbjoVq3b08lqv231oOmq/+ZvPohyPK4jutRDa1s7y/Sf7becq56iZ1x1ia+6ELvlKRQAf2XkPmoX9wXrozOYwmhOxWta8YkxDEOExaLvTDujhlOfhxw8JdSlqcnLbF8ChGAQXRDJXVKWBEgjjY+KkwI4QZmiWmdaWex5FxVQ3XyqejsxtHfaJJgWyZZMbjTsosOz25cHj+cpvv7ypPCw5NZW+8oex/pzEwlICTivrtWSulzUGgVHVefF7megMm8FtlYOwBnWCcVEwvDcCDSx1PEe3YOoVUIaFPnAJ4E7WPjpIgpPDaOOYL2/155AhYqncTqa8JkcdnJy/xvi97er/YPvgrh4quAZgGeh6lshZF5EKdl6ctY+Wy/BShky0fi02ctM8za5SsWelS9o4ly+AbFpS1yWDuwQDIhznKwTUFYDMEezx8FlqLgmg9OkHmrd1Td1KU0+qYi7syQZP6LNJPx7mE8b+VehbKYKr5oiJm2WeiVWdFvG2CqwBTrC0MjAb8+gqcDnmSJXB8YL9ihBECL1FwcQ7h0d3t8FhL1jae1QMXmIWcN1bsYPo/qoHAb0WjUyGU3KddRYauokfqR0xBJjI/5CBT8/ZDvra38utLwwgRDfZTVunhKesmQhms0NjWhtrs3sV+juqXUEEMyQ+yh1EwBcv2BUy4jm7VBBfnKcyZ2E6Y2YjI3bfhdN19Ev6ws+KoC8mYWpHOBDyk13wJgA5iWihwmhe/yhJyoCsprXK2PGl5uP3 PtmYM6Js mFhwgDguohQ2YwkonsVSFPnrjacWi6BVTkANNDDZph0WF2TwTU/ZTZV2D6pMjTW7iR9ofbhK8e2HWe1K1+YLoImuJmmllc4S2PAMFQfuCoa7A9wBPMpeh2Qj+J6q+0yUTwTqtfH0dxs3MKb6RfTZLxU/+lScbZ9EtAM99sqUsZgwwV/JSZavCwHCWjTZIgV+q4NdQNcWCPE7uxRIlCXpt6NgMPev7UHav8Pro9VkhvSbOcVI4BBN7/tX1gTn8LkJOVAzgGM004KS2mXqe2meKW7I9pNJWgSUebTwV+12EBJYzfLiK2fgI4WbkPIgRRYyv3JXj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 8, 2024, at 18:43, Leonardo Bras wrote: > Currently some parts of the codebase will test for CONFIG_COMPAT before > testing is_compat_task(). > > is_compat_task() is a inlined function only present on CONFIG_COMPAT. > On the other hand, for !CONFIG_COMPAT, we have in linux/compat.h: > > #define is_compat_task() (0) > > Since we have this define available in every usage of is_compat_task() for > !CONFIG_COMPAT, it's unnecessary to keep the ifdefs, since the compiler is > smart enough to optimize-out those snippets on CONFIG_COMPAT=n > > This requires some regset code as well as a few other defines to be made > available on !CONFIG_COMPAT, so some symbols can get resolved before > getting optimized-out. > > Signed-off-by: Leonardo Bras > --- > Changes since v1: > - Move some regset code and other defines outside of CONFIG_COMPAT > - Closes: > https://lore.kernel.org/oe-kbuild-all/202401061219.Y2LD7LTx-lkp@intel.com/ > Link: > https://lore.kernel.org/all/20240105041458.126602-3-leobras@redhat.com/ Looks good to me, and did not cause any regressions in an overnight randconfig build loop. Reviewed-by: Arnd Bergmann