From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE69AC433F5 for ; Sun, 14 Nov 2021 22:19:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60C9361156 for ; Sun, 14 Nov 2021 22:19:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 60C9361156 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AEB096B0078; Sun, 14 Nov 2021 17:19:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A99EE6B007D; Sun, 14 Nov 2021 17:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9614C6B007E; Sun, 14 Nov 2021 17:19:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id 84E596B0078 for ; Sun, 14 Nov 2021 17:19:17 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A748B84779 for ; Sun, 14 Nov 2021 22:19:16 +0000 (UTC) X-FDA: 78808952712.13.5F9F631 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 5BFA520019D3 for ; Sun, 14 Nov 2021 22:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=/YI2I8AStZ9sTO+q28vUUfwszyhcKKFFKLCMRT0PkXU=; b=HVEJGk+dPQWWZgwlIgZ+vLLfQj sXnSd4HXEr/q8qLUgazRO9psL4fADN4ESlHl0pTBNqaldzGjYj9wEZ2YN7IAW01se+eJOvTPYx5oP 5QpmPnvOMM97sFNrXOurGTxSs43lLcS8Ue+nXnNWR9WUBE31rgYXF6PgoKwGNYtz7fEUK3015ws+e 38/crwqs8eIwtwF5qspp2BD5bWEWZM8TYhFxfUf7bua9M4800h3bGdUR7psjJyybKWvL3/a+YBsvt cvi6MFliDMBuSiD6DmItmfOC477bKFRD3yWSf8Y16LIQz6Xcly3W4Qhhrc/KnAVK5fBXDacdCr7th tMXP7P9w==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmNq9-00E8GD-2T; Sun, 14 Nov 2021 22:19:09 +0000 Subject: Re: SH: error: implicit declaration of function 'init_cache_node_node' To: Arnd Bergmann Cc: LKML , Linux-MM , Dave Hansen , Andrew Morton , Rich Felker , Yoshinori Sato References: From: Randy Dunlap Message-ID: <2f29a441-5105-5f62-9e06-d1c97b08801a@infradead.org> Date: Sun, 14 Nov 2021 14:19:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5BFA520019D3 X-Stat-Signature: bce7rop1nua19ii3n8huoqjfqndj7bgm Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HVEJGk+d; dmarc=none; spf=none (imf26.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org X-HE-Tag: 1636928356-574335 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/14/21 2:04 PM, Arnd Bergmann wrote: > On Sun, Nov 14, 2021 at 2:17 AM Randy Dunlap wrote: >> >> on arch/sh/, >> CONFIG_SMP is not defined, >> CONFIG_NUMA=y, >> CONFIG_MEMORY_HOTPLUG is not defined: >> >> ../mm/slab.c: In function 'slab_memory_callback': >> ../mm/slab.c:1143:23: error: implicit declaration of function 'init_cache_node_node'; did you mean 'drain_cache_node_node'? [-Werror=implicit-function-declaration] >> 1143 | ret = init_cache_node_node(nid); >> >> >> commit 76af6a054da4 >> Author: Dave Hansen >> Date: Mon Oct 18 15:15:32 2021 -0700 >> >> mm/migrate: add CPU hotplug to demotion #ifdef >> >> >> How should we handle this config? > > I think we can safely assume that NUMA without SMP is not a useful > configuration on SH and add a dependency in Kconfig for it. > > I assume this came from some randconfig build rather than a config > that someone was intentionally using? My guess would be that testing > sh randconfig kernels is not overly productive as you likely need > countless patches before there is a chance of it working most of > the time. I haven't tried this myself, but I spend a lot of time fixing > randconfig failures on arm and x86, and I whenever I try any other > architecture, there is simply too much work needed upfront. I understand why you guess that it's from a randconfig, but it's not. It's from migor_defconfig. -- ~Randy