From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f197.google.com (mail-ot0-f197.google.com [74.125.82.197]) by kanga.kvack.org (Postfix) with ESMTP id 90B206B0007 for ; Wed, 14 Feb 2018 14:06:11 -0500 (EST) Received: by mail-ot0-f197.google.com with SMTP id l18so9426369otd.1 for ; Wed, 14 Feb 2018 11:06:11 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g88sor6261340otg.251.2018.02.14.11.06.10 for (Google Transport Security); Wed, 14 Feb 2018 11:06:10 -0800 (PST) Subject: arm64 physmap (was Re: [kernel-hardening] [PATCH 4/6] Protectable Memory) References: <20180124175631.22925-1-igor.stoppa@huawei.com> <20180124175631.22925-5-igor.stoppa@huawei.com> <20180126053542.GA30189@bombadil.infradead.org> <8818bfd4-dd9f-f279-0432-69b59531bd41@huawei.com> <17e5b515-84c8-dca2-1695-cdf819834ea2@huawei.com> <414027d3-dd73-cf11-dc2a-e8c124591646@redhat.com> From: Laura Abbott Message-ID: <2f23544a-bd24-1e71-967b-e8d1cf5a20a3@redhat.com> Date: Wed, 14 Feb 2018 11:06:06 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Kees Cook Cc: Jann Horn , Igor Stoppa , Boris Lukashev , Christopher Lameter , Matthew Wilcox , Jerome Glisse , Michal Hocko , Christoph Hellwig , linux-security-module , Linux-MM , kernel list , Kernel Hardening , linux-arm-kernel On 02/13/2018 01:43 PM, Kees Cook wrote: > On Tue, Feb 13, 2018 at 8:09 AM, Laura Abbott wrote: >> No, arm64 doesn't fixup the aliases, mostly because arm64 uses larger >> page sizes which can't be broken down at runtime. CONFIG_PAGE_POISONING >> does use 4K pages which could be adjusted at runtime. So yes, you are >> right we would have physmap exposure on arm64 as well. > > Errr, so that means even modules and kernel code are writable via the > arm64 physmap? That seems extraordinarily bad. :( > > -Kees > (adding linux-arm-kernel and changing the subject) Kernel code should be fine, if it isn't that is a bug that should be fixed. Modules yes are not fully protected. The conclusion from past experience has been that we cannot safely break down larger page sizes at runtime like x86 does. We could theoretically add support for fixing up the alias if PAGE_POISONING is enabled but I don't know who would actually use that in production. Performance is very poor at that point. Thanks, Laura -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org