From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF25CCA47A for ; Tue, 14 Jun 2022 17:20:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68E4F6B0071; Tue, 14 Jun 2022 13:20:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63E7D6B0072; Tue, 14 Jun 2022 13:20:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DDD66B0073; Tue, 14 Jun 2022 13:20:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3BC4A6B0071 for ; Tue, 14 Jun 2022 13:20:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 15CF0CE9 for ; Tue, 14 Jun 2022 17:20:30 +0000 (UTC) X-FDA: 79577505420.19.61836F9 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 96D081C00AE for ; Tue, 14 Jun 2022 17:20:25 +0000 (UTC) Received: by mail-oi1-f175.google.com with SMTP id v4so1817968oiv.1 for ; Tue, 14 Jun 2022 10:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=hg6Vqov4iXvBWaAWFrjzE3cJyqu2kSLgOmZIB62TeP4=; b=ZkUTOL7K1RF/aEE1Lfl/rHZMd5mzmuyLkpzUflHyzVmXEl0/ykuBz0T6xVQIEM/eVN s/D90OYveIE+nIbTNu4ml9ME5ulVcDOTtFLHdbYk6gxDJhzCQ86LnuIKbK3IMvRYtkht 733KAbrSO+4Eg6Xfa+qhVujYC0UKgFD0zMnGU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hg6Vqov4iXvBWaAWFrjzE3cJyqu2kSLgOmZIB62TeP4=; b=qnd7a5KtMJ2Fid3gHlc6v42PQIwwxo0CoZ92Zg7MiLCVwsPwpay9bhsmqFXHd4XGGq a5GmIiIfYrafnX31HVePQ+DGBzO2zEvj79LuBMdoeEo9G5pPq5PSIcTlyYoEv+Wakhbn 5l/yRJu2T/sJSvgdEPZFtbPHuEutHHHg6DDofaUiACzgNO/83laKncXwET14kFpY5Dch 3KUKnc7OUUtvnrJGRnFtXLDYr2Dmfn1QJI9xlaV7NnT66w+lqX14vAnIQ1iqA9Vb1yz2 ANDROX5GhCBkWAD4RWSaxcND5pBWNgmQVB2Qg2uqwHwgFRcojxTU3HdqScPYlkPsA86N UGqA== X-Gm-Message-State: AOAM532SyqG34FOoB37PRjcDoqSVS7HUbD9u52Y/5lvtZBUgsj1NHlGt j/j5ASwu/EFazX3g+DxsIKXq2g== X-Google-Smtp-Source: ABdhPJz5iNx+05iYtyKjN+1yjrjUV9JdHERfov+sTvxBpWyYWz/4EqWVrZiwlG4doCoQdTxjdoKR8w== X-Received: by 2002:a05:6808:1512:b0:32e:f1bf:b8f8 with SMTP id u18-20020a056808151200b0032ef1bfb8f8mr2555983oiw.81.1655227224787; Tue, 14 Jun 2022 10:20:24 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id h4-20020a056870170400b000f5e33aaa66sm6074177oae.0.2022.06.14.10.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 10:20:24 -0700 (PDT) Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests To: "Shetty, Kalpana" , akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220610090704.296-1-kalpana.shetty@amd.com> <8e7fca3a-096c-7d6c-e43b-9292995ab970@linuxfoundation.org> From: Shuah Khan Message-ID: <2f157493-02ed-4bc8-6624-b7d077c0d5af@linuxfoundation.org> Date: Tue, 14 Jun 2022 11:20:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655227225; a=rsa-sha256; cv=none; b=2bMydFTuLg+SSIhLNQkUcRbx3JLLTkCaNIciI5oejjTQ25zOkoizeZT541wmkbkyBAzE2o J4O4YF/CxYO7TRirGHz08uYdFZK3c+0LOVUD9wJIg9tluMv/aBU1gwsJKyr9uIimDWSFZv //VMgE7mEI+8t9mP4LXMLLnqtkLrkGk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ZkUTOL7K; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655227225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hg6Vqov4iXvBWaAWFrjzE3cJyqu2kSLgOmZIB62TeP4=; b=unspwy0N1C0FVnFOXm99ucFMYhWmY5dDJPKZnhpuMTHYrcBBF4LtEBOsnX0jOMsZ+fa2Cf 5Hxkz6LnfVhJcW9esW80fI3fJ8pYI0PCDHEapzmfO/rV0HWcs4BqZbW917cBswxkIOsXZA sVaooyM/imK29gzKnRB9EsTRK2i6a0Y= X-Rspamd-Queue-Id: 96D081C00AE X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ZkUTOL7K; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspamd-Server: rspam06 X-Stat-Signature: e7g93jsbnde6kkwrumj9snicdtgrys5b X-HE-Tag: 1655227225-731991 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/14/22 6:15 AM, Shetty, Kalpana wrote: > > On 6/14/2022 3:14 AM, Shuah Khan wrote: >> On 6/10/22 3:07 AM, Kalpana Shetty wrote: >>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests >>> from a single shell script. >>> >> >> Makes sense - can you explain why you can't just run >> protection_keys_32 without checks? > > Yes; we can run protection_keys_32 without check. > > >> Why are you checking for VADDR64? > > The check is added to ensure if the system is in 64-bit mode before executing 64-bit binary. > > Okay. protection_keys_32 will only be built on 32-bit system and. protection_keys_64 on 64-bit system. Won't it be better to check if binary exists and run either _32 or _64 instead of checking for VADDR64? thanks, -- Shuah