From: Shuah Khan <skhan@linuxfoundation.org>
To: "Shetty, Kalpana" <kalpana.shetty@amd.com>,
akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests
Date: Tue, 14 Jun 2022 11:20:23 -0600 [thread overview]
Message-ID: <2f157493-02ed-4bc8-6624-b7d077c0d5af@linuxfoundation.org> (raw)
In-Reply-To: <e1703fcf-c5e2-70b1-cae2-30330108ad26@amd.com>
On 6/14/22 6:15 AM, Shetty, Kalpana wrote:
>
> On 6/14/2022 3:14 AM, Shuah Khan wrote:
>> On 6/10/22 3:07 AM, Kalpana Shetty wrote:
>>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests
>>> from a single shell script.
>>>
>>
>> Makes sense - can you explain why you can't just run
>> protection_keys_32 without checks?
>
> Yes; we can run protection_keys_32 without check.
>
>
>> Why are you checking for VADDR64?
>
> The check is added to ensure if the system is in 64-bit mode before executing 64-bit binary.
>
>
Okay. protection_keys_32 will only be built on 32-bit system and.
protection_keys_64 on 64-bit system.
Won't it be better to check if binary exists and run either _32 or
_64 instead of checking for VADDR64?
thanks,
-- Shuah
next prev parent reply other threads:[~2022-06-14 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 9:07 Kalpana Shetty
2022-06-13 21:44 ` Shuah Khan
2022-06-14 12:15 ` Shetty, Kalpana
2022-06-14 17:20 ` Shuah Khan [this message]
2022-06-15 12:04 ` Shetty, Kalpana
2022-06-16 19:53 ` Shuah Khan
2022-06-17 11:22 ` Shetty, Kalpana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f157493-02ed-4bc8-6624-b7d077c0d5af@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=kalpana.shetty@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox