From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] Fix memory leak of never putback pages in mbind()
Date: Sun, 11 Oct 2009 00:35:58 +0900 [thread overview]
Message-ID: <2f11576a0910100835t4cba94a9v3ccd7473de229af5@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0910090946220.26484@gentwo.org>
>> Oops, I forgot to remove unnecessary brace.
>> updated patch is here.
>
> Thats a style issue. There are other weird things in do_mbind as well
> like starting a new block in the middle of another.
>
> Having
>
> }
> {
>
> in a program is a bit confusing. So could you do a cleanup patch for
> mpol_bind? Preferably it should make it easy to read to and bring some
> order to the confusing error handling.
Yes, I'll do.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-10 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 1:06 [PATCH 1/3] mm: move inc_zone_page_state(NR_ISOLATED) to just isolated place KOSAKI Motohiro
2009-10-09 1:08 ` [PATCH 2/3] Fix memory leak of never putback pages in mbind() KOSAKI Motohiro
2009-10-09 8:46 ` KOSAKI Motohiro
2009-10-09 13:48 ` Christoph Lameter
2009-10-10 15:35 ` KOSAKI Motohiro [this message]
2009-10-09 13:41 ` Christoph Lameter
2009-10-09 1:09 ` [PATCH 3/3] Fix memory leak of do_mbind() KOSAKI Motohiro
2009-10-09 13:44 ` Christoph Lameter
2009-10-09 13:39 ` [PATCH 1/3] mm: move inc_zone_page_state(NR_ISOLATED) to just isolated place Christoph Lameter
2009-10-13 18:59 ` Andrew Morton
2009-10-15 1:54 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0910100835t4cba94a9v3ccd7473de229af5@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox