From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id C8E2A6B016B for ; Mon, 21 Sep 2009 11:08:27 -0400 (EDT) Received: by yxe10 with SMTP id 10so3834793yxe.12 for ; Mon, 21 Sep 2009 08:08:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <2f11576a0909210800l639560e4jad6cfc2e7f74538f@mail.gmail.com> References: <2f11576a0909210800l639560e4jad6cfc2e7f74538f@mail.gmail.com> Date: Tue, 22 Sep 2009 00:08:28 +0900 Message-ID: <2f11576a0909210808r7912478cyd7edf3550fe5ce6@mail.gmail.com> Subject: Re: a patch drop request in -mm From: KOSAKI Motohiro Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org To: Andrew Morton , Mel Gorman , Christoph Lameter , Johannes Weiner , LKML , linux-mm@kvack.org, KOSAKI Motohiro List-ID: 2009/9/22 KOSAKI Motohiro : > Mel, > > Today, my test found following patch makes false-positive warning. > because, truncate can free the pages > although the pages are mlock()ed. > > So, I think following patch should be dropped. > .. or, do you think truncate should clear PG_mlock before free the page? > > Can I ask your patch intention? stacktrace is here. ------------[ cut here ]------------ WARNING: at mm/page_alloc.c:502 free_page_mlock+0x84/0xce() Hardware name: PowerEdge T105 Page flag mlocked set for process dd at pfn:172d4b page:ffffea00096a6678 flags:0x700000000400000 Modules linked in: fuse usbhid bridge stp llc nfsd lockd nfs_acl exportfs sunrpc cpufreq_ondemand powernow_k8 freq_table dm_multipath kvm_amd kvm serio_raw e1000e i2c_nforce2 i2c_core tg3 dcdbas sr_mod cdrom pata_acpi sata_nv uhci_hcd ohci_hcd ehci_hcd usbcore [last unloaded: scsi_wait_scan] Pid: 27030, comm: dd Tainted: G W 2.6.31-rc9-mm1 #13 Call Trace: [] warn_slowpath_common+0x8d/0xbb [] warn_slowpath_fmt+0x50/0x66 [] ? mempool_alloc+0x80/0x146 [] free_page_mlock+0x84/0xce [] free_hot_cold_page+0x105/0x20b [] __pagevec_free+0x87/0xb2 [] release_pages+0x17c/0x1e8 [] ? trace_hardirqs_on_caller+0x32/0x17b [] free_pages_and_swap_cache+0x72/0xa3 [] tlb_flush_mmu+0x46/0x68 [] unmap_vmas+0x61f/0x85b [] ? trace_hardirqs_on_caller+0x32/0x17b [] zap_page_range+0xba/0xf9 [] unmap_mapping_range_vma+0x7a/0xff [] unmap_mapping_range+0x1c6/0x26d [] truncate_pagecache+0x49/0x85 [] simple_setsize+0x44/0x64 [] vmtruncate+0x25/0x5f [] inode_setattr+0x4a/0x83 [] ext4_setattr+0x26b/0x314 [] ? notify_change+0x19c/0x31d [] notify_change+0x1b9/0x31d [] do_truncate+0x7b/0xac [] ? get_write_access+0x59/0x76 [] may_open+0x1c0/0x1d3 [] do_filp_open+0x4c3/0x998 [] ? alloc_fd+0x4a/0x14b [] ? alloc_fd+0x125/0x14b [] do_sys_open+0x6f/0x14f [] sys_open+0x33/0x49 [] system_call_fastpath+0x16/0x1b ---[ end trace e76f92f117e9e06e ]--- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org