[PATCH] mm: Fix to infinite churning of mlocked page

[PATCH] mm: Fix to infinite churning of mlocked page

[Minchan Kim]

Mlocked page might lost the isolatation race.
It cause the page to clear PG_mlocked while it remains
in VM_LOCKED vma. It means it can be put [in]active list.
We can rescue it by try_to_unmap in shrink_page_list.

But now, As Wu Fengguang pointed out, vmscan have a bug.
If the page has PG_referenced, it can't reach try_to_unmap
in shrink_page_list but put into active list. If the page
is referenced repeatedly, it can remain [in]active list
without moving unevictable list.

This patch can fix it.

Reported-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
Cc: KOSAKI Motohiro <<kosaki.motohiro@jp.fujitsu.com>
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Cc: Rik van Riel <riel@redhat.com>
---
 mm/rmap.c   |    1 +
 mm/vmscan.c |    9 +++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index 7d6fe4e..28aafe2 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -363,6 +363,7 @@ static int page_referenced_one(struct page *page,
 	 */
 	if (vma->vm_flags & VM_LOCKED) {
 		*mapcount = 1;	/* break early from loop */
+		*vm_flags |= VM_LOCKED;
 		goto out_unmap;
 	}

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 00596b9..70a63c4 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -630,9 +630,14 @@ static unsigned long shrink_page_list(struct list_head *page_list,

 		referenced = page_referenced(page, 1,
 						sc->mem_cgroup, &vm_flags);
-		/* In active use or really unfreeable?  Activate it. */
+		/*
+		 * In active use or really unfreeable?  Activate it.
+		 * If page which have PG_mlocked lost isoltation race,
+		 * try_to_unmap moves it to unevictable list
+		 */
 		if (sc->order <= PAGE_ALLOC_COSTLY_ORDER &&
-					referenced && page_mapping_inuse(page))
+					referenced && page_mapping_inuse(page)
+					&& !(vm_flags & VM_LOCKED))
 			goto activate_locked;

 		/*
--
1.5.4.3


-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: Fix to infinite churning of mlocked page

[Rik van Riel]

Minchan Kim wrote:
> Mlocked page might lost the isolatation race.
> It cause the page to clear PG_mlocked while it remains
> in VM_LOCKED vma. It means it can be put [in]active list.
> We can rescue it by try_to_unmap in shrink_page_list.
> 
> But now, As Wu Fengguang pointed out, vmscan have a bug.
> If the page has PG_referenced, it can't reach try_to_unmap
> in shrink_page_list but put into active list. If the page
> is referenced repeatedly, it can remain [in]active list
> without moving unevictable list.
> 
> This patch can fix it.
> 
> Reported-by: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> Cc: KOSAKI Motohiro <<kosaki.motohiro@jp.fujitsu.com>
> Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
> Cc: Rik van Riel <riel@redhat.com>

Acked-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: Fix to infinite churning of mlocked page

[KOSAKI Motohiro]

2009/8/20 Rik van Riel <riel@redhat.com>:
> Minchan Kim wrote:
>>
>> Mlocked page might lost the isolatation race.
>> It cause the page to clear PG_mlocked while it remains
>> in VM_LOCKED vma. It means it can be put [in]active list.
>> We can rescue it by try_to_unmap in shrink_page_list.
>>
>> But now, As Wu Fengguang pointed out, vmscan have a bug.
>> If the page has PG_referenced, it can't reach try_to_unmap
>> in shrink_page_list but put into active list. If the page
>> is referenced repeatedly, it can remain [in]active list
>> without moving unevictable list.
>>
>> This patch can fix it.
>>
>> Reported-by: Wu Fengguang <fengguang.wu@intel.com>
>> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
>> Cc: KOSAKI Motohiro <<kosaki.motohiro@jp.fujitsu.com>
>> Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
>> Cc: Rik van Riel <riel@redhat.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>