linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Rik van Riel <riel@redhat.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
	linux-mm <linux-mm@kvack.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Wu Fengguang <fengguang.wu@intel.com>,
	Lee Schermerhorn <lee.schermerhorn@hp.com>
Subject: Re: [PATCH] mm: Fix to infinite churning of mlocked page
Date: Fri, 21 Aug 2009 20:19:02 +0900	[thread overview]
Message-ID: <2f11576a0908210419u2feadeaxc40ffda1cd7f6b2d@mail.gmail.com> (raw)
In-Reply-To: <4A8C98DD.9030500@redhat.com>

2009/8/20 Rik van Riel <riel@redhat.com>:
> Minchan Kim wrote:
>>
>> Mlocked page might lost the isolatation race.
>> It cause the page to clear PG_mlocked while it remains
>> in VM_LOCKED vma. It means it can be put [in]active list.
>> We can rescue it by try_to_unmap in shrink_page_list.
>>
>> But now, As Wu Fengguang pointed out, vmscan have a bug.
>> If the page has PG_referenced, it can't reach try_to_unmap
>> in shrink_page_list but put into active list. If the page
>> is referenced repeatedly, it can remain [in]active list
>> without moving unevictable list.
>>
>> This patch can fix it.
>>
>> Reported-by: Wu Fengguang <fengguang.wu@intel.com>
>> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
>> Cc: KOSAKI Motohiro <<kosaki.motohiro@jp.fujitsu.com>
>> Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
>> Cc: Rik van Riel <riel@redhat.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2009-08-21 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19 23:55 Minchan Kim
2009-08-20  0:29 ` Rik van Riel
2009-08-21 11:19   ` KOSAKI Motohiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f11576a0908210419u2feadeaxc40ffda1cd7f6b2d@mail.gmail.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox