From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 4DB3C6B003D for ; Wed, 1 Apr 2009 09:30:31 -0400 (EDT) Received: by wf-out-1314.google.com with SMTP id 25so34564wfa.11 for ; Wed, 01 Apr 2009 06:30:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <28c262360903310338k20b8eebbncb86baac9b09e54@mail.gmail.com> <20090401165516.B1EB.A69D9226@jp.fujitsu.com> Date: Wed, 1 Apr 2009 22:30:58 +0900 Message-ID: <2f11576a0904010630w5ab7aaa6wccf0a9d30b43bced@mail.gmail.com> Subject: Re: add_to_swap_cache with GFP_ATOMIC ? From: KOSAKI Motohiro Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Minchan Kim , linux-mm , lkml , Andrew Morton , Christoph Lameter , Nick Piggin List-ID: >> IOW, GFP_ATOMIC on add_to_swap() was introduced accidentally. the reason >> was old add_to_page_cache() didn't have gfp_mask parameter and we didn't >> =A0have the reason of changing add_to_swap() behavior. >> I think it don't have deeply reason and changing GFP_NOIO >> don't cause regression. > > You may well be right: we'll see if you send in a patch to change it. > But I won't be sending in that patch myself, that's all :) OK, I'll queue it on my local patch queue. thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org