[BUGFIX][PATCH] vmscan: pgmoved should be cleared after updating recent_rotated

[BUGFIX][PATCH] vmscan: pgmoved should be cleared after updating recent_rotated

[Daisuke Nishimura]

From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>

pgmoved should be cleared after updating recent_rotated.

Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
---
 mm/vmscan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index e895171..56ddf41 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1262,7 +1262,6 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
 	 * Move the pages to the [file or anon] inactive list.
 	 */
 	pagevec_init(&pvec, 1);
-	pgmoved = 0;
 	lru = LRU_BASE + file * LRU_FILE;
 
 	spin_lock_irq(&zone->lru_lock);
@@ -1274,6 +1273,7 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
 	 */
 	reclaim_stat->recent_rotated[!!file] += pgmoved;
 
+	pgmoved = 0;
 	while (!list_empty(&l_inactive)) {
 		page = lru_to_page(&l_inactive);
 		prefetchw_prev_lru_page(page, &l_inactive, flags);


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [BUGFIX][PATCH] vmscan: pgmoved should be cleared after updating recent_rotated

[KOSAKI Motohiro]

> @@ -1262,7 +1262,6 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
>         * Move the pages to the [file or anon] inactive list.
>         */
>        pagevec_init(&pvec, 1);
> -       pgmoved = 0;
>        lru = LRU_BASE + file * LRU_FILE;
>
>        spin_lock_irq(&zone->lru_lock);
> @@ -1274,6 +1273,7 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
>         */
>        reclaim_stat->recent_rotated[!!file] += pgmoved;
>
> +       pgmoved = 0;

Thanks!
    Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>


Andrew, this problem introduced by
b555749aac87d7c2637f153e44bd77c7fdf4c65b (Jan 6).
IOW, it was introduced 2.6.29-rc1. then, I hope this patch merge to
2.6.29 series.

Is this possible?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>