From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: nishimura@mxp.nes.nec.co.jp
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
linux-mm@kvack.org, d-nishimura@mtf.biglobe.ne.jp
Subject: Re: [BUGFIX][PATCH] vmscan: pgmoved should be cleared after updating recent_rotated
Date: Fri, 13 Mar 2009 23:27:43 +0900 [thread overview]
Message-ID: <2f11576a0903130727l7812da61i2e352eea455378e8@mail.gmail.com> (raw)
In-Reply-To: <20090313230627.3fa31cef.d-nishimura@mtf.biglobe.ne.jp>
> @@ -1262,7 +1262,6 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> * Move the pages to the [file or anon] inactive list.
> */
> pagevec_init(&pvec, 1);
> - pgmoved = 0;
> lru = LRU_BASE + file * LRU_FILE;
>
> spin_lock_irq(&zone->lru_lock);
> @@ -1274,6 +1273,7 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> */
> reclaim_stat->recent_rotated[!!file] += pgmoved;
>
> + pgmoved = 0;
Thanks!
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Andrew, this problem introduced by
b555749aac87d7c2637f153e44bd77c7fdf4c65b (Jan 6).
IOW, it was introduced 2.6.29-rc1. then, I hope this patch merge to
2.6.29 series.
Is this possible?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-03-13 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 14:06 Daisuke Nishimura
2009-03-13 14:27 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0903130727l7812da61i2e352eea455378e8@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=d-nishimura@mtf.biglobe.ne.jp \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox