From: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
gerald.schaefer@de.ibm.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
kamezawa.hiroyu@jp.fujitsu.com, y-goto@jp.fujitsu.com,
npiggin@suse.de
Subject: Re: [PATCH] memory hotplug: run lru_add_drain_all() on each cpu
Date: Mon, 8 Dec 2008 23:30:40 +0900 [thread overview]
Message-ID: <2f11576a0812080630j4327dbbgf0aa0e332156d229@mail.gmail.com> (raw)
In-Reply-To: <1228744588.22647.32.camel@lts-notebook>
>> Lee, Could you read this thread and explain why you add ifdef CONFIG_UNEVICTABLE_LRU?
>> I am not sure about that Dave's proposal is safe change. (but I guess he is right)
>
> I added that back in Patch 17/25 "Mlocked Pages are
> non-reclaimable" [before nonreclaimable became unevictable". I did this
> because "lru_add_drain_all()" was only used by numa code prior to this,
> and was under #ifdef CONFIG_NUMA". I called lru_add_drain_all() from
> __mlock_vma_pages_range() [since removed] and I wanted the
> nonreclaimable/unevictable mlocked pages feature to be independent of
> numa. So, I had to ensure that we defined the function for
> nonreclaimable/unevictable lru as well as numa.
>
> Now it appears that hotplug and memcg also depend on
> lru_add_drain_all(), so making it depend on 'SMP looks reasonable to me.
Thanks a lot.
I'll make that patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-12-08 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 21:25 Gerald Schaefer
2008-12-03 22:16 ` Dave Hansen
2008-12-04 0:31 ` KAMEZAWA Hiroyuki
2008-12-04 2:14 ` [PATCH] mm: remove UP version lru_add_drain_all() KOSAKI Motohiro
2008-12-04 2:23 ` KOSAKI Motohiro
2008-12-04 18:01 ` Gerald Schaefer
2008-12-05 13:08 ` [PATCH] memory hotplug: run lru_add_drain_all() on each cpu Gerald Schaefer
2008-12-05 20:43 ` Dave Hansen
2008-12-07 4:43 ` KOSAKI Motohiro
2008-12-08 13:56 ` Lee Schermerhorn
2008-12-08 14:30 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0812080630j4327dbbgf0aa0e332156d229@mail.gmail.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox