From: "KOSAKI Motohiro" <m-kosaki@ceres.dti.ne.jp>
To: Rik van Riel <riel@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Gene Heskett <gene.heskett@gmail.com>
Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment
Date: Tue, 18 Nov 2008 02:32:26 +0900 [thread overview]
Message-ID: <2f11576a0811170932g7f70ab3ai57d03958514124e@mail.gmail.com> (raw)
In-Reply-To: <4921A706.9030501@redhat.com>
2008/11/18 Rik van Riel <riel@redhat.com>:
>
> Fix the old comment on the scan ratio calculations.
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
> ---
> mm/vmscan.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.28-rc5/mm/vmscan.c
> ===================================================================
> --- linux-2.6.28-rc5.orig/mm/vmscan.c 2008-11-16 17:47:13.000000000 -0500
> +++ linux-2.6.28-rc5/mm/vmscan.c 2008-11-17 12:05:03.000000000 -0500
> @@ -1386,9 +1386,9 @@ static void get_scan_ratio(struct zone *
> file_prio = 200 - sc->swappiness;
>
> /*
> - * anon recent_rotated[0]
> - * %anon = 100 * ----------- / ----------------- * IO cost
> - * anon + file rotate_sum
> + * recent_scanned[anon]
> + * %anon = -------------------- * sc->swappiness
> + * recent_rotated[anon]
> */
> ap = (anon_prio + 1) * (zone->recent_scanned[0] + 1);
> ap /= zone->recent_rotated[0] + 1;
looks good to me, absolutely.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-17 17:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 9:38 [PATCH] mm: evict streaming IO cache first KOSAKI Motohiro
2008-11-16 0:58 ` Rik van Riel
2008-11-16 5:00 ` Andrew Morton
2008-11-16 18:15 ` Linus Torvalds
2008-11-16 21:20 ` Rik van Riel
2008-11-16 21:28 ` Hugh Dickins
2008-11-17 4:47 ` Andrew Morton
2008-11-17 6:19 ` Nick Piggin
2008-11-17 6:30 ` KAMEZAWA Hiroyuki
2008-11-17 6:39 ` KOSAKI Motohiro
2008-11-17 6:54 ` KAMEZAWA Hiroyuki
2008-11-17 7:03 ` KOSAKI Motohiro
2008-11-17 8:22 ` KAMEZAWA Hiroyuki
2008-11-17 8:32 ` KOSAKI Motohiro
2008-11-17 16:22 ` Rik van Riel
2008-11-17 16:22 ` Linus Torvalds
2008-11-17 16:27 ` Rik van Riel
2008-11-17 16:37 ` Linus Torvalds
2008-11-17 16:54 ` Rik van Riel
2008-11-17 17:06 ` Linus Torvalds
2008-11-17 17:16 ` [PATCH] vmscan: fix get_scan_ratio comment Rik van Riel
2008-11-17 17:32 ` KOSAKI Motohiro [this message]
2008-11-17 17:35 ` Linus Torvalds
2008-11-17 18:53 ` Rik van Riel
2008-11-17 20:23 ` Rik van Riel
2008-11-18 0:06 ` [PATCH] vmscan: evict streaming IO first Rik van Riel
2008-12-01 20:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0811170932g7f70ab3ai57d03958514124e@mail.gmail.com \
--to=m-kosaki@ceres.dti.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=gene.heskett@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox